Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for Delta Sharing resources; refactoring relevant resources & data sources #3466

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Update documentation for Delta Sharing resources; refactoring relevant resources & data sources #3466

merged 2 commits into from
Apr 16, 2024

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Apr 15, 2024

Changes

  • Move Delta Sharing code into its own sharing package to match go-sdk
  • Update our docs to with a Delta Sharing section, and call out Delta Sharing objects explicitly

Tests

  • make test run locally
  • relevant change in docs/ folder
  • relevant acceptance tests are passing
  • using Go SDK

@nkvuong nkvuong requested review from a team as code owners April 15, 2024 11:15
@nkvuong nkvuong requested review from hectorcast-db and removed request for a team April 15, 2024 11:15
alexott
alexott approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tanmay-db tanmay-db added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit e10d36c Apr 16, 2024
5 checks passed
@tanmay-db tanmay-db deleted the refactor/sharing branch April 16, 2024 08:38
@tanmay-db tanmay-db mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

@tanmay-db tanmay-db tanmay-db approved these changes

@hectorcast-db hectorcast-db Awaiting requested review from hectorcast-db hectorcast-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkvuong @alexott @tanmay-db