Fix integration tests for databricks_entitlements
#3467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The integration tests for
databricks_entitlements
are now failing. I believe this is caused by a race condition betweendatabricks_group
anddatabricks_entitlements
resources. In practice, these resources should not be used at the same time; instead, you should the former when you need to define the group in TF and the latter if the group is defined externally to TF.First, I've improved the test coverage for entitlements to cover all resource types (user, group, service principal). As part of this, I've rewritten the tests to manage the resources externally from Terraform's perspective, so there are no more race conditions. Because of this, I'm able to remove the other integration tests, including the flaky one.
Tests
make test
run locallydocs/
folderinternal/acceptance