Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporter: decrease a need for get-status calls for directories when listing workspace objects #3470

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Exporter: decrease a need for get-status calls for directories when listing workspace objects #3470

merged 4 commits into from
Apr 16, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Apr 15, 2024

Changes

Also, rework handling of longest prefix matches a bit

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott
Exporter: decrease a need for get-status calls for directories when…
1e44466 
… listing

Also, rework handling of longest prefix matches a bit
@alexott alexott requested review from a team as code owners April 15, 2024 16:57
@alexott alexott requested review from mgyucht and removed request for a team April 15, 2024 16:57
tanmay-db
tanmay-db approved these changes Apr 16, 2024
View reviewed changes
exporter/context.go Outdated Show resolved Hide resolved
exporter/context.go Outdated Show resolved Hide resolved
exporter/context.go Show resolved Hide resolved
@alexott alexott added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 160f38e Apr 16, 2024
5 checks passed
@alexott alexott deleted the exporter-emit-dirs-performance branch April 16, 2024 10:23
@tanmay-db tanmay-db mentioned this pull request Apr 16, 2024
Merged
@alexott alexott added the exporter TF configuration generator label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmay-db tanmay-db tanmay-db approved these changes

@mgyucht mgyucht Awaiting requested review from mgyucht mgyucht is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
exporter TF configuration generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexott @tanmay-db