Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Fix integration tests #3902

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Aug 14, 2024

Changes

TestAccSQLEndpoint and TestAccWorkspaceConfFullLifecycle are currently failing on main. The former fails in GCP because @ is not allowed in a tag, so I've replaced it with at. The latter fails because of some checks of capitalization which I've fixed in this PR.

Finally, TestMwsAccNetworkConnectivityConfig is failing on main but is a regression server-side. The test passed on commit 7a2fc352f77101b89c3692ab34c82606605cceed when it ran on August 8, but it now fails on the same commit.

Tests

Ran these integration tests locally, they pass.

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@mgyucht mgyucht marked this pull request as ready for review August 14, 2024 11:58
@mgyucht mgyucht requested review from a team as code owners August 14, 2024 11:58
@mgyucht mgyucht requested review from hectorcast-db and removed request for a team August 14, 2024 11:58
@mgyucht mgyucht added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 0053470 Aug 14, 2024
6 checks passed
@mgyucht mgyucht deleted the fix-integration-tests-2024-08-14 branch August 14, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants