Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Fix integration tests #3902

Merged
merged 2 commits into from
Aug 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/acceptance/sql_endpoint_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func TestAccSQLEndpoint(t *testing.T) {
tags {
custom_tags {
key = "Owner"
value = "eng-dev-ecosystem-team@databricks.com"
value = "eng-dev-ecosystem-team_at_databricks.com"
}
}
}`,
Expand All @@ -37,7 +37,7 @@ func TestAccSQLEndpoint(t *testing.T) {
tags {
custom_tags {
key = "Owner"
value = "eng-dev-ecosystem-team@databricks.com"
value = "eng-dev-ecosystem-team_at_databricks.com"
}
}
}`,
Expand Down
6 changes: 3 additions & 3 deletions internal/acceptance/workspace_conf_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ func assertEnableIpAccessList(t *testing.T, expected string) {
})
require.NoError(t, err)
assert.Len(t, *conf, 1)
assert.Equal(t, (*conf)["enableIpAccessLists"], expected)
assert.Equal(t, expected, (*conf)["enableIpAccessLists"])
}

func TestAccWorkspaceConfFullLifecycle(t *testing.T) {
Expand Down Expand Up @@ -70,11 +70,11 @@ func TestAccWorkspaceConfFullLifecycle(t *testing.T) {
}`,
Check: func(s *terraform.State) error {
// Assert server side configuration is updated
assertEnableIpAccessList(t, "true")
assertEnableIpAccessList(t, "TRue")

// Assert state is persisted
conf := s.RootModule().Resources["databricks_workspace_conf.this"]
assert.Equal(t, "true", conf.Primary.Attributes["custom_config.enableIpAccessLists"])
assert.Equal(t, "TRue", conf.Primary.Attributes["custom_config.enableIpAccessLists"])
return nil
},
})
Expand Down
Loading