latest master changes are merging #1491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comments Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com>
Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com>
Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com>
…PEALS-26715 Alec k/appeals 26715
…PEALS-26715 Alec k/appeals 26715
…PPEALS-20848-original
(Puts on tin foil hat) Prevent potential exceptions from SlackService from impacting user experience
…folder_status_solution hotfix/APPEALS-37942
…PPEALS-39777 Daniel/appeals 39777
…FY24Q2.5.0 Release/FY24Q2.5
….6.2/APPEALS-39456 Changed calls to MetricsService or metrics_service
…FY24Q2.6.2 Release/fy24 q2.6.2
* update .nvmrc * remove extra return * update package.json -add node engine check update yarn.lock * specify 14.20.0 --------- Co-authored-by: Noelle Adkin <98478937+NoelleAd@users.noreply.github.com>
…FY24Q3.3.0 Release/fy24 q3.3.0
* MetricsService.record added for Semaphore lock * noelle/appeals-39842 (#1574) Co-authored-by: Noelle Adkin <98478937+NoelleAd@users.noreply.github.com> --------- Co-authored-by: Anusha Palliyil <palliyil_anusha@bah.com> Co-authored-by: Noelle Adkin <98478937+NoelleAd@users.noreply.github.com>
…FY24Q3.4.0 release/FY24Q3.4.0
* adding ruby_claim_evidence_api gem * Added ruby ce api gem branch * Update v2_fetch_documents_for to Call New API Endpoint * Fix Incorrect JSON Response Paging Value * Update Gem and Fix Misc. Bugs - Use newest version of the CE API gem. - Fix bug in JSON parser causing some fields not to be populated. - Fix bug in date display causing dates to be off by one day. - Update fake to use gem fake in development. * Fix Spec Failure * Deepak/appeals 45276 (#1563) * update fetch_delta_documents_for with CE-api * update specs for fetch_delta_documents_for * update specs --------- Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com> * Kev ma/appeals 45277 v2 (#1564) * include ce_api call in feature toggle * Refactor * Updated spec for v2_fetch_file_document with ce_api * V2 of 45277 * Added ruby ce api response to fakes * Temp changes * removed binding.pry * Revert change * Revert temp cache change * update gemfile with latest commit ID (#1565) * Move PagedDocuments Under CE API Feature Toggle (#1573) * Fix Bug Preventing File Fetching (#1586) * Fix Bug Preventing File Fetching * Update download_manifest_job.rb Remove comment added during testing. * catch ClaimEvidenceApi errors (#1587) * update error class * Updated gem version * Fix Misc. Issues with JSON API Response Handling (#1595) * Fix Misc. Issues with JSON API Response Handling - Add curly braces expected by code depending on the SOAP response. - Update ruby_claim_evidence_api gem version to bugfix version. - Revert display date fix causing issues with old functionality. * Fix Failing Spec * Update received_at Date Parsing Logic (#1596) - Use slashes instead of hyphens to help JS correctly parse the date. * Add Logger to ruby_claim_evidence_api Initializer (#1598) * Add Logger to ruby_claim_evidence_api Initializer * Update to Latest ruby_claim_evidence_api Gem Version * Correctly Handle Blank JSON Responses (#1602) * Correctly Handle Blank JSON Responses * Simplify Error Checking * Fix Line Formatting * Update gem file after bundle install (#1600) * Updated ruby_claim_evidence_api gem * Updated ruby_claim_evidence_api gem * Alec k/appeals 46664 (#1622) * locking aws-sdk-core to 3.131.0 * aws-sdk v2 -> aws-sdk-s3 * ec2 added, caseflow ref added * bundler updated to 2.4.19 for parity * Reverted d3-rails version --------- Co-authored-by: Alec Kagebein <Alec.Kagebein@va.gov> * Andre/appeals-46702 (#1619) (#1625) * Return VBMS document directly to Reader on S3 cache miss * Add separate path for reader api call for document to return from vbms directly for s3 miss * update test for new record api fetch * update record fetcher to use parent child for api only fetcher * update test for reader s3 miss and s3 hits * clean up unneeded spec file --------- Co-authored-by: Andre Pollard <andre.pollard@va.gov> * Andre/appeals-46702 (#1619) (#1632) * Andre/appeals-46702 (#1619) * Return VBMS document directly to Reader on S3 cache miss * Add separate path for reader api call for document to return from vbms directly for s3 miss * update test for new record api fetch * update record fetcher to use parent child for api only fetcher * update test for reader s3 miss and s3 hits * clean up unneeded spec file --------- Co-authored-by: Andre Pollard <andre.pollard@va.gov> * Change FeatureFlag to specify Users (#1630) (#1631) Co-authored-by: andrecolinone <146746795+andrecolinone@users.noreply.github.com> --------- Co-authored-by: Andre Pollard <andre.pollard@va.gov> Co-authored-by: andrecolinone <146746795+andrecolinone@users.noreply.github.com> * Revert "Andre/appeals-46702 (#1619) (#1632)" This reverts commit abf6f08. * Revert "Andre/appeals-46702 (#1619) (#1625)" This reverts commit c64483d. * Updated dependinces faked for CEAPI --------- Co-authored-by: Deepak <santhi.parakal@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: SanthiParakal133 <132940479+SanthiParakal133@users.noreply.github.com> Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com> Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com> Co-authored-by: Alex Smith <alexmcraysmith@gmail.com> Co-authored-by: Alex Smith <alexander.smith6@va.gov> Co-authored-by: Kevin Ma <magavakevin10@gmail.com> Co-authored-by: sbashamoni <138054633+sbashamoni@users.noreply.github.com> Co-authored-by: Alec Kagebein <Alec.Kagebein@va.gov> Co-authored-by: Andre Pollard <andre.pollard@va.gov> Co-authored-by: andrecolinone <146746795+andrecolinone@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* Update ECR workflow to utilize OIDC flow * Update account number for image --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* Fixes error message on line 16 function: invalid_file_number * Updates rspec test to correct error message --------- Co-authored-by: VaForceZ <149601263+VaForceZ@users.noreply.github.com>
* Removed depreciated 5.2 default represent_boolean_as_integer * caseflow-commons update - bourbon/neat removal * Rails gem updated to 6.1.7.4 * app:update bin/rails * app:update bin/rake * app:update bin/setup * app:update bin/spring * app:update bin/yarn * app:update config.ru * app:update application.rb * app:update config/boot.rb * app:update config/environment.rb * app:update config/environments/development.rb * app:update config/enviroments/production.rb * app:update config/environments/test.rb * app:update config/initializers/backtrace_silencers.rb * app:update config/initializers/filter_parameter_logging.rb * app:update config/initializers/permissions_policy.rb * app:update config/puma.rb * app:update config/routes.rb * Updated PG gem for postgres adapter * bourbon/neat code removed * Bundler version correction * final newline error fix * Review changes * ⬆️ Update `caseflow-commons` dependency to latest ref Removes `bourbon` and `neat` dependencies. * Added accidental deletion back in * 🔥 Remove `uglifier` During assets precompile in a 'production' environment, we encountered the following error: Uglifier::Error: Unexpected token: name (compare1). To use ES6 syntax, harmony mode must be enabled with Uglifier.new(:harmony => true). Per the `uglifier` README: UglifyJS only works with ES5. If you need to compress ES6, `ruby-terser` is a better option. Looking at the Caseflow git history for comparison, it looks like the `uglifier` gem was removed in favor of using Webpack to perform JS compression via the `UglifyjsWebpackPlugin`. Later, the `UglifyjsWebpackPlugin` was removed when Webpack v4 incorporated the `TerserWebpackPlugin` out-of-the-box: https://github.com/department-of-veterans-affairs/caseflow-efolder/blob/9853eaeb98692099f1e62435de9a4dc08292fa53/client/yarn.lock#L6119 It appears that there may need to be some additional configuration added to the `webpack.config.js` file in order to leverage the Terser plugin: https://v4.webpack.js.org/plugins/terser-webpack-plugin/ However, the Caseflow `webpack.config.js` does not include the Terser configuration at this time, and so, in keeping parity with Caseflow, we will omit this configuration in eFolder as well and leave it as a future exercise should it be necessary to enact JS compression. * ⏪️ Restore overrides for `config.action_dispatch.use_authenticated_cookie_encryption` and `config.action_dispatch.use_cookies_with_metadata` While testing in PreProd, we discovered that, without these cookie config overrides, re-authentication was broken -- after logging out, a user could not log back in. Since the default settings are still optional going forward, we can restore these overrides and devise a solution to migrate cookies later. For more details, see Jira story APPEALS-54897: https://jira.devops.va.gov/browse/APPEALS-54897 * PG updated to 1.5.7 * PG regressed from 1.5.7 to 1.1.4 for seperate branches --------- Co-authored-by: Alec Kagebein <Alec.Kagebein@va.gov>
…on (#1689) * Add gems, remove datadog * Add OTEL initializer * remove gem * Update gemfile.lock * add rack context propagator * add local development tracing * update gemfile, update OTEL. * update gemfile.lock * update otel config and add comments * commented out lines 12 through 21 of otel instrumentation * commented out line 69 * adds concurrent ruby instrument to config and set to enabled false * Attempt removing rack context propagator. * re-add context. re-add concurrentRuby * comment out activesupport require * remove comment * update initial react data method wrapping hash in a json dump * Revert "update initial react data method wrapping hash in a json dump" This reverts commit 0f398e0. * Limited instruments * remove rack_context propagator. * limited use * new relics changes. * Running bundle install updating Gemfile.lock * Matching eFolder Express to Caseflow for OTEL config and gems * Removing new relic * Adding instruments and rack propagator * Turn off active support * Suppress AWS logs * Remove actionview and redis and turn activesupport back on * Add Redis instrumentation back * Turn ActionPack back on * Add new warning skips to security yaml * removed newrelic references * Fixing a failing test * Remove test failure * Fix failing test * Comment out failing tests * Fixing failing tests * Add tests back * Remove VVA test * Revert spec file * Fixing failing test * Updating failing test * Fixing another test * Lower LC per file * update servie name (#1682) * Adding new CVE to skip in security file * Adding new vulnerability to security file --------- Co-authored-by: Noelle Adkin <98478937+NoelleAd@users.noreply.github.com> Co-authored-by: Andrew Hadley <hadley_andrew@bah.com> Co-authored-by: Dani <danielle.coleman1@va.gov>
…FY24Q4.5.0 Release FY24Q4.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #{efolder issue number} / department-of-veterans-affairs/caseflow#{caseflow issue number} / CASEFLOW-{JIRA number}
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
User Facing Changes
Code Documentation Updates
Database Changes
Only for Schema Changes
migrate:rollbackworks as desired (changesupported functions)make docs(after runningmake migrate)Integrations: Adding endpoints for external APIs