Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest master changes are merging #1491

Closed
wants to merge 143 commits into from
Closed
Show file tree
Hide file tree
Changes from 137 commits
Commits
Show all changes
143 commits
Select commit Hold shift + click to select a range
3321378
APPEALS-26715 added deprecation warning and spec tests from caseflow
AKeyframe Aug 2, 2023
812571f
APPEALS-26715 formatting updates
AKeyframe Aug 2, 2023
38823cb
APPEALS-26715 more formatting
AKeyframe Aug 2, 2023
0d4a9e4
APPEALS-26715 added slack_service and spec from caseflow
AKeyframe Aug 2, 2023
413fa4c
Update app/services/slack_service.rb
AKeyframe Aug 3, 2023
a56deb3
APPEALS-26715 robocop fixes
AKeyframe Aug 3, 2023
2c3a400
Update config/initializers/deprecation_warning_subscriber.rb
AKeyframe Aug 7, 2023
13e5c36
Update config/initializers/deprecation_warning_subscriber.rb
AKeyframe Aug 7, 2023
fcc4bd2
APPEALS-26715 temp removal of slack
AKeyframe Aug 3, 2023
073f72c
eFolder Express Banner messages
anushapalliyil Aug 7, 2023
39acf76
Merge pull request #1405 from department-of-veterans-affairs/AlecK/AP…
sbashamoni Aug 7, 2023
998ce50
:bug: Bugfix - TypeError Exception: allocator undefined for Thread::B…
jcroteau Aug 8, 2023
2ec15c1
:loud_sound: Log additional metadata to Sentry on deprecation warnings
jcroteau Aug 8, 2023
425a99c
Merge pull request #1406 from department-of-veterans-affairs/AlecK/AP…
sbashamoni Aug 8, 2023
1832771
Reworded 3 Banner scenarios
anushapalliyil Aug 8, 2023
e6c9315
updated messaging
anushapalliyil Aug 9, 2023
c32a136
Removed $
anushapalliyil Aug 9, 2023
21981f1
minor edits
anushapalliyil Aug 9, 2023
7a082de
removed a space
anushapalliyil Aug 9, 2023
10c777c
removed comment
anushapalliyil Aug 9, 2023
1f42068
downloadContainerErr changes
anushapalliyil Aug 9, 2023
c96aa04
update document download banner error handling and messaging
mikefinneran Aug 9, 2023
ea2aed5
remove condition from troubleshooting
mikefinneran Aug 9, 2023
d72ee16
remove prodtest config not meant to be included
mikefinneran Aug 9, 2023
7cd0efb
linter fixes
mikefinneran Aug 9, 2023
8bd28dd
Merge branch 'uat/FY23Q4.2.0' into anusha/APPEALS-20848-original
mikefinneran Aug 9, 2023
1084f0a
Merge pull request #1408 from department-of-veterans-affairs/anusha/A…
mikefinneran Aug 9, 2023
7e2f973
:recycle: Only comment out method call and skip related spec
jcroteau Aug 10, 2023
9dd6236
:goal_net: Add blanket rescue to DeprecationWarningSubscriber
jcroteau Aug 10, 2023
040dcfd
:test_tube: Update spec to be less brittle
jcroteau Aug 10, 2023
6f0bc24
Merge pull request #1410 from department-of-veterans-affairs/AlecK/AP…
sbashamoni Aug 10, 2023
7435fab
Refactor changes
divyadasari-va Aug 10, 2023
53e8252
Refactor changes apiAction.jsx
divyadasari-va Aug 10, 2023
0c502fb
Fixed lint issues
divyadasari-va Aug 10, 2023
2cfbca1
Refactored buildErrorMessageFromResponse method
divyadasari-va Aug 10, 2023
d5b0d94
Merge branch 'uat/FY23Q4.2.0' into anusha/APPEALS-20848-refactor
divyadasari-va Aug 11, 2023
4a19228
remove unused downloadcontainererror message
mikefinneran Aug 14, 2023
1d9c77f
remove DOWNLOAD_CONTAINER_ERROR message related code
mikefinneran Aug 14, 2023
e121e58
add space in copy
mikefinneran Aug 14, 2023
3e404d5
uncomment code commented out to trigger banner as example
mikefinneran Aug 14, 2023
86b4737
remove slack related code merged in for uat deploy
mikefinneran Aug 14, 2023
89dd12b
remove override used for demo to trigger messaging
mikefinneran Aug 14, 2023
2c50562
remove code used for testing locally
mikefinneran Aug 15, 2023
b303cfc
Merge pull request #1414 from department-of-veterans-affairs/anusha/A…
mikefinneran Aug 15, 2023
ab0da1a
Revert "remove slack related code merged in for uat deploy"
jcroteau Aug 15, 2023
7662bf4
Revert "Anusha/appeals 20848 refactor"
mikefinneran Aug 21, 2023
c0675da
Merge pull request #1419 from department-of-veterans-affairs/revert-1…
mikefinneran Aug 21, 2023
5a9ddc9
Merge pull request #1415 from department-of-veterans-affairs/AlecK/AP…
mikefinneran Aug 21, 2023
4adefa8
Revert "Revert "Anusha/appeals 20848 refactor""
mikefinneran Aug 31, 2023
101e600
remove doc download progress bar bug
mikefinneran Sep 6, 2023
2773495
Merge pull request #1432 from department-of-veterans-affairs/feature/…
mikefinneran Sep 7, 2023
c10aff0
Bundled with 2.1
raymond-hughes Sep 11, 2023
8b0a1ec
Gemfile updated after bundle
raymond-hughes Sep 11, 2023
f90eef2
Adding a scripts directory and autoload so we can start load testing …
raymond-hughes Sep 12, 2023
b258d84
Refactors user from session method and adds logic to load test script…
raymond-hughes Sep 12, 2023
da9614a
Fixing linting issues
raymond-hughes Sep 14, 2023
3ca22d2
Updating current_user to handle its own connections from the connecti…
raymond-hughes Sep 16, 2023
82aff06
Refactor method for current_user tp pnly wrap save
raymond-hughes Sep 17, 2023
e1e48b3
Update gem to newest connect-vbms version
raymond-hughes Sep 21, 2023
a05bcba
Revert gemfile.lock
raymond-hughes Sep 21, 2023
3744228
Clean up base controller so it caches the session properlly
raymond-hughes Sep 22, 2023
de83f2c
Revert file:wq
raymond-hughes Sep 22, 2023
75075fd
Clean up base controller so it caches user session correctly
raymond-hughes Sep 22, 2023
d264a9f
Updating Gemfile to point to connect_vbms master branch over the ref
raymond-hughes Sep 26, 2023
72818e6
Rebundled new gems
raymond-hughes Sep 26, 2023
a22a3f6
Update security.yml
raymond-hughes Sep 27, 2023
7f9a618
Merge pull request #1439 from department-of-veterans-affairs/hotfix/A…
raymond-hughes Sep 27, 2023
6df87cb
Merge branch 'master' into hotfix/APPEALS-30021
raymond-hughes Sep 28, 2023
f70f8a4
Need to set the helper method current_user as it is used globally.
raymond-hughes Oct 2, 2023
dde54b7
Revet controller change
raymond-hughes Oct 2, 2023
d6917fe
Update method that sets current user so it tracks user on session
raymond-hughes Oct 3, 2023
d93a1ab
Clean up base controller
raymond-hughes Oct 4, 2023
c84258d
Updating user model
raymond-hughes Oct 4, 2023
e067336
Merge pull request #1435 from department-of-veterans-affairs/hotfix/A…
raymond-hughes Oct 11, 2023
4cfd465
Alec k/appeals 26726 (#1452)
jcroteau Oct 12, 2023
f93c909
Merge pull request #1455 from department-of-veterans-affairs/feature/…
sbashamoni Oct 26, 2023
0d040ac
Adding new gemfile and lock
raymond-hughes Oct 27, 2023
1795dc1
Update ref to connect_vbms
raymond-hughes Oct 28, 2023
1d5a146
bundle
raymond-hughes Oct 28, 2023
a7b9e32
Gemfile update
raymond-hughes Oct 28, 2023
d7b17cd
Merge pull request #1462 from department-of-veterans-affairs/hotfix/A…
ArkuBAH Nov 8, 2023
de32345
Revert "hotfix/APPEALS-33769"
raymond-hughes Nov 8, 2023
c0d4459
Merge pull request #1465 from department-of-veterans-affairs/revert-1…
raymond-hughes Nov 8, 2023
7200448
Run bundle update instead of bundle install
raymond-hughes Nov 9, 2023
4cdc136
Update security snooze dates
raymond-hughes Nov 9, 2023
559669e
Update version of connect_vbms
raymond-hughes Nov 13, 2023
f426b4f
Merge pull request #1467 from department-of-veterans-affairs/hotfix/A…
raymond-hughes Nov 15, 2023
03d4543
See pg image version to v14.10
ThorntonMatthew Nov 30, 2023
374b317
Simplify efolder manifest_source logic to prevent stuck manifest
dmage20 Dec 1, 2023
cd03452
remove unused constant
dmage20 Dec 5, 2023
6f00227
refresh the manifest after 72 hours even if pending
dmage20 Dec 5, 2023
cec2610
Set PG version to 14.8
ThorntonMatthew Dec 6, 2023
2d1cf8f
Merge pull request #1474 from department-of-veterans-affairs/MattT/AP…
ThorntonMatthew Dec 7, 2023
55a7587
Changed calls to MetricsService or metrics_service
anushapalliyil Dec 12, 2023
9cbcefd
change datadog
anushapalliyil Dec 13, 2023
f3aa69e
Merge branch 'master' into Daniel/APPEAL-34625
raymond-hughes Dec 18, 2023
3f56b05
ref updated
anushapalliyil Dec 20, 2023
406da82
update chrome link in build.yml (#1489)
craigrva Dec 21, 2023
7e08c05
Anusha/appeals 22205 (#1482)
mikefinneran Dec 21, 2023
4ed40be
Merge pull request #1475 from department-of-veterans-affairs/Daniel/A…
raymond-hughes Dec 21, 2023
99fff14
Merge branch 'master' into anusha/APPEALS-35015
anushapalliyil Dec 27, 2023
17677ab
removed datadog
anushapalliyil Dec 28, 2023
1311712
add document source to records api v2 response headers
dmage20 Feb 14, 2024
b77497d
set manifest records status to success after zipfilecreator is succes…
Mar 7, 2024
cb8dcb6
changed status from failed to success
Mar 8, 2024
2d4d9f2
update caseflow-commons version
mikefinneran Mar 8, 2024
5f89bf1
update caseflow-commons version
mikefinneran Mar 8, 2024
bc5a1b6
refactored code to only update records with initialized status
Mar 12, 2024
7a616bd
Upgrade Redis to v6.2.6
ThorntonMatthew Mar 13, 2024
a028b55
caseflow-commons ref change & data_dog_service file removed
anushapalliyil Mar 13, 2024
352bd62
Revert "update caseflow-commons version"
mikefinneran Mar 14, 2024
4ae2c54
update commons version with --conservative
mikefinneran Mar 14, 2024
cbf83ec
rename concern
mikefinneran Mar 14, 2024
e246f90
replace datadog reference
mikefinneran Mar 14, 2024
4ac5bdd
include statsd library
mikefinneran Mar 14, 2024
2d22d34
update caseflow commons version
mikefinneran Mar 15, 2024
84603fb
add datadog back in
mikefinneran Mar 15, 2024
b48bc4d
Merge branch 'dev-support/APPEALS-42246' into release/FY24Q2.5.0
ThorntonMatthew Mar 18, 2024
a149b7d
Merge pull request #1514 from department-of-veterans-affairs/hotfix/e…
raymond-hughes Mar 18, 2024
077c3cf
expose return header to reader
andrecolinone Mar 18, 2024
bff2669
refactor metrics service out of caseflow commons
mikefinneran Mar 19, 2024
5f02734
Merge pull request #1529 from department-of-veterans-affairs/Daniel/A…
andrecolinone Mar 19, 2024
13f2fb2
Merge branch 'master' into release/FY24Q2.5.0
ThorntonMatthew Mar 21, 2024
f801ed5
Merge pull request #1536 from department-of-veterans-affairs/release/…
raymond-hughes Mar 21, 2024
57d4d06
🔀 AlecK/APPEALS-38443 - Update to Rails 6.0 (#1538)
jcroteau Mar 22, 2024
7078872
Merge branch 'release/FY24Q2.6.2' into release2.6.2/APPEALS-39456
mikefinneran Apr 1, 2024
45147cf
Merge pull request #1545 from department-of-veterans-affairs/release2…
mikefinneran Apr 1, 2024
7ca6296
Merge pull request #1546 from department-of-veterans-affairs/release/…
mikefinneran Apr 4, 2024
637d81b
release/FY24Q2.7.0 (#1553)
mikefinneran Apr 19, 2024
28d3cf4
Update gemfile and gemfile.lock to point to new bgs version (#1569)
cacevesva May 24, 2024
9d7148c
Update ruby-bgs gemfile and gemfile.lock to new version (#1582)
cacevesva May 30, 2024
dc31dc4
Merge pull request #1583 from department-of-veterans-affairs/release/…
cacevesva May 30, 2024
9179fb8
feature/appeals-39842 (#1601)
mikefinneran Jun 10, 2024
4a95b11
Merge pull request #1608 from department-of-veterans-affairs/release/…
raymond-hughes Jun 18, 2024
95f17c0
Jbowers/APPEALS 43723 efolder node 16 version upgrade (#1610) (#1611)
sbashamoni Jun 21, 2024
d228053
Release R1.6.0 FY24Q3.6 (#1626)
mikefinneran Jul 11, 2024
2a07498
Resolves APPEALS-46700 (#1647) (#1648)
andrecolinone Jul 25, 2024
690351e
Update ECR workflow to utilize OIDC flow (#1653)
ThorntonMatthew Jul 31, 2024
9853eae
MattT/APPEALS-53151 (#1655)
ThorntonMatthew Jul 31, 2024
f22dc4e
Release R2.2.0 FY24Q4.2.0
ronwabVa Aug 12, 2024
c993abe
feature/APPEALS-46558 - Rails 6.1 upgrade (release) (#1683) (#1684)
jcroteau Sep 13, 2024
07ce2c9
feature/APPEALS-50882 - Open Telemetry configuration and implementati…
raymond-hughes Sep 16, 2024
77efda9
Merge pull request #1696 from department-of-veterans-affairs/release/…
raymond-hughes Sep 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ on:

env:
FORCE_COLOR: "1" #Forces color within GHA - Note RSPEC still won't use color see line 199 --tty for rspec color


jobs:
rake:
runs-on: ubuntu-8-cores-latest
services:
postgres:
image: postgres:11.7
image: postgres:14.8
env:
POSTGRES_USER: root
POSTGRES_PASSWORD: password
Expand Down Expand Up @@ -53,16 +53,20 @@ jobs:
steps:
- uses: actions/checkout@v3

- name: Install chromium
- name: install node version
uses: actions/setup-node@v4
with:
node-version: '16.16.0'

- name: Install Chrome
run: |
CHROME_VERSION="106.0.5249.119-1"
apt-get update
wget --no-verbose -O /tmp/chrome.deb https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_${CHROME_VERSION}_amd64.deb \
wget --no-verbose -O /tmp/chrome.deb https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb \
&& apt install -y /tmp/chrome.deb \
&& rm /tmp/chrome.deb
echo "Chrome exe name: $(ls /usr/bin | chrome)"
echo "Chrome version: $(google-chrome --version)"

- name: Ruby version
run: ruby -v

Expand All @@ -89,28 +93,32 @@ jobs:

- name: Assets Precompile
run: |
./ci-bin/capture-log "bundle exec rake assets:precompile"
./ci-bin/capture-log "bundle exec rake assets:precompile"

- name: RSpec
run: |-
mkdir -p ./test-results/rspec
mkdir .webdrivers
chmod -R 777 ${GITHUB_WORKSPACE}
set -o pipefail
runuser -u circleci -- make -f Makefile.example test | tee ./test-results/rspec/rspec.out # circleci refers to user
env:
POSTGRES_HOST: postgres

# Artifact Uploads
- uses: actions/upload-artifact@v3
with:
path: "./test-results"
shell: bash

# Artifact Uploads
- uses: actions/upload-artifact@v3
if: success() || failure()
with:
path: "./test-results"

- uses: actions/upload-artifact@v3
if: failure()
with:
path: "./tmp/capybara"

- uses: actions/upload-artifact@v3
if: success() || failure()
with:
path: "./log/test.log"

Expand All @@ -119,7 +127,7 @@ jobs:
run: |-
npm install -g eslint
./ci-bin/capture-log "make -f Makefile.example lint"
if: ${{ always() }}
if: ${{ always() }}

- name: Security
run: ./ci-bin/capture-log "make -f Makefile.example security"
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
12.13.0
16.16.0
1 change: 1 addition & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ AllCops:
- '**/Rakefile'
- '**/*.rake'
Exclude:
- 'bin/**/*'
- 'db/**/*'
- 'config/**/*'
- 'script/**/*'
Expand Down
17 changes: 15 additions & 2 deletions .security.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
CVES:
CVE-2015-9284: 2021-10-31
CVE-2021-41098: 2021-10-31
GHSA-5pq7-52mg-hr42: 2024-10-31
CVE-2015-9284: 2024-10-31
CVE-2021-41098: 2024-10-31
CVE-2023-22795: 2024-10-31
CVE-2023-22792: 2024-10-31
CVE-2023-28362: 2024-10-31
CVE-2023-23913: 2024-10-31
CVE-2022-44566: 2024-10-31
CVE-2023-38037: 2024-10-31
CVE-2023-22796: 2024-10-31
CVE-2023-28120: 2024-10-31
CVE-2022-32511: 2024-10-31
CVE-2020-36599: 2024-10-31
CVE-2023-40175: 2024-10-31
CVE-2022-45442: 2024-10-31
18 changes: 12 additions & 6 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,19 @@ source ENV["GEM_SERVER_URL"] || "https://rubygems.org"

gem "active_model_serializers"
gem "activejob_dj_overrides"
gem "aws-sdk", "~> 2"
gem "bgs", git: "https://github.com/department-of-veterans-affairs/ruby-bgs.git", ref: "98547485d863f2f0d3bb9a1b9ec92a8fe21ba306"
gem "caseflow", git: "https://github.com/department-of-veterans-affairs/caseflow-commons", ref: "fb6fa9658825c143eb8d202b87128f34ca7e210b"
gem "aws-sdk-s3"
gem "aws-sdk-core", "3.131.0"
gem "aws-sdk-sqs"
gem "aws-sdk-ec2"
gem "bgs", git: "https://github.com/department-of-veterans-affairs/ruby-bgs.git", ref: "a2e055b5a52bd1e2bb8c2b3b8d5820b1a404cd3d"
gem "bootsnap", require: false
gem "caseflow", git: "https://github.com/department-of-veterans-affairs/caseflow-commons", ref: "716b58caf2116da5fca21c3b3aeea6c9712f3b9d"
gem "coffee-rails", "> 4.1.0"
gem "connect_vbms", git: "https://github.com/department-of-veterans-affairs/connect_vbms.git", ref: "ac1ae63ffb04a2ab4d2d5469262981acab162e94"
gem "connect_vbms", git: "https://github.com/department-of-veterans-affairs/connect_vbms.git", branch: "master"
gem "connect_vva", git: "https://github.com/department-of-veterans-affairs/connect_vva.git", ref: "dfd1aeb2605c1f237f520bcdc41b059202e8944d"
gem "distribute_reads"
gem "dogstatsd-ruby"
gem "statsd-instrument"
gem "httpclient"
gem "jbuilder", "~> 2.0"
gem "jquery-rails", ">= 4.3.4"
Expand All @@ -27,12 +32,13 @@ gem "omniauth-saml-va", git: "https://github.com/department-of-veterans-affairs/
gem "pg", "~> 0.18", platforms: :ruby
gem "puma", "5.6.4"
gem "rack-cors", ">= 1.0.4"
gem "rails", "5.2.4.6"
gem "rails", "6.0.6.1"
gem "redis-namespace"
gem "redis-rails", "~> 5.0.2"
gem "redis-semaphore"
gem "request_store"
gem "rubyzip", ">= 1.3.0"
gem "ruby_claim_evidence_api", git: "https://github.com/department-of-veterans-affairs/ruby_claim_evidence_api.git", ref: "095798918338650383b06ff535bc63fc5fbfc8dc"
gem "sass-rails", "~> 5.0"
gem "sentry-raven"
gem "shoryuken", "3.1.11"
Expand Down Expand Up @@ -64,7 +70,7 @@ group :test do
gem "database_cleaner"
gem "launchy"
gem "rspec"
gem "rspec-github", require: false # Github Actions Annotations Formatter
gem "rspec-github", require: false # Github Actions Annotations Formatter
gem "rspec-rails"
gem "rspec-retry"
gem "saml_idp", git: "https://github.com/18F/saml_idp.git", branch: "master"
Expand Down
Loading
Loading