nkirby/APPEALS-30711 #19471
Closed
nkirby/APPEALS-30711 #19471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkirby-va
changed the title
|
Code Climate has analyzed commit 78aa51c and detected 0 issues on this pull request. View more on Code Climate. |
jcroteau
approved these changes
Oct 5, 2023
|
Closing due to inactivity as part of our post-PI cleanup effort. Feel free to reopen if this PR is still desired. |
ThorntonMatthew
deleted the
nkirby/fastjsonapi_to_jsonapi_serializer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Story
https://jira.devops.va.gov/browse/APPEALS-30711
Description
Migrate from deprecated fast_jsonapi to jsonapi-serializer.
Acceptance Criteria
Code compiles correctly
For feature branches merging into master: Was this deployed to UAT?
Best practices
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
spec/serializersandspec/models/serializersare passingCode Climate
Your code does not add any new code climate offenses? If so why?