department-of-veterans-affairs · nkirby-va · Sep 14, 2023 · Sep 14, 2023 · Sep 14, 2023 · Sep 14, 2023
diff --git a/Gemfile b/Gemfile
@@ -25,11 +25,11 @@ gem "countries"
 gem "ddtrace"
 gem "dogstatsd-ruby"
 gem "dry-schema", "~> 1.4"
-gem "fast_jsonapi"
 gem "fuzzy_match"
 gem "govdelivery-tms", require: "govdelivery/tms/mail/delivery_method"
 gem "holidays", "~> 6.4"
 gem "icalendar"
+gem "jsonapi-serializer"
 gem "kaminari"
 gem "logstasher"
 gem "moment_timezone-rails"

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -293,8 +293,6 @@ GEM
       faraday (>= 0.8)
     faraday_middleware (0.13.1)
       faraday (>= 0.7.4, < 1.0)
-    fast_jsonapi (1.5)
-      activesupport (>= 4.2)
     fasterer (0.6.0)
       colorize (~> 0.7)
       ruby_parser (>= 3.13.0)
@@ -363,6 +361,8 @@ GEM
       hana (~> 1.3)
       regexp_parser (~> 1.5)
       uri_template (~> 0.7)
+    jsonapi-serializer (2.2.0)
+      activesupport (>= 4.2)
     kaminari (1.2.1)
       activesupport (>= 4.1.0)
       kaminari-actionview (= 1.2.1)
@@ -751,7 +751,6 @@ DEPENDENCIES
   dry-schema (~> 1.4)
   factory_bot_rails (~> 5.2)
   faker
-  fast_jsonapi
   fasterer
   foreman
   fuzzy_match
@@ -762,6 +761,7 @@ DEPENDENCIES
   immigrant
   jshint
   json_schemer (~> 0.2.16)
+  jsonapi-serializer
   kaminari
   knapsack_pro (~> 3.8)
   logstasher

diff --git a/app/models/serializers/idt/v1/appeal_details_serializer.rb b/app/models/serializers/idt/v1/appeal_details_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Idt::V1::AppealDetailsSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   set_id do |object|
     object.is_a?(LegacyAppeal) ? object.vacols_id : object.uuid
   end

diff --git a/app/models/serializers/idt/v1/appeal_serializer.rb b/app/models/serializers/idt/v1/appeal_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Idt::V1::AppealSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   set_id do |object|
     object.is_a?(LegacyAppeal) ? object.vacols_id : object.uuid
   end

diff --git a/app/models/serializers/idt/v1/veteran_details_serializer.rb b/app/models/serializers/idt/v1/veteran_details_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Idt::V1::VeteranDetailsSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   set_id do
     1
   end

diff --git a/app/models/serializers/v2/appeal_status_serializer.rb b/app/models/serializers/v2/appeal_status_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class V2::AppealStatusSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   include StatusFieldSerializer
   include IssuesFieldSerializer
 

diff --git a/app/models/serializers/v2/hlr_status_serializer.rb b/app/models/serializers/v2/hlr_status_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class V2::HLRStatusSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   include StatusFieldSerializer
   include IssuesFieldSerializer
 

diff --git a/app/models/serializers/v2/legacy_appeal_status_serializer.rb b/app/models/serializers/v2/legacy_appeal_status_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class V2::LegacyAppealStatusSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   include StatusFieldSerializer
 
   set_key_transform :camel_lower

diff --git a/app/models/serializers/v2/sc_status_serializer.rb b/app/models/serializers/v2/sc_status_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class V2::SCStatusSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   include StatusFieldSerializer
   include IssuesFieldSerializer
 

diff --git a/app/models/serializers/work_queue/administered_user_serializer.rb b/app/models/serializers/work_queue/administered_user_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::AdministeredUserSerializer < WorkQueue::UserSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :admin do |object, params|
     params[:organization].user_is_admin?(object)

diff --git a/app/models/serializers/work_queue/appeal_serializer.rb b/app/models/serializers/work_queue/appeal_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::AppealSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   extend Helpers::AppealHearingHelper
 
   attribute :assigned_attorney

diff --git a/app/models/serializers/work_queue/appellant_substitution_history_serializer.rb b/app/models/serializers/work_queue/appellant_substitution_history_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::AppellantSubstitutionHistorySerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :substitution_date
   attribute :original_appellant_veteran_participant_id

diff --git a/app/models/serializers/work_queue/appellant_substitution_serializer.rb b/app/models/serializers/work_queue/appellant_substitution_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::AppellantSubstitutionSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :claimant_type
   attribute :substitution_date

diff --git a/app/models/serializers/work_queue/cavc_dashboard_disposition_serializer.rb b/app/models/serializers/work_queue/cavc_dashboard_disposition_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::CavcDashboardDispositionSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :id
   attribute :cavc_dashboard_id

diff --git a/app/models/serializers/work_queue/cavc_dashboard_serializer.rb b/app/models/serializers/work_queue/cavc_dashboard_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::CavcDashboardSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :id
   attribute :board_decision_date

diff --git a/app/models/serializers/work_queue/cavc_dispositions_to_reason_serializer.rb b/app/models/serializers/work_queue/cavc_dispositions_to_reason_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::CavcDispositionsToReasonSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :id
   attribute :cavc_dashboard_disposition_id

diff --git a/app/models/serializers/work_queue/cavc_remand_serializer.rb b/app/models/serializers/work_queue/cavc_remand_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::CavcRemandSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :id
   attribute :cavc_decision_type

diff --git a/app/models/serializers/work_queue/cavc_remands_appellant_substitution_serializer.rb b/app/models/serializers/work_queue/cavc_remands_appellant_substitution_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::CavcRemandsAppellantSubstitutionSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :substitution_date
   attribute :participant_id

diff --git a/app/models/serializers/work_queue/decision_review_serializer.rb b/app/models/serializers/work_queue/decision_review_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::DecisionReviewSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   attribute :issues do
     object.request_issues.active.map do |issue|
       {

diff --git a/app/models/serializers/work_queue/decision_review_task_serializer.rb b/app/models/serializers/work_queue/decision_review_task_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::DecisionReviewTaskSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   def self.decision_review(object)
     object.appeal

diff --git a/app/models/serializers/work_queue/docket_switch_serializer.rb b/app/models/serializers/work_queue/docket_switch_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::DocketSwitchSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :disposition
   attribute :docket_type

diff --git a/app/models/serializers/work_queue/legacy_appeal_serializer.rb b/app/models/serializers/work_queue/legacy_appeal_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::LegacyAppealSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   extend Helpers::AppealHearingHelper
 
   attribute :assigned_attorney

diff --git a/app/models/serializers/work_queue/legacy_issue_serializer.rb b/app/models/serializers/work_queue/legacy_issue_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::LegacyIssueSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :levels
   attribute(:program) { |object| object.codes[0] }

diff --git a/app/models/serializers/work_queue/legacy_task_serializer.rb b/app/models/serializers/work_queue/legacy_task_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::LegacyTaskSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :is_legacy do
     true

diff --git a/app/models/serializers/work_queue/nod_date_update_serializer.rb b/app/models/serializers/work_queue/nod_date_update_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::NodDateUpdateSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :old_date
   attribute :new_date

diff --git a/app/models/serializers/work_queue/notification_serializer.rb b/app/models/serializers/work_queue/notification_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::NotificationSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   attribute :notification_type
   attribute :event_date
   attribute :event_type

diff --git a/app/models/serializers/work_queue/organization_serializer.rb b/app/models/serializers/work_queue/organization_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::OrganizationSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   attribute :id
   attribute :name
 end
diff --git a/app/models/serializers/work_queue/power_of_attorney_serializer.rb b/app/models/serializers/work_queue/power_of_attorney_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::PowerOfAttorneySerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   attribute :id
   attribute :claimant_participant_id
   attribute :poa_participant_id

diff --git a/app/models/serializers/work_queue/priorloc_serializer.rb b/app/models/serializers/work_queue/priorloc_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::PriorlocSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :assigned_by
   attribute :assigned_at

diff --git a/app/models/serializers/work_queue/task_column_serializer.rb b/app/models/serializers/work_queue/task_column_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::TaskColumnSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   def self.serialize_attribute?(params, columns)
     (params[:columns] & columns).any?

diff --git a/app/models/serializers/work_queue/task_serializer.rb b/app/models/serializers/work_queue/task_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::TaskSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   attribute :is_legacy do
     false
   end

diff --git a/app/models/serializers/work_queue/user_serializer.rb b/app/models/serializers/work_queue/user_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::UserSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   attribute :css_id
   attribute :full_name
   attribute :email

diff --git a/app/models/serializers/work_queue/veteran_record_request_serializer.rb b/app/models/serializers/work_queue/veteran_record_request_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::VeteranRecordRequestSerializer < WorkQueue::DecisionReviewTaskSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   def self.claimant_name(object)
     decision_review(object).claimant.try(:name)

diff --git a/app/models/serializers/work_queue/veteran_serializer.rb b/app/models/serializers/work_queue/veteran_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class WorkQueue::VeteranSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :full_name, &:veteran_full_name
   attribute :gender, &:veteran_gender

diff --git a/app/serializers/api/v2/hearing_serializer.rb b/app/serializers/api/v2/hearing_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Api::V2::HearingSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :address do |hearing|
     if FeatureToggle.enabled?(:extended_hearing_api_address, user: RequestStore[:current_user])

diff --git a/app/serializers/api/v3/claimant_serializer.rb b/app/serializers/api/v3/claimant_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Api::V3::ClaimantSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   set_key_transform :camel_lower
 
   self.record_type = "Claimant"

diff --git a/app/serializers/api/v3/contestable_issue_serializer.rb b/app/serializers/api/v3/contestable_issue_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Api::V3::ContestableIssueSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   set_key_transform :camel_lower
 
   def initialize(contestable_issue, options = {})

diff --git a/app/serializers/api/v3/decision_issue_serializer.rb b/app/serializers/api/v3/decision_issue_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Api::V3::DecisionIssueSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   set_key_transform :camel_lower
 
   self.record_type = "DecisionIssue"

diff --git a/app/serializers/api/v3/higher_level_review_serializer.rb b/app/serializers/api/v3/higher_level_review_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Api::V3::HigherLevelReviewSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
   set_key_transform :camel_lower
 
   set_id :uuid

diff --git a/app/serializers/api/v3/legacy_appeal_serializer.rb b/app/serializers/api/v3/legacy_appeal_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Api::V3::LegacyAppealSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   set_key_transform :camel_lower
   set_id :vacols_id

diff --git a/app/serializers/api/v3/legacy_related_issue_serializer.rb b/app/serializers/api/v3/legacy_related_issue_serializer.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Api::V3::LegacyRelatedIssueSerializer
-  include FastJsonapi::ObjectSerializer
+  include JSONAPI::Serializer
 
   attribute :summary, &:friendly_description
 end