Caceves/khalin 41705 #21538

* Refactor for Auto-Assignment Permission Check - Rework auto-assignment logic and add new check for auto-assign user permission. - Add specs and supporting files. * Fix Linting Issues * Add Seeds for Auto-Assign Permissions * add nod check * Update rspec * small fix --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>

* Add Auto-Assignment Logging Tables * Add User Association to BatchAutoAssignmentAttempt

* Created auto assign logger for statistics * Added comments for future work * Updated method * Update log * Added current user to initialization * Added current user to @current_user, changed record methods from private to public, added parameters to assignment method * Added base code for rspecs

- Refactor auto assigner class to follow master algorithm and move user finding logic piece into separate class. - Update a few classes with support methods needed and add specs.

* Update MailTeamSupervisor with InboundOpsTeam (#20529) * Add permissions to Organizations (#20543) * Create OrganizationPermissions * Add Column Comments to Migration * Add Indices Using add_safe_index * Create OrganizationUserPermission and Related Files * Change OrganizationUserPermission Inheritance --------- Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com> * Kev ma/appeals 38420 (#20527) * Initial job files created; added RunAsyncable module to controller * Added aria-label for spec fix * Refactor to functional component * Added Auto Assign Correspondences Button, added route, added method to controller * Updated spec for future testing * Added initla business logic for assignment * Updated seed data for VADOR date * Update to include current user for seed data when ran individually * Optimized SQL query by 10% * Updated instruction details to contain css_id * Update reek file for job, fixed rubocop and linting * Updated class name * Removed unused constant * Refactor Correspondence Auto-Assign Logic (#20556) * Refactor Correspondence Auto-Assign Logic - Move logic into new service class called by auto-assign job. - Add specs and other supporting files. * Add Missing Method Name * Fix Data Setup Causing Spec Failure * Create Auto Assignment Permission Check (#20565) * Refactor for Auto-Assignment Permission Check - Rework auto-assignment logic and add new check for auto-assign user permission. - Add specs and supporting files. * Fix Linting Issues * Add Seeds for Auto-Assign Permissions * Deepak/appeals 38547 (#20578) * Refactor for Auto-Assignment Permission Check - Rework auto-assignment logic and add new check for auto-assign user permission. - Add specs and supporting files. * Fix Linting Issues * Add Seeds for Auto-Assign Permissions * add nod check * Update rspec * small fix --------- Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> * Add Auto-Assignment Logging Tables (#20608) * Add Auto-Assignment Logging Tables * Add User Association to BatchAutoAssignmentAttempt * Created auto assign logger for statistics (#20610) * Created auto assign logger for statistics * Added comments for future work * Updated method * Update log * Added current user to initialization * Added current user to @current_user, changed record methods from private to public, added parameters to assignment method * Added base code for rspecs * Refactor Auto-Assignment and Add Sensitivity Check - Refactor auto assigner class to follow master algorithm and move user finding logic piece into separate class. - Update a few classes with support methods needed and add specs. * Add Correspondence Auto Assignment Logging - Rework class to log auto-assignment attempts. - Add logging to auto-assigner. - Add specs and rework some constants to follow app guidelines. --------- Co-authored-by: SanthiParakal133 <132940479+SanthiParakal133@users.noreply.github.com> Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com> Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>

…on queue (#20743)

* Create Inbound Ops users * create Mail Team and Mail Team super user * Update name * update sensitivity_level for users and veterans * Revert "update sensitivity_level for users and veterans" This reverts commit 877e941. * small fix

* Create CreateCorrespondenceAutoAssignmentLevers * Add Uniqueness Constraint

* adding correspondence task default route * adding intake and review package route overrides * adding efolder ulpoad failed logic for routing * adding efolder failed upload task depending on parent task * fixing intake scoping * adding task_url attribute to column serializer * attempting a correspondence root task addition * Moved constant file for access * removing root task method, since all defaults to /under_construction * replacing task urls from a newly created constants file * code cleanup * adding tests * rubocop and linting errors * rubocop fixes * Serialize attributes regardless of values * Make CorrespondenceTask an abstract class * Make package action tasks inherit from CorrespondenceTask * Update to not intatiate abstract CorrespondenceTasks * Refactor queue correspondences seeds * Fix broken pagination on Correspondence Cases team page * Merge with feature 32900 * Randomize va date of receipt * Remove expectation to find instance of CorrespondenceTask - an abstract class * Remove expectation for abstract class to appear in task tree * Merge in task url work * Add ability to link veterans details to tasks or modals * Route to under construction if closed * Assign ReviewPackageTask before creating EfolderUploadFailedTask * give ids and labels to column items * Add CorrespondenceTaskHelpers module * Test: correspondene queue task links spec * Move url strings into constants file * Fix extra space --------- Co-authored-by: sulak-j <justin.sulak@va.gov>

* APPEALS-39894 - Fixes for Linting and Props * Spec Updates --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* update the length of line * update count * update paper_trail

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* change continue buttom * Continue button * add space for taskupdatecallback --------- Co-authored-by: Kamala Madamanchi <kamala.madamanchi@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* Test: verifies no other open package action task on correspondence before creation * Rubocop style fixes * Update expectation to match new requirements * add more wait time to address flakiness in CI * fix issue where EfolderFailedUploadTasks had parent task belonging to wrong Correspondence * fix issue where correspondence queue breaks after completing intake form * fix wrong url for reassign package task * Fix test: when remove package task is pending review * use_history not needed * Revert "Fix test: when remove package task is pending review" This reverts commit f2dd043.

…File Naming (#20861) * Rework Seed Data Logic - Rename correspondence seeds files with correspondences in name in order to clarify their purpose. - Create seed file for creating correspondence auto-assignment levers. * Use organziation when finding OrganizationPermission

- Add logic for finding auto-assignable users with capacity for correspondence tasks. - Add supporting files and specs. Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>

* Added AutoAssignButton, AutoAssignAlertBanner. Updated Correspondence Auto Assign Logger and Assigner, added auto assign status polling route, added factory for BatchAutoAssignmnetAttempts, updated specs, updated bgs fakes service method, CodeClimate fixes, Linting fixes * Revert private methods placement * Only allow one job to be ran at a time per user

…m field (#20893) * align letter * fix size of selector --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* fixing AutoTexts * Renamed Seed file --------- Co-authored-by: Kevin Ma <magavakevin10@gmail.com>

* cherrypicked files * second cherrypick * more cherry picking. * Reformatted code to be more OOP friendly and less verbose. * big fix in logic * added appeal_type, fixing many errors. * added appeal type to factory * improved filter, and fixed some unit tests. * fixed efolder uploader spec * fixed task_spec * potential fix * unit test fix * fixed Correspondence Intake Task * fixed linting issues. * removed comments and binding pry --------- Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* basic edit letters canges * edit section * refactoring and lint fixes * resolving conflicts * bug fix for date and custom value * fixing remove letter bug * fixing lint * fies for lint error * lint fix * adding response letters

* update seed file to create package action tasks with assigned_by value * Update tasks call for action required tab * Update columns in QUEUE_COLUMN constants file * Add sorting to columns * refactor query to use scope * always use task pages api for this workflow * ensure assigned by is a user * merge with ryan/APPEALS-35479-check * add cancel link to package action modals * add tests for action required tab * remove pry * refactor tasks method * refactor correspondence task filter * include appeal_type when creating * refactor test setup * remove duplicate tests * add current user * add appeal type * refactor to remove magic string * Add required fields for correspondence_intake_task creation * Add modal titles to constants file * remove pry * update test for new tab requirements * update jest snapshot

@appeals

* correspondence_queue_colomn.rb shell * Removing binding.pry * Reverted some changes on queue column * Updated correspondence_queue_colomn.rb shell * temporary seed data waiting for clarification * Initial commit for Veteran Detail sorting * resolved merge conflicts * CorrespondenceTask is now abstract * Correspondence Root Task no longer creates (it's abstract) * jolly postman seed data update * fixed error on corr queue column. * Sorting feature for Veteran details * sorting on Notes * Task filter setup * added filter option to VA DOR column * added isReceiptFilter to TableFilter props. * Added isReceiptFilter props to TableFilter. * Added empty recieptdaterPicker component * fixed spelling mistakes. * Fixed the bug when changing to mailteamSupervisor user * Days waiting sorting functionality * Front end reciepdate picker now has basic functionality. Backend query sent. * Displaying tasks queues according to the Correspondence Cases and Your Correspondence Case * rubocop fixes * rubocop fixes * Commit for rubocop fix * checkpoint * Fixed team page pager issue * fixed list items showing for vaDor filter * Missing features from merge request * Updated changes to frontend. * Completed functionality for everything but between date filters. * Filter options for VA DOR * Updated ReceiptDatePicker to be standalone * updated filter to be a little more clear * add seed file to populate judges and attorneys from VACOLS * Revert "Revert "Feature/appeals 26736"" * hotfix/APPEALS-39368: fix bug where nil ends up in @appeals array (#20668) * fix bug where nil ends up in @appeals array * add ama_statistics error handling * clarify error message when rescuing in ama_statistics * fix priority push job * fix tests * added nonpriority iterations to until clause in requested_distribution * add tests for limiting nonpriority iterations * change iterations limit to batch_size * fix test * Ki/APPEALS-39894 - Update Test & Linting Errors (#20776) * APPEALS-39894 - Fixes for Linting and Props * Spec Updates --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Commit for frontend changes for Date Completed column * debug and linting fix * Re-enabled filtering by veteran details. * Cleaned up code and fixed a bug in the filtering. * Added proptypes, removed unused variables. * Frontend datePicker changes for DateCompleted * Fixed receipt spelling. * fixed rubocop issues * Frontend datepicker changes * DateCompleted filtering updated with required options * reorganized the code so that styles don't get overwritten. * changed name column to be more consistent with wireframes. * Lint fixes * fixed linting issues and made UI match wireframes. * add seed file to populate judges and attorneys from VACOLS * Revert "Revert "Feature/appeals 26736"" * hotfix/APPEALS-39368: fix bug where nil ends up in @appeals array (#20668) * fix bug where nil ends up in @appeals array * add ama_statistics error handling * clarify error message when rescuing in ama_statistics * fix priority push job * fix tests * added nonpriority iterations to until clause in requested_distribution * add tests for limiting nonpriority iterations * change iterations limit to batch_size * fix test * Wmedders21/appeals 39237 (#20834) * Test: verifies no other open package action task on correspondence before creation * Rubocop style fixes * Update expectation to match new requirements * add more wait time to address flakiness in CI * fix issue where EfolderFailedUploadTasks had parent task belonging to wrong Correspondence * fix issue where correspondence queue breaks after completing intake form * fix wrong url for reassign package task * Fix test: when remove package task is pending review * use_history not needed * Revert "Fix test: when remove package task is pending review" This reverts commit f2dd043. * Removed to_json and renamed method (#20839) * Reimplemented disabling of receiptdate filter. * fixed clear filters, made clicking the reset button more consistent in the UI. * filtering enabled and disabled feature * Lint issues * Lint fixes * updated notes to be a little more varied. * added support for correctly filtering veteran info & notes. * fixed VA DOR sorting. * fixed sorting for receipt date filter * Date filter dropdown issue fixed * Commit for lint fix and feature test cases * Removed commented lines * lint issues * PG::NotNullViolation issue fix * Jest errors snapshots updated * Modified the changes as requested * Rubocop fixes * Improvement for filter logic * Spec failing fixes * Some other rspec fail fix * Spec fixes * Spec fixes after merge * Modified completed tasks to aviod eager loading message in the logs --------- Co-authored-by: Dev-KRedd <khalin.redding@va.gov> Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: IsaiahBar <isaiah.barnett@va.gov> Co-authored-by: Craig Reese <Reese_Craig@bah.com> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: Ki Mau <ki.mau@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com> Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>

* merge into feature * refactoring the code * Fix style issue * Add space in _table.css file

* basic edit letters canges * edit section * refactoring and lint fixes * resolving conflicts * bug fix for date and custom value * fixing remove letter bug * fixing lint * fies for lint error * lint fix * adding response letters * fix for continue button after Edit section and space issue --------- Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* update seed file to create package action tasks with assigned_by value * Update tasks call for action required tab * Update columns in QUEUE_COLUMN constants file * Add sorting to columns * refactor query to use scope * always use task pages api for this workflow * ensure assigned by is a user * merge with ryan/APPEALS-35479-check * add cancel link to package action modals * add tests for action required tab * remove pry * refactor tasks method * refactor correspondence task filter * include appeal_type when creating * APPEALS-35482 - CSS Fix * APPEALS-35482 - Linting and RSpecs * APPEALS-35482 - Rspecs, Filtering, Snapshots * Update QueueDropdownFilter.jsx --------- Co-authored-by: William Medders <medders_william@bah.com>

* update seed file to create package action tasks with assigned_by value * Update tasks call for action required tab * Update columns in QUEUE_COLUMN constants file * Add sorting to columns * refactor query to use scope * always use task pages api for this workflow * ensure assigned by is a user * merge with ryan/APPEALS-35479-check * add cancel link to package action modals * add tests for action required tab * remove pry * refactor tasks method * refactor correspondence task filter * include appeal_type when creating * APPEALS-35482 - CSS Fix * APPEALS-35482 - Linting and RSpecs * APPEALS-35482 - Rspecs, Filtering, Snapshots * Update QueueDropdownFilter.jsx * updated task for Assigned tab --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: KiMauVA <Ki.Mau@va.gov> Co-authored-by: Jim Foley <james.foley4@va.gov>

…es (#20920) Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* Change correspondence_task to abstract class * Refactor correspondence root task to not have a parent task * do not expect abstract correspondence_task to appear in task tree * Update test to not look for a now abstract class instance -CorrespondenceTask * Fix for appeals not loading on step 2 of intake form * add evidence submission window attribute to re-serializer * Remove package document type column to fix flaky test * Refresh to fix flaky test

…20960) * Package action task refactor for create verification and inheritance * fix typo

* Bugifx for banner color * Fixed constants typo

* randomize closed at for correspondence root task seeds * update seeds to have varying values to be able to test sorting columns

* update seed file to create package action tasks with assigned_by value * Update tasks call for action required tab * Update columns in QUEUE_COLUMN constants file * Add sorting to columns * refactor query to use scope * always use task pages api for this workflow * ensure assigned by is a user * merge with ryan/APPEALS-35479-check * add cancel link to package action modals * add tests for action required tab * remove pry * refactor tasks method * refactor correspondence task filter * include appeal_type when creating * APPEALS-35482 - CSS Fix * APPEALS-35482 - Linting and RSpecs * APPEALS-35482 - Rspecs, Filtering, Snapshots * Update QueueDropdownFilter.jsx * updated task for Assigned tab * fix test * modified expect * fix tasks filter * test for tasks filter * fixed tasks * updating Tasks filter * update query for tasks --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: KiMauVA <Ki.Mau@va.gov> Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

…20968) * Add Checks to Ensure Correspondence Auto Assignment Job Uniqueness - Update the CorrespondenceAutoAssigner to do validations before running to ensure we don't end up with parallel auto assign jobs. - Add and update specs as needed. * Update Incorrect Time Field Checks --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* APPEALS-35482 - Conditional assign button for mail team super * APPEALS-35482 - QueueTable pagination update * APPEALS-35482 - Undo currentPage Issue * Delete client/test/app/queue/__snapshots__/QueueTable.test.js.snap * Update snapshot

* Rubocop stying errors fixed * Duplication Issues * Duplication issues * Duplication fix * Complexity Reek Errors WIP * De-couple CorrespondenceConfig from QueueConfig Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> * Replace conditional with Polymorphism * Reek Attribute comment * Removal of dead code * frozen_string_literal addition * Removal of dead code & addition of DataClump comment * Styling fixes * styling * Adding process_correspondence method back * Revert "Replace conditional with Polymorphism" This reverts commit 4fa20e9. * Revert "De-couple CorrespondenceConfig from QueueConfig" This reverts commit 7b8e450. * Revert "Removal of dead code" This reverts commit b9ac6fc. * Revert "Removal of dead code & addition of DataClump comment" This reverts commit bb7ffe8. * Adding back from merge conflict * Wmedders21/appeals 40978 on my local(Will revert before PR) * Fixing tests * Syling Fixes * Rubocop Styling fixes * Complexity fixes * Duplication fix * Styling fix * Styling fix --------- Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…21003)

* To get mail team users in the dropdown * made mail team users populate as a prop. * Added checkboxes that are functional, retain state after tab / index changes. * Backend update for mailteam users with selected tasks * Updated the flash message with the required banner status * Updated the flash message with the required banner status * Status update with assigned * prototype page reload * Banner success message * Syntax error fix * added tasks filter test for mail team admin * Banner message work updated * Commit for Assign button disable and enable * Modified dropdown fix for Assign button * code cleanup checkpoint * refactored correspondence_controller to handle different banner results * Feature test spec for batch assignment for unassigned tab * feature test cases for cob user * fixed COB issue and added feature flag. * added failure case for tasks * Removed the banner stuff for Nod * fixed logic on set_banner_params * swapped banner type to info * Clean up the code and lint issues * Changes to Reassigned work * Feature tests for Assigned tab for batch assignment * Spec issues fixes * Modified the suggested changes --------- Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com>

* merge issue on activrecord * Fixed tasks filter with multiple options * refactored to be cleaner * refactored CorrespondenceTaskFilter to be OOP best practices and added clarification comments. * Made suggested changes and fixed efolder upload failed task link on the backend. --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* fix feature test * Revert "fix feature test" This reverts commit 948d637. * pushing up tests for ryan to run * feature tests --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

… populating. (#21035) * updates query to prevent efolderuploadfailed tasks * updated query to look better * Fixed task sorting. --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* Add new correspondence tasks not related to appeal * Fix error when submitting correspondence intake * Add scope tasks_not_related_to_appeal * Change intake processor to create new correspondence tasks * Refactor to have new Correspondence task class names * Refactor to simplify and be less flaky * Refactor with the updated class names * add veteran full name * create abstract base class for tasks not related to an appeal * remove task not related to appeal scope * move correspondence mail tasks to folder * correspondence mail tasks inherit from CorrespondenceMailTask * remove hard coded true return for task creation verification * abstract class and create child class override * replace deleted verification bypass * revert task creation refactor

* add nod column in correspondences * update seed data with the nod value * fix Reek Violation * Fix schema file * fix error about nod * Fix NOD Correspondence Spec Failure --------- Co-authored-by: Kamala Madamanchi <kamala.madamanchi@va.gov> Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com>

* Add new correspondence tasks not related to appeal * Fix error when submitting correspondence intake * Add scope tasks_not_related_to_appeal * Change intake processor to create new correspondence tasks * Refactor to have new Correspondence task class names * Refactor to simplify and be less flaky * Refactor with the updated class names * add veteran full name * create abstract base class for tasks not related to an appeal * remove task not related to appeal scope * move correspondence mail tasks to folder * correspondence mail tasks inherit from CorrespondenceMailTask * remove hard coded true return for task creation verification * abstract class and create child class override * replace deleted verification bypass * revert task creation refactor Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com>

This reverts commit 66172ae, reversing changes made to 2726e64.

…EALS-27311"" This reverts commit 1599cfa.

* WIP for new seeds file * Updated query so data shows in table * Revert "WIP for new seeds file" This reverts commit ea1dd11. * Updated query so data shows in table * Your Correspondence completed tab completed test spec --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* Fix Incorrect Error Banner Color - Use copy error message to allow the frontend to correctly identify error messages generated by feature toggle. - Update controller and logging logic to ensure that errored auto assignment attempts get updated with the correct status when possible. * Fix Conditional Check --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* Fix Incorrect Error Banner Color - Use copy error message to allow the frontend to correctly identify error messages generated by feature toggle. - Update controller and logging logic to ensure that errored auto assignment attempts get updated with the correct status when possible. * Fix Conditional Check * Update Correspondence Auto Assign Banner - Update banner color to be the yellow warning color. - Update title verbiage for unsuccessful auto assignment run attempts. --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* Changed to passdown isSupervisor and isSuperuser prop to correspondence table builder * updated logic for displaing bulk assign area.

* merge issue on activrecord * Fixed tasks filter with multiple options * refactored to be cleaner * refactored CorrespondenceTaskFilter to be OOP best practices and added clarification comments. * Made suggested changes and fixed efolder upload failed task link on the backend. * Reversed the sort order for days waiting. --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* initial commit with some setup * fixing error in correspondence controller * adding variables for step and redux store objects from database * Working on resuming saved store * Some testing in the AddAppealRelatedTaskView for fixing step 2 * somehow was not added to the merge * removing reduxStore from previous attempt * attempting fix for new correspondences looking for the saved intake * running some tests * cleaned up comments and set up pulled store to show on page 3 of intake * current intake data is being stored in the session * Bug when trying to edit the task the name should popup in the select box * Feature testcases * Lint fixes * Fix for spec changes * comment edits * comment edits * removing schema to match feature * testing a spec change with page text * testing with moving the post into the actions * Changes to post method to actions * removing current step from queue app * linting fix * removing extraneous code * added .then to cancel POST and resolved linting complaints * removed unused prop --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…fixes (#21047) Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* fix error processing intake * Add models for tasks not related to appeal * sub models for tasks not related to appeal * allow intake processor to create new models * add scope for tasks not related to appeal * write query for pending tab tasks * update seeds to create updated models * update task not related to appeal craetion at the end of intake * merge issue on activrecord * Fixed tasks filter with multiple options * refactored to be cleaner * refactored CorrespondenceTaskFilter to be OOP best practices and added clarification comments. * APPEALS-35480 - Filter Updates * Add new correspondence tasks not related to appeal * Fix error when submitting correspondence intake * Add scope tasks_not_related_to_appeal * Change intake processor to create new correspondence tasks * Refactor to have new Correspondence task class names * Refactor to simplify and be less flaky * Refactor with the updated class names * APPEALS-35480 - Pending Rspec Tests * Merge Conflict updates * add veteran full name * create abstract base class for tasks not related to an appeal * remove task not related to appeal scope * move correspondence mail tasks to folder * correspondence mail tasks inherit from CorrespondenceMailTask * remove hard coded true return for task creation verification * abstract class and create child class override * replace deleted verification bypass * revert task creation refactor * Spec Inbound update * Remove old tasks * Fix Task Call, Remove unneeded old code * current_user * merge conflicts * Remap Pending RSpec Tests * Reverting filter change --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: Jim Foley <james.foley4@va.gov>

* fix feature test * Revert "fix feature test" This reverts commit 948d637. * pushing up tests for ryan to run * feature tests * remove Intake from Veteran Details * resolve pr conflicts --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* WIP for new seeds file * Updated query so data shows in table * Revert "WIP for new seeds file" This reverts commit ea1dd11. * Updated query so data shows in table * Your Correspondence completed tab completed test spec * The completed tab now showing dates * Bug Fix

* Restore Code Deleted During Merge * Fix Misc. Issues - Add eager loading to various finder queries. - Fix spec failures.

* refactored correspondence seeds to accept vet and user. refactored create_correspondence. * refactored seed to create intake correspondence with upload failed task * updated seed to create correspondence with intake task * refactored rest of queue correspondence seed to be able to accept a user and veteran. * lowered count for correspondence seeds * refactored multi_correspondences to create review package tasks, handle user input, and use queue helpers * disabled linting check * added multi correspondence and queue correspondence seeds to rake task * cleaned up correspondence rake to be more DRY

* Update Sensitivity Check - Generate a new BGS Client for each user whose sensitivity level is being inspected. - Update specs and supporting files. * Remove Unneeded Return

* WIP for new seeds file * Updated query so data shows in table * Revert "WIP for new seeds file" This reverts commit ea1dd11. * Updated query so data shows in table * Your Correspondence completed tab completed test spec * The completed tab now showing dates * Bug Fix * Date Completed Filtering Fixed * Updated changes * Fixing Failing test --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

#21170)

* remove unused route and fix typo * standardize prop names * use standardized prop names * use standardized prop names and abstract magic strings * remove unnecessary scoping * CorrespondenceIntakeTask status in_progress on create * update spec for changes * update helper to reflect workflow * correspondence intake task status in progress on creation * efolder upload failed task no longer needs task url since its not displayed on the table * rubocop style fix * rubocop fix extra blank line

* Fix Code Climate Issues * Improve Code - Add class comments to service files. - Add underscores to unused method params in the fake BGS Service. * Fix Bad Method Invocation * Fix Param Causing Spec Failures

* Fix Code Climate Issues * Improve Code - Add class comments to service files. - Add underscores to unused method params in the fake BGS Service. * Fix Bad Method Invocation * Fix Param Causing Spec Failures * Make BGS Service Method Static - This will allow the other static methods to use the init_client_params method.

* adding correspondence intake controller * moving methods that seem to be suited for the intake-specific controller * refactor conditional * updating the routes * Updating the remainder of intake routes * removing a repeated method found * moving intake specs to new intake controller spec * fixing file for failing tests * Fixing failing specs --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: Jim Foley <james.foley4@va.gov>

* modified to show error in date filter * modified datecomplete * change name in header * fix style issue * Fix spec file * Add new test in spec file

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* sorting query for date completed column on correspondence tables * optimize task query for your correspondence completed tab * optimize task query for corresepondence cases completed tab * update correspondence task filter for new column name * add name props to avoid console errors * correct prop types * update with new column name * update seeds to reflect expected workflow * update broken tests * remove unnecessarily bloated test case setup * update broken test expectation

* Fix Code Climate Issues * Improve Code - Add class comments to service files. - Add underscores to unused method params in the fake BGS Service. * Fix Bad Method Invocation * Fix Param Causing Spec Failures * Make BGS Service Method Static - This will allow the other static methods to use the init_client_params method. * Fix Misc. UAT Issues - Handle errors raised by the BGS service. - Update the auto assign status ping to include the correct assigned count. - Fix bug that caused CorrespondenceAutoAssignRunVerifier to incorrectly report that runs are OK. * Fix Incorrect Field Checked for Run Verification

…21202) * mostly finished modal * added conditional rendering of textarea * updated RadioField name * added redux setup for selected veteran details. * added RadioFieldWithChildren component. * Added complete modal for reassign * stored veteran details on click * added diasbled button logic for confirm * wired button for remove package task. * Wired banner message prototype * fixed crash * task now reassigns properly * implemented failure banner and reject option * fixed banner messages. * fixed sizing issue and added textarea to reject * fixed frontend css * improved backend logic. * fixed modal closing X button * fixed error in method call, commented data changing code * backbone for reassign and remove modal tests * added parent_task_url * Implemented taskurl for remove/ reassign task * delete binding pry * tests suite for correspondence cases * refactored logic * data seeding and minor refactors * fix test suit * uncommented experimental code * added remove modal * cleaned up controller logic * final AC work in progress * Fixes for linting and update reviewpackagetask error * futher reduced code climate issues * mode code climate fixes * fixed more code climate issues * fixed linting errors. fixed submit disable logic * refined logic for cleaner user experience * added seed data for reassign / remove package task * fixed bug on buildMailUserData * swapped mismatched messages * finished spec tests * Hot fix to remove Intake from Veterans Details (#21087) * fix feature test * Revert "fix feature test" This reverts commit 948d637. * pushing up tests for ryan to run * feature tests * remove Intake from Veteran Details * resolve pr conflicts --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Khalin/appeals 35818 - Bug Fix (#21091) * WIP for new seeds file * Updated query so data shows in table * Revert "WIP for new seeds file" This reverts commit ea1dd11. * Updated query so data shows in table * Your Correspondence completed tab completed test spec * The completed tab now showing dates * Bug Fix * created completed_by_date and added business logic to root task (#21103) * APPEALS-35488: Update UAT Seed Scripts for Correspondence (#21129) * refactored correspondence seeds to accept vet and user. refactored create_correspondence. * refactored seed to create intake correspondence with upload failed task * updated seed to create correspondence with intake task * refactored rest of queue correspondence seed to be able to accept a user and veteran. * lowered count for correspondence seeds * refactored multi_correspondences to create review package tasks, handle user input, and use queue helpers * disabled linting check * added multi correspondence and queue correspondence seeds to rake task * cleaned up correspondence rake to be more DRY * Khalin/appeals 35818 Date Completed Column Filtering Bug Fix (#21134) * WIP for new seeds file * Updated query so data shows in table * Revert "WIP for new seeds file" This reverts commit ea1dd11. * Updated query so data shows in table * Your Correspondence completed tab completed test spec * The completed tab now showing dates * Bug Fix * Date Completed Filtering Fixed * Updated changes * Fixing Failing test --------- Co-authored-by: Jim Foley <james.foley4@va.gov> * updated completed filter to filter on closed_at value (#21166) * Edit VA DOR access for InboundOpsTeamAdmin user (#21150) * 🔀 jcroteau/APPEALS-38492 - Fix duplicate results from joins on certain AR associations (#21097) * refactored seed scripts for correspondence to have more detailed notes (#21170) * Wmedders21/appeals 41493 (#21162) * remove unused route and fix typo * standardize prop names * use standardized prop names * use standardized prop names and abstract magic strings * remove unnecessary scoping * CorrespondenceIntakeTask status in_progress on create * update spec for changes * update helper to reflect workflow * correspondence intake task status in progress on creation * efolder upload failed task no longer needs task url since its not displayed on the table * rubocop style fix * rubocop fix extra blank line * updated props to new branch props * sanitized string with react * fixed missing end in queue_correspondence * sanitize newUrl attempt #2 * fixed buildMailUserData * added missing end statement * fixed linting * modified per github feedback * refactored redundant code * linting fix. refactored correspondence_controller logic * linting fix * partial refactor with code migrated to correspondence_controller_util * refactored a very large amount of code to the CorrespondenceControlletUtil * Justin/APPEALS-42009 (#21118) * adding correspondence intake controller * moving methods that seem to be suited for the intake-specific controller * refactor conditional * updating the routes * Updating the remainder of intake routes * removing a repeated method found * moving intake specs to new intake controller spec * fixing file for failing tests * Fixing failing specs --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: Jim Foley <james.foley4@va.gov> * Piedram/appeals 41494 (#21196) * modified to show error in date filter * modified datecomplete * change name in header * fix style issue * Fix spec file * Add new test in spec file * Error banner now working as intended (#21206) Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * added comment * Justin/APPEALS-42009 (#21118) * adding correspondence intake controller * moving methods that seem to be suited for the intake-specific controller * refactor conditional * updating the routes * Updating the remainder of intake routes * removing a repeated method found * moving intake specs to new intake controller spec * fixing file for failing tests * Fixing failing specs --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: Jim Foley <james.foley4@va.gov> * Piedram/appeals 41494 (#21196) * modified to show error in date filter * modified datecomplete * change name in header * fix style issue * Fix spec file * Add new test in spec file * Wmedders21/appeals 42552 (#21209) * sorting query for date completed column on correspondence tables * optimize task query for your correspondence completed tab * optimize task query for corresepondence cases completed tab * update correspondence task filter for new column name * add name props to avoid console errors * correct prop types * update with new column name * update seeds to reflect expected workflow * update broken tests * remove unnecessarily bloated test case setup * update broken test expectation * updated linting * fixed linting issues --------- Co-authored-by: IsaiahBar <isaiah.barnett@va.gov> Co-authored-by: IsaiahBar <107133331+IsaiahBar@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com> Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: Kamala Madamanchi <110078646+kamala-07@users.noreply.github.com> Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com> Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com> Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: piedram <110848569+piedram@users.noreply.github.com>

* Initial commit for search bar * Search bar chnages and removed post request * Modified the search results display * Removed unused code * Removed searchValue from unnecessary places * Search results on page load * APPEALS-38964 - Search criteria for all columns * moved search logic from table builder into queue table * Removed unused method * Made the changes back for tabPaginationOptions * Remove Console Log * Feature test cases for Search bar * Added few more feature test cases for Search bar * Added pagination spec * Failing spec * Added few more test cases * APPEALS-38964 - Additioanl RSpec tests, Fixed page visits * Edit VA DOR access for InboundOpsTeamAdmin user (#21150) * 🔀 jcroteau/APPEALS-38492 - Fix duplicate results from joins on certain AR associations (#21097) * refactored seed scripts for correspondence to have more detailed notes (#21170) * Modified the test spec for sorted by veteran details * APPEALS-38964 - Updated Flaky Test * APPEALS-38964 - Notes Update * Added serializer for few more columns * Added serializer for label and closed_at columns * APPEALS-38964 - Linting, Assigned_By * Sort and pagination column fix * Removed logic for sort and pagination fix * Modified column_names with self class in all the tab class * DRY all the tabs * Extra Linting and Test Updates * Can able to search with number * Updates for tabs and linting * Linting * fix for completed date serializer * Reverting Conditional for VetDetails and VADOR --------- Co-authored-by: KiMauVA <Ki.Mau@va.gov> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: Kamala Madamanchi <110078646+kamala-07@users.noreply.github.com> Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…umn (#21228) * fixed select column appearing in superuser table * linting fixes * fixed linter issues * fixed merge conflicts --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* prevent overwriting correspondence uuid on page load * provide saved redux store to view if the intake form has been previously worked * Update test expectations * Merge with feature

* fixed missing text * updated instructions text * added instructions to action required tasks --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…1542-34964-32900

* Initial commit for Optimize Correspondence Table Queries * Removed instance variable --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* fix for filter value VADOR and Date Completed * fix selected filter --------- Co-authored-by: piedram <maite.piedrayera@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

… Logs the Correspondence Explain Page (Test Environments) (#21290) * APPEALS-42721 - Under Construction rerouting * APPEALS-42721 - Explain Page Route Fix * Add to App Controller * APPEALS-42721 - Working Right-Click Explain Linking * Linting and Cleanup * Update correspondence_task_column_serializer.rb * Update correspondence_task_column_serializer.rb * Route * APPEALS-42721 - Update Spec Pathing for Correspondence Explain --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

#21312) Co-authored-by: Jim Foley <james.foley4@va.gov>

…21302) Co-authored-by: Jim Foley <james.foley4@va.gov>

* updated correspondence table * run correspondence nod column migration * Add nod value to seed helper for correspondence queue * semi functional nod column * Add package doc type filter options to constants file * Add column title to constants file * remove binding.pry * add filtering logic for package doc type * Add search logic for package doc type * Update package doc type column for filtering and searching * rollback nod migration * added feature test for package document type column * fixed several receipt date failures * test fixes * update selectors for specs to account for new column * fixed several failing rspecs * reverted taskCompletedDateColumn to master version * fixed failing rspecs * removed stray binding.pry * fied linting issues * fixed linting issue * removed binding.pry * fixed ordering of assigned columns --------- Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: Jim Foley <james.foley4@va.gov>

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* Move Auto Assign Button to Correspondence Queue * Fix Lint Errors

…1542-34964-32900

…inally merged in on #21295

* Move Auto Assign Button to Correspondence Queue (#21324) * Move Auto Assign Button to Correspondence Queue * Fix Lint Errors * Include RunAsyncable --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* Move Auto Assign Button to Correspondence Queue (#21324) * Move Auto Assign Button to Correspondence Queue * Fix Lint Errors * Include RunAsyncable * Fix Broken Task Factories --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

#21329) * replaced correspondences_appeals with correspondence_appeal * added safe indecies to new correspondence_appeals table * updated correspondence_appeal namespace --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* Moving the queue method to a new controller * updating routing to the queue controller * Creating a spec file but leaving it empty for future changes * added a test for the correspondence_cases route --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* changed contents of correspondence seed notes (#21259)  Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) # Description Please explain the changes you made here. ## Acceptance Criteria - [ ] Code compiles correctly ## Testing Plan  1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? # Frontend ## User Facing Changes - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- ## Storybook Story *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component # Backend ## Database Changes *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) ## Integrations: Adding endpoints for external APIs * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT # Best practices ## Code Documentation Updates - [ ] Add or update code comments at the top of the class, module, and/or component. ## Tests ### Test Coverage Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other ### Code Climate Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added ## Monitoring, Logging, Auditing, Error, and Exception Handling Checklist ### Monitoring - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? ### Logging - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? ### Auditing - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? ### Error Handling - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? ### Exception Handling - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * WIP * Working as intended * Spec tests * Added instructions to modal * Linting Errors * Addressing comments --------- Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* refactored props being passed down to child components * refactored permissions checks for reassign and remove package tasks * removed unecessary router useage * addressed name change concerns for supervisor/superuser to be more in line with correspondence workflow

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…1542-34964-32900

…/github.com/department-of-veterans-affairs/caseflow into integration/APPEALS-27311-31542-34964-32900

Co-authored-by: Jim Foley <james.foley4@va.gov>

* Reset BGS Service * Add New Sensitivity Check Method - Create new method in BGSService for checking participant sensitivity using the BGS gem. - Update auto assign logic to use new method for checking sensitivity for user/veteran pairs. * Fix Lint Error * Update Sensitivity Check Logic - Use new method in BGS gem for checking user sensitivity levels. - Update specs and supporting files accordingly.

* Move Auto Assign Button to Correspondence Queue (#21324) * Move Auto Assign Button to Correspondence Queue * Fix Lint Errors * Reset BGS Service (#21352) * Use New BGS Gem Sensitivity Check Methods (#21356) * Reset BGS Service * Add New Sensitivity Check Method - Create new method in BGSService for checking participant sensitivity using the BGS gem. - Update auto assign logic to use new method for checking sensitivity for user/veteran pairs. * Fix Lint Error * Update Sensitivity Check Logic - Use new method in BGS gem for checking user sensitivity levels. - Update specs and supporting files accordingly. --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: Christopher Aceves <christopher.aceves@va.gov>

* Initial commit for UI/UX changes * Added the existing caseflow search properties * Updated the checkboxes style fix * Changes for spec file with the latest code changes * Modified the seed data to check pagination

* Initial commit for UI/UX changes * Added the existing caseflow search properties * Updated the checkboxes style fix * Changes for spec file with the latest code changes * Modified the seed data to check pagination * Modified the lint issue change for if condition * Modified the lint issue change for if condition

…21371) * create CMP rake task to generate correspondence data in UAT * added vbms doc types to rake task * removed useless method

…-of-veterans-affairs/caseflow into feature/APPEALS-32900

* change eFolderUploadFailedTask Routing * change condicion for efolder --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* creating review package controller, moving methods, editing routing * Moving review package spec tests to new RP Spec file * cleaning up code from intake controller spec

…1380) Co-authored-by: Jim Foley <james.foley4@va.gov>

- Fix bug causing correspondences not be sorted by VA DOR in ascending (oldest -> newest) order. - Update specs to test this scenario.

* Added a join clause of appeal_type = 'Appeal' to the with_original_appeal_and_judge_task method in the distribution_scopes.rb to prevent a sequential table scan which was causing a database timeout with large datasets in the tasks table in production and prod test. (#21386) Co-authored-by: = <tyler.broyles@va.gov> * Hotfix/appeals 21696 (#21343) * fix(create conference): update test for nil appellant email * fix(create conference): nil appellant email check * fix(conference job): lint * fix(create conference): minor * null * null * null --------- Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * Hotfix/appeals 23420 v3 (#21347) * Add LegacyAppealSearchSerializer to rendering * Make additional improvements to the Legacy Serializer * Add MST and PACT to both search serializers respectively * schema check-in --------- Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * hotfix/APPEALS-27522 (#21326) * update erroneous db cleaner syntax and add temp fix to changeset_at_index_for_task method * update changeset_at_index_for_task method to account for lint error * fix lint error and code climate error --------- Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * Hotfix/appeals 10993 v2 (#21349) * added logic for deciding aod on attorney claimant * added tests * refactored test to return true when motion is granted --------- Co-authored-by: Andrew Hadley <hadley_andrew@bah.com> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * Fixed a bug where some of the Specialty Case Team assign queue settings would take priority over judge assign queue settings for judges who were also members of the specialty case team organization. (#21387) Co-authored-by: = <tyler.broyles@va.gov> * Merge hotfix/APPEALS-43956 into release/FY24Q2.7.0 (#21389) * Added additional logic checks to the attorney task cancel to fix a bug where the cancel attorney task would attempt to update a non existing SpecialtyCaseTeamAssignTask when the appeal matches the sct_appeal? criteria of a 'vha' benefit type. * Removed feature toggle from the checks since the cancel task should work properly for appeals that were disributed while the feature toggle used in distribution was turned on. * Added a regression test. --------- Co-authored-by: = <tyler.broyles@va.gov> * Merge hotfix/APPEALS-43990 into release/FY24Q2.7.0 (#21388) * Added a nil value to the inclusion field of the distributed case validation for the sct_appeal boolean that was causing an error when calling the rename_for_redistribution! on a distributed case where the value was not already set to true and false * Added a regression test for the sct_appeal validation. --------- Co-authored-by: = <tyler.broyles@va.gov> * Added a null coalesce to prevent a javascript error caused by a race condition where remaining users could be nil instead of an array if the user is searching for a user at the same time they are adding a user. (#19487) * APPEALS-43712, APPEALS-43835: Open VeteranRecordRequest and QualityReviewTask are causing distributions to fail (#21354) * remove Appeal.can_redistribute_appeal? from JudgeAssignTask creation during normal distribution * update test * re-add tests for validating each bug scenario * disable mail task test that is failing due to how it is written * updating hearing_shift_date to prevent future hearing dates from occuring in local/demo (#21306) Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> * Lint fixes (#21383) * APPEALS-43423 - AssignedReassignPackageTask remove user limitation (#21400) * Ryandwill/appeals 43393 (#21339) * refactored correspondence_controller_util into correspondence_controller_concern * refactor correspondence_controller * updated method to be class level and in CorrespondenceTask model * Updating the class methods from controller to model * Updated the correspondence_task.rb * Update intake endpoint with custom serialization and move logic to models * update QueueApp with new props * remove controller passed props from redux * update frontend components for correspondence objects new data shape * Update test for controller changes * update test for new controller changes * update test for controller changes * fix typo in error msg and related tests * remove unused argument * remove unneeded prop validation * move task update logic and banner presentation to correspondence tasks controller * move team action to queue controller * rubocop fix * remove review package methods to prepare for feature merge * clean up review package veteran update * fix test to follow assertion * update spec for new pagination requirements * fix typo * refactor reassign/remove package modals for RP page * fix test setup to create RemovePackageTask properly * fix test selector * fix test - quotation marks and hyphen character in string * fix style issues * rspec fixes * update rp controller inbound ops team check * remove pry * removed leftover binding pry * remove pry * remove previously deleted code * fix flaky test * fix tests --------- Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * Move Correspondence ART CSS Styling Into a Single Stylesheet- Queue - APPEALS-43392 (#21384) * WIP * All styling has meen moved to scss * Small fixes * fixed inbound ops team being listed in queuetable dropdown (#21405) * fixed inbound ops team being listed in queuetable dropdown * refactored isMailTeamAffiliated * removed commented out code --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Reassign Correspondence Allows Reassignment over 60 Limit (#21403) * Reassign Correspondence Allows Reassignment over 60 Limit * Reassign Correspondence Allows Reassignment over 60 Limit * added limit check to banner message and resolve linting error with safety operator * remove file app/models/concerns/correspondence_controller_util.rb --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * Kamalam7/appeals 35469 (#21407) * Return to queue from the Intake form * specs for Return to queue from Intake form * Resolved merge conflicts for Return to queue Intake form * Lint fix in Correspondence intake file --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Wmedders21/appeals 44301 (#21413) * correspondence controller specs live in spec/requests * Remove unused veteran endpoint * Add request tests for user access and feature flag * add tests for review package controller * remove unnecessary line * refactor test for simplecov coverage * remove unneeded test * add intake spec * add controller tests * add erroneously removed method * Fix rubocop style * fix selector in flaky test * add error class to rescue --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Justin/appeals 43606 (#21399) * lining up misaligned brackets * CorrespondencePdfFooter inline styles removed * removing unused class and styling * CmpDocuments.jsx styles into a stylesheet * CorrespondenceReviewPackage.jsx styles into a stylesheet * ReviewForm.jsx WIP * moving css out of ReviewPackageCaseTitle * ReviewForm.jsx styles into a stylesheet * scss fix * CorrespondencePdfToolBar.jsx styles into a stylesheet * ReviewPackageData file scss * removing excess styling to keep textarea at application default sizing * updated test on intake spec * cleaned up old binding pry --------- Co-authored-by: Dev-KRedd <khalin.redding@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * Add unit tests (#21421) * added completed_by_date * APPEALS-44300 - Prior Mail test * created approve unit test on ReassignPackageTask model. * added tests * added remove package tasks approve and reject methods * Reassign Correspondence Allows Reassignment over 60 Limit (#21403) * Reassign Correspondence Allows Reassignment over 60 Limit * Reassign Correspondence Allows Reassignment over 60 Limit * added limit check to banner message and resolve linting error with safety operator * remove file app/models/concerns/correspondence_controller_util.rb --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * Kamalam7/appeals 35469 (#21407) * Return to queue from the Intake form * specs for Return to queue from Intake form * Resolved merge conflicts for Return to queue Intake form * Lint fix in Correspondence intake file --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Wmedders21/appeals 44301 (#21413) * correspondence controller specs live in spec/requests * Remove unused veteran endpoint * Add request tests for user access and feature flag * add tests for review package controller * remove unnecessary line * refactor test for simplecov coverage * remove unneeded test * add intake spec * add controller tests * add erroneously removed method * Fix rubocop style * fix selector in flaky test * add error class to rescue --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> --------- Co-authored-by: KiMauVA <Ki.Mau@va.gov> Co-authored-by: piedram <110848569+piedram@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: Kamala Madamanchi <110078646+kamala-07@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com> --------- Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com> Co-authored-by: = <tyler.broyles@va.gov> Co-authored-by: Christian Cain <149622375+christian-cain-bah@users.noreply.github.com> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> Co-authored-by: Aiman Kayad <Akaya005@fiu.edu> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: Dani Coleman <60626984+dcoleman21@users.noreply.github.com> Co-authored-by: Drew Hadley <50673809+VandelayUtd@users.noreply.github.com> Co-authored-by: Andrew Hadley <hadley_andrew@bah.com> Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: Isaiah Saucedo <irsaucedo5@gmail.com> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: Ki Mau <ki.mau@va.gov> Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com> Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com> Co-authored-by: Rnmarshall93 <110805785+Rnmarshall93@users.noreply.github.com> Co-authored-by: piedram <110848569+piedram@users.noreply.github.com> Co-authored-by: Kamala Madamanchi <110078646+kamala-07@users.noreply.github.com> Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com> Co-authored-by: Dev-KRedd <khalin.redding@va.gov>

* consolidated backend checks to use inbound_ops_team_superuser over mail_superuser * updated superuser namespace in the frontend

* cleaned up magic string usage * updated cancel routing for superusers * fixed linting issues * added rerouting for users that cannot access a specific intake * updated Review Package task to be the same user that was assigned the Intake * resolved linting issues * updated inbound ops team superuser check * refactored intake controller test * refactored reassign package task specs and reassignment on cancel * refactored task specs to be more DRY * added intake task fix to intake_form_spec * cleaned up test failures related to intake task within intake. * refactored related correspondence spec tests * updated test to click correct section * updated failing snapshots * fixed typo on prop validations

…ask (#21497)

* APPEALS-41707 - Functionality and some CSS * APPEALS-41707 - Updates * APPEALS-41707 - Unrelated Specs and Correspondence CSS Lint fixes * APPEALS-41707 - Additional Linting * APPEALS-41707 - More Clean up

* added migrations to refactor correspondence intake relationship to task instead of user/correspondence * updated model relations and controller check for an open intake * updated specs to reflect code changes. * removed leftover pry

…ge (#21528) * APPEALS-42281 - displaying NOD of correspondence in review package page * fixing package document type alignment

Caceves/khalin 41705 #21538

Caceves/khalin 41705 #21538

Commits on Feb 13, 2024

Commits on Feb 14, 2024

Commits on Feb 15, 2024

Commits on Feb 16, 2024

Commits on Feb 20, 2024

Commits on Feb 21, 2024

Commits on Feb 22, 2024

Commits on Feb 23, 2024

Commits on Feb 27, 2024

Commits on Feb 28, 2024

Commits on Feb 29, 2024

Commits on Mar 4, 2024

Commits on Mar 5, 2024

Commits on Mar 6, 2024

Commits on Mar 7, 2024

Commits on Mar 8, 2024

Commits on Mar 9, 2024

Commits on Mar 11, 2024

Commits on Mar 12, 2024

Commits on Mar 14, 2024

Commits on Mar 15, 2024

Commits on Mar 18, 2024

Commits on Mar 19, 2024

Commits on Mar 20, 2024

Commits on Mar 21, 2024

Commits on Mar 22, 2024

Commits on Mar 25, 2024

Commits on Mar 26, 2024

Commits on Mar 27, 2024

Commits on Mar 28, 2024

Commits on Mar 29, 2024

Commits on Apr 1, 2024

Commits on Apr 2, 2024

Commits on Apr 3, 2024

Commits on Apr 4, 2024

Commits on Apr 5, 2024

Commits on Apr 8, 2024

Commits on Apr 9, 2024

Commits on Apr 10, 2024

Commits on Apr 11, 2024

Commits on Apr 12, 2024

Commits on Apr 22, 2024

Commits on Apr 24, 2024

Commits on Apr 25, 2024

Commits on Apr 29, 2024

Commits on Apr 30, 2024

Commits on May 1, 2024

Commits on May 2, 2024