Caceves/khalin 41705

.fasterer.yml

@@ -14,3 +14,7 @@ exclude_paths:
   - "db/seeds.rb"
   - "vendor/**/*.rb"
   - "app/mappers/zip_code_to_lat_lng_mapper.rb"
+
+  # Flagged for using sort instead of using sort_by - however due to complexity of sorting
+  # conditionally makes more sense to use sort
+  - "app/services/auto_assignable_user_finder.rb"

Gemfile

@@ -12,7 +12,7 @@ gem "acts_as_tree"
 gem "amoeba"
 # BGS
 
-gem "bgs", git: "https://github.com/department-of-veterans-affairs/ruby-bgs.git", ref: "5f47e7b2656ef347d314ef43c93d38a9f20816ec"
+gem "bgs", git: "https://github.com/department-of-veterans-affairs/ruby-bgs.git", branch: "caseflow/add-new-security-endpoint"
 # Bootsnap speeds up app boot (and started to be a default gem in 5.2).
 gem "bootsnap", require: false
 gem "browser"
@@ -66,6 +66,7 @@ gem "redis-namespace"
 gem "redis-rails", "~> 5.0.2"
 gem "request_store"
 gem "roo", "~> 2.7"
+gem "ruby_claim_evidence_api", git: "https://github.com/department-of-veterans-affairs/ruby_claim_evidence_api.git", ref: "a2ecb0bf7f3d3aa8fd1429bfd78aa00e7270b0c8"
 # Use SCSS for stylesheets
 gem "sass-rails", "~> 5.0"
 # Error reporting to Sentry

Gemfile.lock

@@ -57,14 +57,28 @@ GIT
 
 GIT
   remote: https://github.com/department-of-veterans-affairs/ruby-bgs.git
-  revision: 5f47e7b2656ef347d314ef43c93d38a9f20816ec
-  ref: 5f47e7b2656ef347d314ef43c93d38a9f20816ec
+  revision: ebb9d8add944ce2125d1fb226494edabbc8adf1c
+  branch: caseflow/add-new-security-endpoint
   specs:
-    bgs (0.3)
+    bgs (0.3.1)
       httpclient
       nokogiri (>= 1.11.0.rc4)
       savon (~> 2.12)
 
+GIT
+  remote: https://github.com/department-of-veterans-affairs/ruby_claim_evidence_api.git
+  revision: a2ecb0bf7f3d3aa8fd1429bfd78aa00e7270b0c8
+  ref: a2ecb0bf7f3d3aa8fd1429bfd78aa00e7270b0c8
+  specs:
+    ruby_claim_evidence_api (0.0.1)
+      activesupport
+      base64
+      faraday
+      faraday-multipart
+      httpi
+      railties
+      webmock (~> 3.6.2)
+
 GIT
   remote: https://github.com/department-of-veterans-affairs/sniffybara.git
   revision: 351560b5789ca638ba7c9b093c2bb1a9a6fda4b3
@@ -166,6 +180,7 @@ GEM
       aws-sdk-core (= 2.10.112)
     aws-sigv4 (1.0.2)
     backport (1.2.0)
+    base64 (0.2.0)
     benchmark-ips (2.7.2)
     bootsnap (1.7.5)
       msgpack (~> 1.0)
@@ -306,6 +321,8 @@ GEM
       multipart-post (>= 1.2, < 3)
     faraday-http-cache (2.4.1)
       faraday (>= 0.8)
+    faraday-multipart (1.0.4)
+      multipart-post (~> 2)
     faraday_middleware (0.13.1)
       faraday (>= 0.7.4, < 1.0)
     fast_jsonapi (1.5)
@@ -835,6 +852,7 @@ DEPENDENCIES
   ruby-debug-ide
   ruby-oci8 (~> 2.2)
   ruby-prof (~> 1.4)
+  ruby_claim_evidence_api!
   sass-rails (~> 5.0)
   scss_lint
   sentry-raven

Makefile.example

@@ -113,6 +113,10 @@ realclean: clean ## TODO
 	rm -rf client/node_modules
 	rm -f client/package-lock.json
 
+precompile: ## Precompiles assets for testing
+	bundle exec rake assets:precompile
+
+
 facols-bash:  ## Connect to the docker FACOLS instance
 	docker exec --tty -i VACOLS_DB bash
 
@@ -283,6 +287,8 @@ client-build-all client-all: client-test client-demo ## Builds webpack for both
 one-test:  ## run the rspec test passed in
 	bundle exec rspec $(RUN_ARGS)
 
+clean-test: clean precompile one-test ## Cleans and precompiles assets for testing, then runs spec test passed in
+
 run-all-queues: ## start shoryuken with all queues
 	bundle exec shoryuken -q caseflow_development_send_notifications caseflow_development_high_priority caseflow_development_low_priority  -R
 

app/controllers/appeals_controller.rb

@@ -187,6 +187,11 @@ def update
     end
   end
 
+  def active_evidence_submissions
+    appeal = Appeal.find(params[:appeal_id])
+    render json: appeal.evidence_submission_task
+  end
+
   private
 
   def create_subtasks!
@@ -448,7 +453,7 @@ def create_legacy_issue_update_task(before_issue, current_issue)
     # close out any tasks that might be open
     open_issue_task = Task.where(
       assigned_to: SpecialIssueEditTeam.singleton
-    ).where(status: "assigned").where(appeal: appeal)
+    ).where(status: Constants.TASK_STATUSES.assigned).where(appeal: appeal)
     open_issue_task[0].delete unless open_issue_task.empty?
 
     task = IssuesUpdateTask.create!(

app/controllers/application_controller.rb

@@ -9,7 +9,7 @@ class ApplicationController < ApplicationBaseController
   before_action :set_raven_user
   before_action :verify_authentication
   before_action :set_paper_trail_whodunnit
-  before_action :deny_vso_access, except: [:unauthorized, :feedback]
+  before_action :deny_vso_access, except: [:unauthorized, :feedback, :under_construction]
   before_action :set_no_cache_headers
 
   rescue_from StandardError do |e|

app/controllers/concerns/correspondence_controller_concern.rb

@@ -0,0 +1,152 @@
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/ModuleLength
+
+# Contains most of the logic inside of CorrespondenceController
+module CorrespondenceControllerConcern
+  private
+
+  MAX_QUEUED_ITEMS = 60
+
+  def process_tasks_if_applicable(mail_team_user, task_ids, tab)
+    # candidate for refactor using PATCH request
+    return unless mail_team_user && task_ids.present?
+
+    set_banner_params(mail_team_user, task_ids.count, tab)
+    update_tasks(mail_team_user, task_ids)
+  end
+
+  def update_tasks(mail_team_user, task_ids)
+    return unless @response_type == "success"
+
+    tasks = Task.where(id: task_ids)
+    tasks.update_all(
+      assigned_to_id: mail_team_user.id,
+      assigned_to_type: "User",
+      status: Constants.TASK_STATUSES.assigned
+    )
+  end
+
+  def set_banner_params(user, task_count, tab)
+    template = message_template(user, task_count, tab)
+    response_type(user, task_count)
+    @response_header = template[:header]
+    @response_message = template[:message]
+  end
+
+  def message_template(user, task_count, tab)
+    case tab
+    when "correspondence_unassigned"
+      bulk_assignment_banner_text(user, task_count)
+    when "correspondence_team_assigned"
+      bulk_assignment_banner_text(user, task_count, action_prefix: "re")
+    end
+  end
+
+  def bulk_assignment_banner_text(user, task_count, action_prefix: "")
+    success_header_unassigned = "You have successfully #{action_prefix}"\
+      "assigned #{task_count} Correspondence to #{user.css_id}."
+    failure_header_unassigned = "Correspondence #{action_prefix}assignment to #{user.css_id} could not be completed"
+    success_message = "Please go to your individual queue to see any self-assigned correspondence."
+    failure_message = "Queue volume has reached maximum capacity for this user."
+    user_tasks = user&.tasks&.length
+    {
+      header: (user_tasks + task_count <= MAX_QUEUED_ITEMS) ? success_header_unassigned : failure_header_unassigned,
+      message: (user_tasks + task_count <= MAX_QUEUED_ITEMS) ? success_message : failure_message
+    }
+  end
+
+  def response_type(user, task_count)
+    current_user_tasks = user&.tasks&.length
+    @response_type = (current_user_tasks + task_count <= MAX_QUEUED_ITEMS) ? "success" : "warning"
+  end
+
+  def set_flash_intake_success_message
+    # intake error message is handled in client/app/queue/correspondence/intake/components/CorrespondenceIntake.jsx
+    vet = veteran_by_correspondence
+    flash[:correspondence_intake_success] = [
+      "You have successfully submitted a correspondence record for #{vet.name}(#{vet.file_number})",
+      "The mail package has been uploaded to the Veteran's eFolder as well."
+    ]
+  end
+
+  def intake_cancel_message(action_type)
+    vet = veteran_by_correspondence
+    if action_type == "cancel_intake"
+      @response_header = "You have successfully cancelled the intake form"
+      @response_message = "#{vet.name}'s correspondence (ID: #{correspondence.id}) "\
+       "has been returned to the supervisor's queue for assignment."
+    else
+      @response_header = "You have successfully saved the intake form"
+      @response_message = "You can continue from step three of the intake form for #{vet.name}'s "\
+      "correspondence (ID: #{correspondence.id}) at a later date."
+    end
+    @response_type = "success"
+  end
+
+  def general_information
+    vet = veteran_by_correspondence
+    {
+      notes: correspondence.notes,
+      file_number: vet.file_number,
+      veteran_name: vet.name,
+      correspondence_type_id: correspondence.correspondence_type_id,
+      correspondence_types: CorrespondenceType.all,
+      correspondence_tasks: correspondence.tasks.map do |task|
+        WorkQueue::CorrespondenceTaskSerializer.new(task).serializable_hash[:data][:attributes]
+      end
+    }
+  end
+
+  def correspondence_params
+    params.require(:correspondence).permit(:notes, :correspondence_type_id, :va_date_of_receipt)
+  end
+
+  def veteran_params
+    params.require(:veteran).permit(:file_number)
+  end
+
+  def correspondence
+    @correspondence = Correspondence.find_by(uuid: params[:correspondence_uuid])
+  end
+
+  def veteran_by_correspondence
+    return nil if correspondence&.veteran_id.blank?
+
+    @veteran_by_correspondence ||= Veteran.find_by(id: correspondence.veteran_id)
+  end
+
+  def veterans_with_correspondences
+    veterans = Veteran.includes(:correspondences).where(correspondences: { id: Correspondence.select(:id) })
+    veterans.map { |veteran| vet_info_serializer(veteran, veteran.correspondences.last) }
+  end
+
+  def auto_texts
+    @auto_texts ||= AutoText.all.pluck(:name)
+  end
+
+  def vet_info_serializer(veteran, correspondence)
+    {
+      firstName: veteran.first_name,
+      lastName: veteran.last_name,
+      fileNumber: veteran.file_number,
+      cmPacketNumber: correspondence.cmp_packet_number,
+      correspondenceUuid: correspondence.uuid,
+      packageDocumentType: correspondence.correspondence_type_id
+    }
+  end
+
+  def correspondence_intake_processor
+    @correspondence_intake_processor ||= CorrespondenceIntakeProcessor.new
+  end
+
+  def correspondence_documents_efolder_uploader
+    @correspondence_documents_efolder_uploader ||= CorrespondenceDocumentsEfolderUploader.new
+  end
+
+  def upload_documents_to_claim_evidence
+    rpt = ReviewPackageTask.find_by(appeal_id: correspondence.id, type: ReviewPackageTask.name)
+    correspondence_documents_efolder_uploader.upload_documents_to_claim_evidence(correspondence, current_user, rpt)
+  end
+end
+# rubocop:enable Metrics/ModuleLength

app/controllers/concerns/explain_timeline_concern.rb

@@ -9,6 +9,7 @@ module ExplainTimelineConcern
   # :reek:FeatureEnvy
   def timeline_data
     return "(LegacyAppeals are not yet supported)".to_json if legacy_appeal?
+    return "(Correspondences are not yet supported)".to_json if correspondence?
 
     (tasks_timeline_data + intake_timeline_data + hearings_timeline_data).map(&:as_json)
   end

app/controllers/concerns/task_pagination_concern.rb

@@ -17,8 +17,28 @@ def pagination_json
     }
   end
 
+  def correspondence_pagination_json
+    {
+      tasks: correspondence_json_tasks(correspondence_task_pager.paged_tasks),
+      task_page_count: correspondence_task_pager.task_page_count,
+      total_task_count: correspondence_task_pager.total_task_count,
+      tasks_per_page: CorrespondenceTaskPager::TASKS_PER_PAGE
+    }
+  end
+
   private
 
+  def correspondence_task_pager
+    @correspondence_task_pager ||= CorrespondenceTaskPager.new(
+      assignee: assignee,
+      tab_name: params[Constants.QUEUE_CONFIG.TAB_NAME_REQUEST_PARAM.to_sym],
+      page: params[Constants.QUEUE_CONFIG.PAGE_NUMBER_REQUEST_PARAM.to_sym],
+      sort_order: params[Constants.QUEUE_CONFIG.SORT_DIRECTION_REQUEST_PARAM.to_sym],
+      sort_by: params[Constants.QUEUE_CONFIG.SORT_COLUMN_REQUEST_PARAM.to_sym],
+      filters: params[Constants.QUEUE_CONFIG.FILTER_COLUMN_REQUEST_PARAM.to_sym]
+    )
+  end
+
   def task_pager
     @task_pager ||= TaskPager.new(
       assignee: assignee,
@@ -30,6 +50,16 @@ def task_pager
     )
   end
 
+  def correspondence_json_tasks(tasks)
+    tab = CorrespondenceQueueTab.from_name(params[Constants.QUEUE_CONFIG.TAB_NAME_REQUEST_PARAM.to_sym])
+
+    { data: WorkQueue::CorrespondenceTaskColumnSerializer.new(
+      tasks,
+      is_collection: true,
+      params: { columns: tab.column_names }
+    ).serializable_hash[:data] }
+  end
+
   def json_tasks(tasks)
     tasks = AppealRepository.eager_load_legacy_appeals_for_tasks(tasks)
     params = { user: current_user }