Skip to content

Releases: department-of-veterans-affairs/caseflow

deployed/20241025_211433

25 Oct 21:14
8391ace
Compare
Choose a tag to compare

Commit: 8391ace

Remove created_by constraint (#23354)

  • Remove created_by constraint

  • Add automated test coverage

  • Fix broken test


Co-authored-by: Matthew Thornton ThorntonMatthew@users.noreply.github.com


Commit: 9a2c9d3

APPEALS-59528: Fix test spec/feature/switch_user_spec.rb (#23003)

deployed/20241024_211558

24 Oct 21:15
9a2c9d3
Compare
Choose a tag to compare

Commit: 9a2c9d3

APPEALS-59528: Fix test spec/feature/switch_user_spec.rb (#23003)

Appeals Caseflow_R3.1.2_ FY25Q1.2 Non-Production Impacting Deployment

23 Oct 21:14
9a2c9d3
Compare
Choose a tag to compare

Commit: 9a2c9d3

APPEALS-59528: Fix test spec/feature/switch_user_spec.rb (#23003)


Commit: 9869398

Merge pull request #22942 from department-of-veterans-affairs/HunJerBAH/APPEALS-59113

APPEALS-59113: Git PR Command does not allow frontend tests to run without -- option


Commit: fd3bfea

Merge branch 'main' into HunJerBAH/APPEALS-59113


Commit: 1158b8e

Release/fy25 q1.1.4 (#23287)

  • Feature/appeals 49670 49667 phase ii release tested (#23257)

  • APPEALS-36688- Build out Decision Review Created API route & Controller (#20569)

  • added skeleton for api route

  • removed duplicate code

  • removed development envs for api and moved to creating an ApiKey

  • removing any changes to development.rb

  • removed extra auth code

  • removed before action


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • APPEALS-38232 -Build out Decision Review Created Event Failure API route & Controller (#20601)

  • APPEALS-38232 - renamed controller to AC req, added decision_review_created_error endpoint, added decision_review_created_error method, and added RSpec for new method

  • APPEALS-38232 - add comments to RSpec

  • Jonathan/appeals 36684 (#20516)

  • initial Events migration and model creation

  • created model for DecisionReviewCreatedEvent

  • updated comment with example

  • added spec for DRCE model

  • APPEALS-36684 created event_records migration and added polymorphic associations to specific models, and added rspec for the event_record model

  • APPEALS-36684 - Updated RSpec tests and updated variables and got unhappy path to pass

  • cleaned lint

  • saving DRCE spec changes

  • fixed spec test

  • changed has_many to has_one

  • updated event model spec

  • added validation for ER poly associations

  • changed association to has_one

  • added new method and updated tests

  • added foreign key after running checks

  • some PR comment changes

  • refactored methods in EventConcern


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com
Co-authored-by: Enrilo Ugalde ugalde_enrilo@bah.com

  • added migration, scopes and specs for events (#20707)

  • fixed migration to update existing events table

  • rollbacked to fix schema

  • schema fixes


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • Jr/APPEALS-38926 (#20714)

  • APPEALS-38926 - Created DecisionReviewCreatedError Service Class, added logic for handling service error, updated DecisonReviewCreatedController, and DecisionReviewCreatedController spec, with the updated service logic

  • APPEALS-38926- created RSpec Test for DecisionReviewCreatedError Service Class and edited the Rails.logger for the service class

  • APPEALS-38926 Added new info column to update transaction and added it to the RSpec test

  • APPEALS-38926 - added comments to the Service Class

  • APPEALS-38926 - Code Changes from TL Code Review, added rescues and fails

  • APPEALS-38926 - fixed lint

  • Jonathan/appeals 36689 (#20671)

  • created new service class

  • add rspec test cases

  • service class methods

  • controller action and spec

  • controller update

  • CC fixes

  • removed accidental line

  • changed to find_or_create_by

  • reworked error for redis lock

  • additional rspec for controller

  • fixed test

  • rspec fix

  • delete lock key afterwards

  • moved Event creation back into lock block


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • APPEALS-39663 Create CreateUserOnEvent service class and add logic to create user if needed (#20838)

  • added user creation class & test

  • removed extra lines

  • add comment to class

  • added context for args from avro


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • Jr/APPEALS-39664 (#20898)

  • APPEALS-39664 - Created updated_vacols_on_optin module class, and removed extra private

  • APPEALS-39664 - created UpdatedVacolsOnOptin module, RSpec file, as well as sudo code for SOC and SSOC optin check in main service class DecisionReviewCreated

  • APPEALS-39664 - Created RSpec Test - PASS, Updated method name.

  • APPEALS-39664 - Added Error Handling to Sub Service Class

  • APPEALS-39664 - Removed un-needed comments

  • APPEALS-39664 - added include for the module UpdateVacolsOnOptin inside decision_review_created service

  • APPEALS-39664 - Added Custom Error , and updated all .perform! to .process!

  • APPEALS-39664 - Updated RSpec Test to reflect changes - all pass

  • Updated comment for decision_review_created Service Class

  • Will/appeals 36691 (#20909)

  • Created attribute for failed claims on event and displaying failed claim

  • passing all failed events back to serializer

  • added controller tests for failed_claims and added class method for finding claims on events

  • renamed failed_claims to claim_errors


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • JR/APPEALS-40954 Create CreateIntake service class and add logic to create Intake (#20967)

  • APPEALS-40954 - Added Sudo Code for CreateIntake Logic

  • APPEALS-40954 - added logic to CreateIntake module

  • APPEALS-40954 - added Create Intake spec with error handling - All pass

  • APPEALS-40954 - Added CreateIntake Module to DecisionReviewCreated Main Service

  • APPEALS-40954 - updated folder name and namespace

  • APPEALS-40954 - Updated RSpec to match folder

  • APPEALS-40954- Upated decision review created servie include to match folder

  • Fixed failing test due to folder structure change

  • Jonathan/appeals 40950 (#20965)

  • Added new veteran creation module

  • saving test changes

  • rspec

  • fixed datetime assign

  • renamed var


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • APPEALS-40950 - update var veteran to vbms_veteran (#21050)

  • APPEALS-40950 - update var veteran to vbms_veteran

  • updated private method in controller to match happy path params dcr to drc

  • Create CreateClaimantOnEvent service class and add logic to create claimant if needed (#21044)

  • created service class and basic unit tests

  • added conditionals for veteran claimants and will create veteran claimant now

  • modified create claimant to use eventing data

  • change to a class

  • creating claimant correctly

  • test fixes

  • removed old comments

  • fixed type for veteran_is_not_claimant

  • changed specs to match pulling out hash params and removed event.reference id

  • moved back to dot notation

  • updated comments

  • fixed create claimant issue

  • updated process to use bang method and returning claimant


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • APPEALS-41968 Modify Issues Endpoints & Update Metric Service Logic (#21108)

  • moved metricsService call to top of method

  • modified rspec case

  • moved metric logging spec case higher up


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • Resolved merge conflicts while merging master into feature/APPEALS-28… (#21167)

  • Jonathan/APPEALS-41957 (#21171)

  • added interface + parser class

  • edited veteran parse methods

  • renamed var to "payload"

  • started refactor

  • more refactor + rspec

  • added EPE attr

  • dateTime conversions

  • added class comments

  • rubocop lint changes

  • fixed test case


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • Jr/appeals 41931 (#21192)

  • APPEALS-41931 - Created create_ep_establishment file and class

  • APPEALS-41931 - added process! method that creates epe from payload

  • APPEALS-41931 - added logic for EventRecord being created and error handling

  • APPEALS-41931 - added comments to process method

  • APPEALS-41931 - set up rspec test

  • APPEALS-41931 - removed lint

  • APPEALS-41931-created Rspec and Test Pass

  • APPEALS-41931 - cleaned lint and added error test 100% code coverage

  • APPEALS-41931- fixed lint

  • APPEALS-41931- fixed lint and fixed %100 code cov

  • APPEALS-41931 - cleaned up lint and warn for Service Class

  • APPEALS-41931 - Added CreateEpEstablishment.process! to the decision_review_created Parent Service Class

  • APPEALS-41931 - refactor code to implement new parser

  • fixed linting issues

  • APPEALS-41931 - Updated Comments for CreateEpEstablishment

  • APPEALS-41931 - moved logical date int to parser and refactored code in Class and RSepc

  • edits

  • Will/appeals 41929 (#21205)

  • added an error and commented out call for createclaim

  • added new parser logic

  • merge request changes

  • fixed rubocop issues and added checks for claim review attributes


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • APPEALS-42631- Create Rspec for Parser with sample payload method, and add additional parser methods (#21294)

  • APPEALS-42631 - create example.json

  • APPEALS-42631 - implemented example_response and load_example method and works as expected

  • APPEALS-42631 - created RSpec for DecisionReviewCreatedParser

  • APPEALS-42631 - Refactored parser and Added RSpec for current praser

  • APPEALS-42631 - added methods to parser for intake, claimant, and claim_review and added matching rspec for new methods

  • APPEALS-42631 - updated code per TL Comments

  • APPEALS-421631- added additional comments and fixing lint

  • APPEALS-41934 (#21251)

  • initial commit

  • implementation & error

  • renamed method

  • rspec

  • saving refactor progress

  • finished refactoring class

  • added comment

  • minor parser/rspec updates


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • added RI parser methods to rspec (#21322)

  • added RI parser methods to rspec

  • updated config for Cons...

Read more

deployed/20241022_211535

22 Oct 21:15
1158b8e
Compare
Choose a tag to compare

Commit: 1158b8e

Release/fy25 q1.1.4 (#23287)

  • Feature/appeals 49670 49667 phase ii release tested (#23257)

  • APPEALS-36688- Build out Decision Review Created API route & Controller (#20569)

  • added skeleton for api route

  • removed duplicate code

  • removed development envs for api and moved to creating an ApiKey

  • removing any changes to development.rb

  • removed extra auth code

  • removed before action


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • APPEALS-38232 -Build out Decision Review Created Event Failure API route & Controller (#20601)

  • APPEALS-38232 - renamed controller to AC req, added decision_review_created_error endpoint, added decision_review_created_error method, and added RSpec for new method

  • APPEALS-38232 - add comments to RSpec

  • Jonathan/appeals 36684 (#20516)

  • initial Events migration and model creation

  • created model for DecisionReviewCreatedEvent

  • updated comment with example

  • added spec for DRCE model

  • APPEALS-36684 created event_records migration and added polymorphic associations to specific models, and added rspec for the event_record model

  • APPEALS-36684 - Updated RSpec tests and updated variables and got unhappy path to pass

  • cleaned lint

  • saving DRCE spec changes

  • fixed spec test

  • changed has_many to has_one

  • updated event model spec

  • added validation for ER poly associations

  • changed association to has_one

  • added new method and updated tests

  • added foreign key after running checks

  • some PR comment changes

  • refactored methods in EventConcern


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com
Co-authored-by: Enrilo Ugalde ugalde_enrilo@bah.com

  • added migration, scopes and specs for events (#20707)

  • fixed migration to update existing events table

  • rollbacked to fix schema

  • schema fixes


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • Jr/APPEALS-38926 (#20714)

  • APPEALS-38926 - Created DecisionReviewCreatedError Service Class, added logic for handling service error, updated DecisonReviewCreatedController, and DecisionReviewCreatedController spec, with the updated service logic

  • APPEALS-38926- created RSpec Test for DecisionReviewCreatedError Service Class and edited the Rails.logger for the service class

  • APPEALS-38926 Added new info column to update transaction and added it to the RSpec test

  • APPEALS-38926 - added comments to the Service Class

  • APPEALS-38926 - Code Changes from TL Code Review, added rescues and fails

  • APPEALS-38926 - fixed lint

  • Jonathan/appeals 36689 (#20671)

  • created new service class

  • add rspec test cases

  • service class methods

  • controller action and spec

  • controller update

  • CC fixes

  • removed accidental line

  • changed to find_or_create_by

  • reworked error for redis lock

  • additional rspec for controller

  • fixed test

  • rspec fix

  • delete lock key afterwards

  • moved Event creation back into lock block


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • APPEALS-39663 Create CreateUserOnEvent service class and add logic to create user if needed (#20838)

  • added user creation class & test

  • removed extra lines

  • add comment to class

  • added context for args from avro


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • Jr/APPEALS-39664 (#20898)

  • APPEALS-39664 - Created updated_vacols_on_optin module class, and removed extra private

  • APPEALS-39664 - created UpdatedVacolsOnOptin module, RSpec file, as well as sudo code for SOC and SSOC optin check in main service class DecisionReviewCreated

  • APPEALS-39664 - Created RSpec Test - PASS, Updated method name.

  • APPEALS-39664 - Added Error Handling to Sub Service Class

  • APPEALS-39664 - Removed un-needed comments

  • APPEALS-39664 - added include for the module UpdateVacolsOnOptin inside decision_review_created service

  • APPEALS-39664 - Added Custom Error , and updated all .perform! to .process!

  • APPEALS-39664 - Updated RSpec Test to reflect changes - all pass

  • Updated comment for decision_review_created Service Class

  • Will/appeals 36691 (#20909)

  • Created attribute for failed claims on event and displaying failed claim

  • passing all failed events back to serializer

  • added controller tests for failed_claims and added class method for finding claims on events

  • renamed failed_claims to claim_errors


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • JR/APPEALS-40954 Create CreateIntake service class and add logic to create Intake (#20967)

  • APPEALS-40954 - Added Sudo Code for CreateIntake Logic

  • APPEALS-40954 - added logic to CreateIntake module

  • APPEALS-40954 - added Create Intake spec with error handling - All pass

  • APPEALS-40954 - Added CreateIntake Module to DecisionReviewCreated Main Service

  • APPEALS-40954 - updated folder name and namespace

  • APPEALS-40954 - Updated RSpec to match folder

  • APPEALS-40954- Upated decision review created servie include to match folder

  • Fixed failing test due to folder structure change

  • Jonathan/appeals 40950 (#20965)

  • Added new veteran creation module

  • saving test changes

  • rspec

  • fixed datetime assign

  • renamed var


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • APPEALS-40950 - update var veteran to vbms_veteran (#21050)

  • APPEALS-40950 - update var veteran to vbms_veteran

  • updated private method in controller to match happy path params dcr to drc

  • Create CreateClaimantOnEvent service class and add logic to create claimant if needed (#21044)

  • created service class and basic unit tests

  • added conditionals for veteran claimants and will create veteran claimant now

  • modified create claimant to use eventing data

  • change to a class

  • creating claimant correctly

  • test fixes

  • removed old comments

  • fixed type for veteran_is_not_claimant

  • changed specs to match pulling out hash params and removed event.reference id

  • moved back to dot notation

  • updated comments

  • fixed create claimant issue

  • updated process to use bang method and returning claimant


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • APPEALS-41968 Modify Issues Endpoints & Update Metric Service Logic (#21108)

  • moved metricsService call to top of method

  • modified rspec case

  • moved metric logging spec case higher up


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • Resolved merge conflicts while merging master into feature/APPEALS-28… (#21167)

  • Jonathan/APPEALS-41957 (#21171)

  • added interface + parser class

  • edited veteran parse methods

  • renamed var to "payload"

  • started refactor

  • more refactor + rspec

  • added EPE attr

  • dateTime conversions

  • added class comments

  • rubocop lint changes

  • fixed test case


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • Jr/appeals 41931 (#21192)

  • APPEALS-41931 - Created create_ep_establishment file and class

  • APPEALS-41931 - added process! method that creates epe from payload

  • APPEALS-41931 - added logic for EventRecord being created and error handling

  • APPEALS-41931 - added comments to process method

  • APPEALS-41931 - set up rspec test

  • APPEALS-41931 - removed lint

  • APPEALS-41931-created Rspec and Test Pass

  • APPEALS-41931 - cleaned lint and added error test 100% code coverage

  • APPEALS-41931- fixed lint

  • APPEALS-41931- fixed lint and fixed %100 code cov

  • APPEALS-41931 - cleaned up lint and warn for Service Class

  • APPEALS-41931 - Added CreateEpEstablishment.process! to the decision_review_created Parent Service Class

  • APPEALS-41931 - refactor code to implement new parser

  • fixed linting issues

  • APPEALS-41931 - Updated Comments for CreateEpEstablishment

  • APPEALS-41931 - moved logical date int to parser and refactored code in Class and RSepc

  • edits

  • Will/appeals 41929 (#21205)

  • added an error and commented out call for createclaim

  • added new parser logic

  • merge request changes

  • fixed rubocop issues and added checks for claim review attributes


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • APPEALS-42631- Create Rspec for Parser with sample payload method, and add additional parser methods (#21294)

  • APPEALS-42631 - create example.json

  • APPEALS-42631 - implemented example_response and load_example method and works as expected

  • APPEALS-42631 - created RSpec for DecisionReviewCreatedParser

  • APPEALS-42631 - Refactored parser and Added RSpec for current praser

  • APPEALS-42631 - added methods to parser for intake, claimant, and claim_review and added matching rspec for new methods

  • APPEALS-42631 - updated code per TL Comments

  • APPEALS-421631- added additional comments and fixing lint

  • APPEALS-41934 (#21251)

  • initial commit

  • implementation & error

  • renamed method

  • rspec

  • saving refactor progress

  • finished refactoring class

  • added comment

  • minor parser/rspec updates


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • added RI parser methods to rspec (#21322)

  • added RI parser methods to rspec

  • updated config for Consumer


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • Update DecisionReviewCreated to make all calls and link all intake records (#21334)

  • updated decision review created to uncomment actions and updated specs

  • remove binding.pry

  • removed comments

  • fixed a bunch of broken tests

  • fixed last broken tests

  • fixed params for methods and specs


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • ...
Read more

Appeals Caseflow_R3.1.2_FY25Q1.1 Production Release

21 Oct 21:13
1158b8e
Compare
Choose a tag to compare

Commit: 1158b8e

Release/fy25 q1.1.4 (#23287)

  • Feature/appeals 49670 49667 phase ii release tested (#23257)

  • APPEALS-36688- Build out Decision Review Created API route & Controller (#20569)

  • added skeleton for api route

  • removed duplicate code

  • removed development envs for api and moved to creating an ApiKey

  • removing any changes to development.rb

  • removed extra auth code

  • removed before action


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • APPEALS-38232 -Build out Decision Review Created Event Failure API route & Controller (#20601)

  • APPEALS-38232 - renamed controller to AC req, added decision_review_created_error endpoint, added decision_review_created_error method, and added RSpec for new method

  • APPEALS-38232 - add comments to RSpec

  • Jonathan/appeals 36684 (#20516)

  • initial Events migration and model creation

  • created model for DecisionReviewCreatedEvent

  • updated comment with example

  • added spec for DRCE model

  • APPEALS-36684 created event_records migration and added polymorphic associations to specific models, and added rspec for the event_record model

  • APPEALS-36684 - Updated RSpec tests and updated variables and got unhappy path to pass

  • cleaned lint

  • saving DRCE spec changes

  • fixed spec test

  • changed has_many to has_one

  • updated event model spec

  • added validation for ER poly associations

  • changed association to has_one

  • added new method and updated tests

  • added foreign key after running checks

  • some PR comment changes

  • refactored methods in EventConcern


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com
Co-authored-by: Enrilo Ugalde ugalde_enrilo@bah.com

  • added migration, scopes and specs for events (#20707)

  • fixed migration to update existing events table

  • rollbacked to fix schema

  • schema fixes


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • Jr/APPEALS-38926 (#20714)

  • APPEALS-38926 - Created DecisionReviewCreatedError Service Class, added logic for handling service error, updated DecisonReviewCreatedController, and DecisionReviewCreatedController spec, with the updated service logic

  • APPEALS-38926- created RSpec Test for DecisionReviewCreatedError Service Class and edited the Rails.logger for the service class

  • APPEALS-38926 Added new info column to update transaction and added it to the RSpec test

  • APPEALS-38926 - added comments to the Service Class

  • APPEALS-38926 - Code Changes from TL Code Review, added rescues and fails

  • APPEALS-38926 - fixed lint

  • Jonathan/appeals 36689 (#20671)

  • created new service class

  • add rspec test cases

  • service class methods

  • controller action and spec

  • controller update

  • CC fixes

  • removed accidental line

  • changed to find_or_create_by

  • reworked error for redis lock

  • additional rspec for controller

  • fixed test

  • rspec fix

  • delete lock key afterwards

  • moved Event creation back into lock block


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • APPEALS-39663 Create CreateUserOnEvent service class and add logic to create user if needed (#20838)

  • added user creation class & test

  • removed extra lines

  • add comment to class

  • added context for args from avro


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • Jr/APPEALS-39664 (#20898)

  • APPEALS-39664 - Created updated_vacols_on_optin module class, and removed extra private

  • APPEALS-39664 - created UpdatedVacolsOnOptin module, RSpec file, as well as sudo code for SOC and SSOC optin check in main service class DecisionReviewCreated

  • APPEALS-39664 - Created RSpec Test - PASS, Updated method name.

  • APPEALS-39664 - Added Error Handling to Sub Service Class

  • APPEALS-39664 - Removed un-needed comments

  • APPEALS-39664 - added include for the module UpdateVacolsOnOptin inside decision_review_created service

  • APPEALS-39664 - Added Custom Error , and updated all .perform! to .process!

  • APPEALS-39664 - Updated RSpec Test to reflect changes - all pass

  • Updated comment for decision_review_created Service Class

  • Will/appeals 36691 (#20909)

  • Created attribute for failed claims on event and displaying failed claim

  • passing all failed events back to serializer

  • added controller tests for failed_claims and added class method for finding claims on events

  • renamed failed_claims to claim_errors


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • JR/APPEALS-40954 Create CreateIntake service class and add logic to create Intake (#20967)

  • APPEALS-40954 - Added Sudo Code for CreateIntake Logic

  • APPEALS-40954 - added logic to CreateIntake module

  • APPEALS-40954 - added Create Intake spec with error handling - All pass

  • APPEALS-40954 - Added CreateIntake Module to DecisionReviewCreated Main Service

  • APPEALS-40954 - updated folder name and namespace

  • APPEALS-40954 - Updated RSpec to match folder

  • APPEALS-40954- Upated decision review created servie include to match folder

  • Fixed failing test due to folder structure change

  • Jonathan/appeals 40950 (#20965)

  • Added new veteran creation module

  • saving test changes

  • rspec

  • fixed datetime assign

  • renamed var


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • APPEALS-40950 - update var veteran to vbms_veteran (#21050)

  • APPEALS-40950 - update var veteran to vbms_veteran

  • updated private method in controller to match happy path params dcr to drc

  • Create CreateClaimantOnEvent service class and add logic to create claimant if needed (#21044)

  • created service class and basic unit tests

  • added conditionals for veteran claimants and will create veteran claimant now

  • modified create claimant to use eventing data

  • change to a class

  • creating claimant correctly

  • test fixes

  • removed old comments

  • fixed type for veteran_is_not_claimant

  • changed specs to match pulling out hash params and removed event.reference id

  • moved back to dot notation

  • updated comments

  • fixed create claimant issue

  • updated process to use bang method and returning claimant


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • APPEALS-41968 Modify Issues Endpoints & Update Metric Service Logic (#21108)

  • moved metricsService call to top of method

  • modified rspec case

  • moved metric logging spec case higher up


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • Resolved merge conflicts while merging master into feature/APPEALS-28… (#21167)

  • Jonathan/APPEALS-41957 (#21171)

  • added interface + parser class

  • edited veteran parse methods

  • renamed var to "payload"

  • started refactor

  • more refactor + rspec

  • added EPE attr

  • dateTime conversions

  • added class comments

  • rubocop lint changes

  • fixed test case


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • Jr/appeals 41931 (#21192)

  • APPEALS-41931 - Created create_ep_establishment file and class

  • APPEALS-41931 - added process! method that creates epe from payload

  • APPEALS-41931 - added logic for EventRecord being created and error handling

  • APPEALS-41931 - added comments to process method

  • APPEALS-41931 - set up rspec test

  • APPEALS-41931 - removed lint

  • APPEALS-41931-created Rspec and Test Pass

  • APPEALS-41931 - cleaned lint and added error test 100% code coverage

  • APPEALS-41931- fixed lint

  • APPEALS-41931- fixed lint and fixed %100 code cov

  • APPEALS-41931 - cleaned up lint and warn for Service Class

  • APPEALS-41931 - Added CreateEpEstablishment.process! to the decision_review_created Parent Service Class

  • APPEALS-41931 - refactor code to implement new parser

  • fixed linting issues

  • APPEALS-41931 - Updated Comments for CreateEpEstablishment

  • APPEALS-41931 - moved logical date int to parser and refactored code in Class and RSepc

  • edits

  • Will/appeals 41929 (#21205)

  • added an error and commented out call for createclaim

  • added new parser logic

  • merge request changes

  • fixed rubocop issues and added checks for claim review attributes


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

  • APPEALS-42631- Create Rspec for Parser with sample payload method, and add additional parser methods (#21294)

  • APPEALS-42631 - create example.json

  • APPEALS-42631 - implemented example_response and load_example method and works as expected

  • APPEALS-42631 - created RSpec for DecisionReviewCreatedParser

  • APPEALS-42631 - Refactored parser and Added RSpec for current praser

  • APPEALS-42631 - added methods to parser for intake, claimant, and claim_review and added matching rspec for new methods

  • APPEALS-42631 - updated code per TL Comments

  • APPEALS-421631- added additional comments and fixing lint

  • APPEALS-41934 (#21251)

  • initial commit

  • implementation & error

  • renamed method

  • rspec

  • saving refactor progress

  • finished refactoring class

  • added comment

  • minor parser/rspec updates


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • added RI parser methods to rspec (#21322)

  • added RI parser methods to rspec

  • updated config for Consumer


Co-authored-by: Jonathan Tsang tsang_jonathan@bah.com

  • Update DecisionReviewCreated to make all calls and link all intake records (#21334)

  • updated decision review created to uncomment actions and updated specs

  • remove binding.pry

  • removed comments

  • fixed a bunch of broken tests

  • fixed last broken tests

  • fixed params for methods and specs


Co-authored-by: TuckerRose tuckerrose@tuckerroses-mbp.lan

...

Read more

Appeals Caseflow_R3.1.0_FY25Q1.1 Production Release

18 Oct 21:15
cb9fd70
Compare
Choose a tag to compare

Commit: cb9fd70

Feature/appeals 49670 49667 phase ii release tested (#23257) (#23269)

  • APPEALS-36688- Build out Decision Review Created API route & Controller (#20569)

  • added skeleton for api route

  • removed duplicate code

  • removed development envs for api and moved to creating an ApiKey

  • removing any changes to development.rb

  • removed extra auth code

  • removed before action


  • APPEALS-38232 -Build out Decision Review Created Event Failure API route & Controller (#20601)

  • APPEALS-38232 - renamed controller to AC req, added decision_review_created_error endpoint, added decision_review_created_error method, and added RSpec for new method

  • APPEALS-38232 - add comments to RSpec

  • Jonathan/appeals 36684 (#20516)

  • initial Events migration and model creation

  • created model for DecisionReviewCreatedEvent

  • updated comment with example

  • added spec for DRCE model

  • APPEALS-36684 created event_records migration and added polymorphic associations to specific models, and added rspec for the event_record model

  • APPEALS-36684 - Updated RSpec tests and updated variables and got unhappy path to pass

  • cleaned lint

  • saving DRCE spec changes

  • fixed spec test

  • changed has_many to has_one

  • updated event model spec

  • added validation for ER poly associations

  • changed association to has_one

  • added new method and updated tests

  • added foreign key after running checks

  • some PR comment changes

  • refactored methods in EventConcern


  • added migration, scopes and specs for events (#20707)

  • fixed migration to update existing events table

  • rollbacked to fix schema

  • schema fixes


  • Jr/APPEALS-38926 (#20714)

  • APPEALS-38926 - Created DecisionReviewCreatedError Service Class, added logic for handling service error, updated DecisonReviewCreatedController, and DecisionReviewCreatedController spec, with the updated service logic

  • APPEALS-38926- created RSpec Test for DecisionReviewCreatedError Service Class and edited the Rails.logger for the service class

  • APPEALS-38926 Added new info column to update transaction and added it to the RSpec test

  • APPEALS-38926 - added comments to the Service Class

  • APPEALS-38926 - Code Changes from TL Code Review, added rescues and fails

  • APPEALS-38926 - fixed lint

  • Jonathan/appeals 36689 (#20671)

  • created new service class

  • add rspec test cases

  • service class methods

  • controller action and spec

  • controller update

  • CC fixes

  • removed accidental line

  • changed to find_or_create_by

  • reworked error for redis lock

  • additional rspec for controller

  • fixed test

  • rspec fix

  • delete lock key afterwards

  • moved Event creation back into lock block


  • APPEALS-39663 Create CreateUserOnEvent service class and add logic to create user if needed (#20838)

  • added user creation class & test

  • removed extra lines

  • add comment to class

  • added context for args from avro


  • Jr/APPEALS-39664 (#20898)

  • APPEALS-39664 - Created updated_vacols_on_optin module class, and removed extra private

  • APPEALS-39664 - created UpdatedVacolsOnOptin module, RSpec file, as well as sudo code for SOC and SSOC optin check in main service class DecisionReviewCreated

  • APPEALS-39664 - Created RSpec Test - PASS, Updated method name.

  • APPEALS-39664 - Added Error Handling to Sub Service Class

  • APPEALS-39664 - Removed un-needed comments

  • APPEALS-39664 - added include for the module UpdateVacolsOnOptin inside decision_review_created service

  • APPEALS-39664 - Added Custom Error , and updated all .perform! to .process!

  • APPEALS-39664 - Updated RSpec Test to reflect changes - all pass

  • Updated comment for decision_review_created Service Class

  • Will/appeals 36691 (#20909)

  • Created attribute for failed claims on event and displaying failed claim

  • passing all failed events back to serializer

  • added controller tests for failed_claims and added class method for finding claims on events

  • renamed failed_claims to claim_errors


  • JR/APPEALS-40954 Create CreateIntake service class and add logic to create Intake (#20967)

  • APPEALS-40954 - Added Sudo Code for CreateIntake Logic

  • APPEALS-40954 - added logic to CreateIntake module

  • APPEALS-40954 - added Create Intake spec with error handling - All pass

  • APPEALS-40954 - Added CreateIntake Module to DecisionReviewCreated Main Service

  • APPEALS-40954 - updated folder name and namespace

  • APPEALS-40954 - Updated RSpec to match folder

  • APPEALS-40954- Upated decision review created servie include to match folder

  • Fixed failing test due to folder structure change

  • Jonathan/appeals 40950 (#20965)

  • Added new veteran creation module

  • saving test changes

  • rspec

  • fixed datetime assign

  • renamed var


  • APPEALS-40950 - update var veteran to vbms_veteran (#21050)

  • APPEALS-40950 - update var veteran to vbms_veteran

  • updated private method in controller to match happy path params dcr to drc

  • Create CreateClaimantOnEvent service class and add logic to create claimant if needed (#21044)

  • created service class and basic unit tests

  • added conditionals for veteran claimants and will create veteran claimant now

  • modified create claimant to use eventing data

  • change to a class

  • creating claimant correctly

  • test fixes

  • removed old comments

  • fixed type for veteran_is_not_claimant

  • changed specs to match pulling out hash params and removed event.reference id

  • moved back to dot notation

  • updated comments

  • fixed create claimant issue

  • updated process to use bang method and returning claimant


  • APPEALS-41968 Modify Issues Endpoints & Update Metric Service Logic (#21108)

  • moved metricsService call to top of method

  • modified rspec case

  • moved metric logging spec case higher up


  • Resolved merge conflicts while merging master into feature/APPEALS-28… (#21167)

  • Jonathan/APPEALS-41957 (#21171)

  • added interface + parser class

  • edited veteran parse methods

  • renamed var to "payload"

  • started refactor

  • more refactor + rspec

  • added EPE attr

  • dateTime conversions

  • added class comments

  • rubocop lint changes

  • fixed test case


  • Jr/appeals 41931 (#21192)

  • APPEALS-41931 - Created create_ep_establishment file and class

  • APPEALS-41931 - added process! method that creates epe from payload

  • APPEALS-41931 - added logic for EventRecord being created and error handling

  • APPEALS-41931 - added comments to process method

  • APPEALS-41931 - set up rspec test

  • APPEALS-41931 - removed lint

  • APPEALS-41931-created Rspec and Test Pass

  • APPEALS-41931 - cleaned lint and added error test 100% code coverage

  • APPEALS-41931- fixed lint

  • APPEALS-41931- fixed lint and fixed %100 code cov

  • APPEALS-41931 - cleaned up lint and warn for Service Class

  • APPEALS-41931 - Added CreateEpEstablishment.process! to the decision_review_created Parent Service Class

  • APPEALS-41931 - refactor code to implement new parser

  • fixed linting issues

  • APPEALS-41931 - Updated Comments for CreateEpEstablishment

  • APPEALS-41931 - moved logical date int to parser and refactored code in Class and RSepc

  • edits

  • Will/appeals 41929 (#21205)

  • added an error and commented out call for createclaim

  • added new parser logic

  • merge request changes

  • fixed rubocop issues and added checks for claim review attributes


  • APPEALS-42631- Create Rspec for Parser with sample payload method, and add additional parser methods (#21294)

  • APPEALS-42631 - create example.json

  • APPEALS-42631 - implemented example_response and load_example method and works as expected

  • APPEALS-42631 - created RSpec for DecisionReviewCreatedParser

  • APPEALS-42631 - Refactored parser and Added RSpec for current praser

  • APPEALS-42631 - added methods to parser for intake, claimant, and claim_review and added matching rspec for new methods

  • APPEALS-42631 - updated code per TL Comments

  • APPEALS-421631- added additional comments and fixing lint

  • APPEALS-41934 (#21251)

  • initial commit

  • implementation & error

  • renamed method

  • rspec

  • saving refactor progress

  • finished refactoring class

  • added comment

  • minor parser/rspec updates


  • added RI parser methods to rspec (#21322)

  • added RI parser methods to rspec

  • updated config for Consumer


  • Update DecisionReviewCreated to make all calls and link all intake records (#21334)

  • updated decision review created to uncomment actions and updated specs

  • remove binding.pry

  • removed comments

  • fixed a bunch of broken tests

  • fixed last broken tests

  • fixed params for methods and specs


  • APPEALS-43446- Change name of BackfillRecord polymorphic model to EventedRecord (#21382)

  • APPEALS-43446 - renamed columns for backfill record to evented record migrate and rollback work as intended

  • APPEALS-43446 replaced all backfill_record with evented_record within the models associations and updated Rspec tests

  • APPEALS-43446 fixed error message

  • Jr/ama controller refactor (#21365)

  • fixed test and refactored controller

  • saving changes

  • init commit passing all the way to request_issues

  • all pass and functions as expected

  • lint

  • lint

  • updated initializer to use deep_symbolize_keys

  • updated headers to be more dry

  • added missing Intake attributes

  • fixed failing tests

  • updated createIntake test

  • fixed veteran rspec

  • fixed RI test

  • APPEALS-43446- Change name of BackfillRecord polymorphic ...

Read more

deployed/20241017_212414

17 Oct 21:24
cb9fd70
Compare
Choose a tag to compare

Commit: cb9fd70

Feature/appeals 49670 49667 phase ii release tested (#23257) (#23269)

  • APPEALS-36688- Build out Decision Review Created API route & Controller (#20569)

  • added skeleton for api route

  • removed duplicate code

  • removed development envs for api and moved to creating an ApiKey

  • removing any changes to development.rb

  • removed extra auth code

  • removed before action


  • APPEALS-38232 -Build out Decision Review Created Event Failure API route & Controller (#20601)

  • APPEALS-38232 - renamed controller to AC req, added decision_review_created_error endpoint, added decision_review_created_error method, and added RSpec for new method

  • APPEALS-38232 - add comments to RSpec

  • Jonathan/appeals 36684 (#20516)

  • initial Events migration and model creation

  • created model for DecisionReviewCreatedEvent

  • updated comment with example

  • added spec for DRCE model

  • APPEALS-36684 created event_records migration and added polymorphic associations to specific models, and added rspec for the event_record model

  • APPEALS-36684 - Updated RSpec tests and updated variables and got unhappy path to pass

  • cleaned lint

  • saving DRCE spec changes

  • fixed spec test

  • changed has_many to has_one

  • updated event model spec

  • added validation for ER poly associations

  • changed association to has_one

  • added new method and updated tests

  • added foreign key after running checks

  • some PR comment changes

  • refactored methods in EventConcern


  • added migration, scopes and specs for events (#20707)

  • fixed migration to update existing events table

  • rollbacked to fix schema

  • schema fixes


  • Jr/APPEALS-38926 (#20714)

  • APPEALS-38926 - Created DecisionReviewCreatedError Service Class, added logic for handling service error, updated DecisonReviewCreatedController, and DecisionReviewCreatedController spec, with the updated service logic

  • APPEALS-38926- created RSpec Test for DecisionReviewCreatedError Service Class and edited the Rails.logger for the service class

  • APPEALS-38926 Added new info column to update transaction and added it to the RSpec test

  • APPEALS-38926 - added comments to the Service Class

  • APPEALS-38926 - Code Changes from TL Code Review, added rescues and fails

  • APPEALS-38926 - fixed lint

  • Jonathan/appeals 36689 (#20671)

  • created new service class

  • add rspec test cases

  • service class methods

  • controller action and spec

  • controller update

  • CC fixes

  • removed accidental line

  • changed to find_or_create_by

  • reworked error for redis lock

  • additional rspec for controller

  • fixed test

  • rspec fix

  • delete lock key afterwards

  • moved Event creation back into lock block


  • APPEALS-39663 Create CreateUserOnEvent service class and add logic to create user if needed (#20838)

  • added user creation class & test

  • removed extra lines

  • add comment to class

  • added context for args from avro


  • Jr/APPEALS-39664 (#20898)

  • APPEALS-39664 - Created updated_vacols_on_optin module class, and removed extra private

  • APPEALS-39664 - created UpdatedVacolsOnOptin module, RSpec file, as well as sudo code for SOC and SSOC optin check in main service class DecisionReviewCreated

  • APPEALS-39664 - Created RSpec Test - PASS, Updated method name.

  • APPEALS-39664 - Added Error Handling to Sub Service Class

  • APPEALS-39664 - Removed un-needed comments

  • APPEALS-39664 - added include for the module UpdateVacolsOnOptin inside decision_review_created service

  • APPEALS-39664 - Added Custom Error , and updated all .perform! to .process!

  • APPEALS-39664 - Updated RSpec Test to reflect changes - all pass

  • Updated comment for decision_review_created Service Class

  • Will/appeals 36691 (#20909)

  • Created attribute for failed claims on event and displaying failed claim

  • passing all failed events back to serializer

  • added controller tests for failed_claims and added class method for finding claims on events

  • renamed failed_claims to claim_errors


  • JR/APPEALS-40954 Create CreateIntake service class and add logic to create Intake (#20967)

  • APPEALS-40954 - Added Sudo Code for CreateIntake Logic

  • APPEALS-40954 - added logic to CreateIntake module

  • APPEALS-40954 - added Create Intake spec with error handling - All pass

  • APPEALS-40954 - Added CreateIntake Module to DecisionReviewCreated Main Service

  • APPEALS-40954 - updated folder name and namespace

  • APPEALS-40954 - Updated RSpec to match folder

  • APPEALS-40954- Upated decision review created servie include to match folder

  • Fixed failing test due to folder structure change

  • Jonathan/appeals 40950 (#20965)

  • Added new veteran creation module

  • saving test changes

  • rspec

  • fixed datetime assign

  • renamed var


  • APPEALS-40950 - update var veteran to vbms_veteran (#21050)

  • APPEALS-40950 - update var veteran to vbms_veteran

  • updated private method in controller to match happy path params dcr to drc

  • Create CreateClaimantOnEvent service class and add logic to create claimant if needed (#21044)

  • created service class and basic unit tests

  • added conditionals for veteran claimants and will create veteran claimant now

  • modified create claimant to use eventing data

  • change to a class

  • creating claimant correctly

  • test fixes

  • removed old comments

  • fixed type for veteran_is_not_claimant

  • changed specs to match pulling out hash params and removed event.reference id

  • moved back to dot notation

  • updated comments

  • fixed create claimant issue

  • updated process to use bang method and returning claimant


  • APPEALS-41968 Modify Issues Endpoints & Update Metric Service Logic (#21108)

  • moved metricsService call to top of method

  • modified rspec case

  • moved metric logging spec case higher up


  • Resolved merge conflicts while merging master into feature/APPEALS-28… (#21167)

  • Jonathan/APPEALS-41957 (#21171)

  • added interface + parser class

  • edited veteran parse methods

  • renamed var to "payload"

  • started refactor

  • more refactor + rspec

  • added EPE attr

  • dateTime conversions

  • added class comments

  • rubocop lint changes

  • fixed test case


  • Jr/appeals 41931 (#21192)

  • APPEALS-41931 - Created create_ep_establishment file and class

  • APPEALS-41931 - added process! method that creates epe from payload

  • APPEALS-41931 - added logic for EventRecord being created and error handling

  • APPEALS-41931 - added comments to process method

  • APPEALS-41931 - set up rspec test

  • APPEALS-41931 - removed lint

  • APPEALS-41931-created Rspec and Test Pass

  • APPEALS-41931 - cleaned lint and added error test 100% code coverage

  • APPEALS-41931- fixed lint

  • APPEALS-41931- fixed lint and fixed %100 code cov

  • APPEALS-41931 - cleaned up lint and warn for Service Class

  • APPEALS-41931 - Added CreateEpEstablishment.process! to the decision_review_created Parent Service Class

  • APPEALS-41931 - refactor code to implement new parser

  • fixed linting issues

  • APPEALS-41931 - Updated Comments for CreateEpEstablishment

  • APPEALS-41931 - moved logical date int to parser and refactored code in Class and RSepc

  • edits

  • Will/appeals 41929 (#21205)

  • added an error and commented out call for createclaim

  • added new parser logic

  • merge request changes

  • fixed rubocop issues and added checks for claim review attributes


  • APPEALS-42631- Create Rspec for Parser with sample payload method, and add additional parser methods (#21294)

  • APPEALS-42631 - create example.json

  • APPEALS-42631 - implemented example_response and load_example method and works as expected

  • APPEALS-42631 - created RSpec for DecisionReviewCreatedParser

  • APPEALS-42631 - Refactored parser and Added RSpec for current praser

  • APPEALS-42631 - added methods to parser for intake, claimant, and claim_review and added matching rspec for new methods

  • APPEALS-42631 - updated code per TL Comments

  • APPEALS-421631- added additional comments and fixing lint

  • APPEALS-41934 (#21251)

  • initial commit

  • implementation & error

  • renamed method

  • rspec

  • saving refactor progress

  • finished refactoring class

  • added comment

  • minor parser/rspec updates


  • added RI parser methods to rspec (#21322)

  • added RI parser methods to rspec

  • updated config for Consumer


  • Update DecisionReviewCreated to make all calls and link all intake records (#21334)

  • updated decision review created to uncomment actions and updated specs

  • remove binding.pry

  • removed comments

  • fixed a bunch of broken tests

  • fixed last broken tests

  • fixed params for methods and specs


  • APPEALS-43446- Change name of BackfillRecord polymorphic model to EventedRecord (#21382)

  • APPEALS-43446 - renamed columns for backfill record to evented record migrate and rollback work as intended

  • APPEALS-43446 replaced all backfill_record with evented_record within the models associations and updated Rspec tests

  • APPEALS-43446 fixed error message

  • Jr/ama controller refactor (#21365)

  • fixed test and refactored controller

  • saving changes

  • init commit passing all the way to request_issues

  • all pass and functions as expected

  • lint

  • lint

  • updated initializer to use deep_symbolize_keys

  • updated headers to be more dry

  • added missing Intake attributes

  • fixed failing tests

  • updated createIntake test

  • fixed veteran rspec

  • fixed RI test

  • APPEALS-43446- Change name of BackfillRecord polymorphic mod...

Read more

deployed/20241016_211611

16 Oct 21:16
cec8f67
Compare
Choose a tag to compare

Commit: cec8f67

Fix ECR Token Refresh Job (#23157)

  • Add workaround for ECR job dependency resolution

  • Use venv to isolate dependencies and update said dependencies to be compatible with the latest ubuntu-latest image

Add awscli deubgging step

Explicitly install awscli

Separate venv setup into its own step for clarity

Pin awscli dependency version

Upgrade botocore


Co-authored-by: Matthew Thornton ThorntonMatthew@users.noreply.github.com

deployed/20241015_211451

15 Oct 21:14
cec8f67
Compare
Choose a tag to compare

Commit: cec8f67

Fix ECR Token Refresh Job (#23157)

  • Add workaround for ECR job dependency resolution

  • Use venv to isolate dependencies and update said dependencies to be compatible with the latest ubuntu-latest image

Add awscli deubgging step

Explicitly install awscli

Separate venv setup into its own step for clarity

Pin awscli dependency version

Upgrade botocore


Co-authored-by: Matthew Thornton ThorntonMatthew@users.noreply.github.com

deployed/20241014_211557

14 Oct 21:15
cec8f67
Compare
Choose a tag to compare

Commit: cec8f67

Fix ECR Token Refresh Job (#23157)

  • Add workaround for ECR job dependency resolution

  • Use venv to isolate dependencies and update said dependencies to be compatible with the latest ubuntu-latest image

Add awscli deubgging step

Explicitly install awscli

Separate venv setup into its own step for clarity

Pin awscli dependency version

Upgrade botocore


Co-authored-by: Matthew Thornton ThorntonMatthew@users.noreply.github.com