Release deployed/20240712_173602 · department-of-veterans-affairs/caseflow

Commit: `5fbafad`

APPEALS-51431 DSVA Resource Audit and Cleanup: Caseflow Repo

Commit: `67e62f3`

Revert email address (#22141)

Commit: `35aa3b0`

Release R1.6.0 FY24Q3.6 (#22117)

APPEALS-44148: Add ruby_claim_evidence_api gem (#22059)
APPEALS-50758: Fix broken tests in spec/controllers/case_distribution_levers_controller_spec.rb (#22072)
update test data to fix tests
fix test data setup
fix dates in test setup
disable flaky jest test
APPEALS-49845: Hearing CAVC Appeals are not respecting CAVC affinity (#22043)
pass judge into base relation queries on hearing docket
update scopes to distribute CAVC hearing to original judge when within hearing window
APPEALS-49845: Add seed data (#22056)
add seed data
fix users seed spec
APPEALS-49555: Some AOD appeals are not being selected as priority by the distribution algorithm (#22067)
aod appeal with claimants person does not contain DOB
Addressed comments

Co-authored-by: Craig Reese 109101548+craigrva@users.noreply.github.com

Merge feature/appeals-34320 into release branch (#22094)
ClayS/APPEALS-39107 (#21458)
add request issue modification button for non-admins
add tests covering the request issue modification button
appease rubocop overlord
update feature tests
change to inline style and absolute import
update feature test

Co-authored-by: Brandon Lee Dorner Brandondorner@yahoo.com

JHoang/APPEALS-39445 (#21445)
added new dropdown actions for edit issues, restricted visibility to non vha admins
fix failing tests
update jest for new dropdown actions
added placeholder modal for request additional issue button
Replace relative import with absolute, rename variable to check for non vha admin
render new dropdown actions and button only for in progress tasks
revert previous changes, added new changes
fix typo in issuelist
typo again
remove extra empty line
fix jest tests and vha_hlr_sc rspec
address styling issues
more restrictions to dropdown/button visibility
remove unused comments

Co-authored-by: Jonathan Hoang trinhjoanthan.hoang@va.gov

Pending Request Issues seeds, factories and query update (#21437)
migration and initial commit of the factory
changing approve status to status
Added active record associations on models, added factory attributes, added pending tasks on queue tab
adding AC-2 condition to get pending record response from pending_request_issue table
factory and seed for pending_request_issues
Added pending request issues count alias for sorting and serialization to Task query
adding issue_type_Count and task_type_count for pending tab
Added spec tests for vha business line and business line spec files, cleaned up the controller, modified issue_type_count query
fixing the spec failures and code climate issues
removed byebug
Fixing code climate issue and adding seed data
fixing the schema error
Revert "fixing the schema error"

This reverts commit 73070fa.

skip association so that test passes
renaming the table to - issue_modification_request and corresponding changes to the model, factories
fixing spec failures and linter
fixing spec failures and linter
making sure pending tasks doesnt show up in in progress tab and modified the factory so that Claimant name appears
fixing the spec failure
removing coalesce and removing null: true
more PR feedbacks
adding fix to the PR comments
removing distinct
fixing the error in the query
Apply suggestions from code review

Co-authored-by: Tyler Broyles 109369527+TylerBroyles@users.noreply.github.com

removing limit as suggested in the pr
Adding evaluator to the factory and adding it to the seeds
Adding PaperTrail for change history stuff
adding schema
adding new column to the table
changed decider_decision_text to decider_note

Co-authored-by: almorbah al.mortada@va.gov
Co-authored-by: Tyler Broyles 109369527+TylerBroyles@users.noreply.github.com

SeanC/APPEALS-40669 | Creation of ‘Pending admin review’ section on Edit Issues Page (#21604)
Added fake data and rendering for it
made the fake data better
pending issues are being rendered
passed up user admin of org from backend
Added userIsOrgAdmin to the frontend
created admin and non fake data
determined fake data to use based on userIsOrgAdmin
got the issues to render
Created a new IssueModificationList component
updated the issuemodification and row to work with the lists
updated the fake data and the issues container
removed some code for getting the user info
updated IssueModificationRequest to make wireframe
Updated row and list to work with the new request
updated the fake data
added propTypes to IssuesModificationList
cleaned up some lint in addissues
added Prop types to request
added key to list
improved row
improved the row logic
added some space to the list
refactored the layout for the request
added text to the COPY
slight change to fake data
refactored the row
got sorting working
added id to map of list
updated formating functions for modificationIssueRequests
updated the request to work with the formated data
removed some console logs in row
updated addIssues to format the fake data
updated request to work with the serializer
removed logs
updated fake data and formatter
removed unneed code
removed unneed code
removed unneed code
Rename IssueModificationRow.jsx to issueModificationRow.jsx
removed unneed code and renamed a couple things
Slight change to request
removed some comments
added some data for the jest test
got some of the jest tests working
fixed a typo in request
updated the prop for the tests
fixed the broken test and added more for list
Fixed the fake data and removed unneed code
removed unneed coded
changed the html in the request to better match the design
added css rule for new class
fixed an typo in COPY
similified some logic in row
added logic to not create the pending section if it is null
cleaned up some lint in intake.scss
updated the fake data to better match the wireframes
added divider inbetween requests
formatted the dates on the request

Co-authored-by: Clay Sheppard csheepy@gmail.com

TYLERB/APPEALS-39106: Creation of Pending tab (#21455)
Initial commit to add the pending tab to the vha business line decision review queue.
Updated existing tests and added new ones for the pending tab.
Added tab task counts to the decision review queue.
Adjusted variable names to match up with the feature branch. Made a column change to the create_issue_modification_request migration file. Added in methods to serialize the issue_modification_requests. Added pending_issue_modification_requests to the decision review serializer.
Updated schema.
Added a serialzer and related javascript and redux methods to place issue modification requests into the frontend.
Updated tests to work with new issue modification request factories.
Added a couple more test scenarios for the decision review controller spec file and changed the FactoryBot.create methods to create().
Removed extra copies of the pending tab mappings and if statements from the decision reviews controller that happened due to the feature merge.
Updated ReviewPage jest test snapshots. Updated and added more tests to the NonCompTabs jest test for the new pending tasks tab. Fixed an issue where the TaskTableTab was added an empty hash to the columns as a placeholder for the pending requests column instead of not adding any additional columns.
Added a few constant variables to copy.json and queue config and removed todo statements.
Fixed serializer tests and Fixed a constant name.
Renamed some javascript variables to match the serializer.
Fixed more broken tests.
Updated the pending tasks query to show the correct amount of pending issues instead of an incorrect count. Added the pendingRequests column to the SORT_COLUMN_MAPPINGS in the decision reviews controller so that the user can sort by the new pending requests column via the controller. Added tests to cover these scenarios.
Made some layout and css adjustments to the search bar and tab description for the decision review queue.
Added padding to the bottom of the new search box and description div to create some space between ui elements. Changed the tab titles in the decision review queue to be title case for all words instead of only the first word.

Co-authored-by: Brandon Lee Dorner Brandondorner@yahoo.com

Appeals-40989 - Inclusion of required Decision Date Banner on Add Issues (#21588)
APPEALS-40989: Adding functionality to check if user is vhaAdmin and task is in progress then display Banner and make decision date required.
Fixing spec failures, adding new model spec, new task factory to support spec
fixing linter issues in spec
Adding storybook and fixing codeclimate complain
fixing PR comments and adding banner to unidendified modal
removing local font sizing
fixing linter issue
APPEALS-39446 - Modal creation – modification, removal, withdrawal, request additional issue [Non-Admin] (#21681)
WIP components

TODO: validation/errors, redux

add some error messages and the error schema for the addition modal
add missing data error messages for the rest of the modals
add test coverage for issue modification request frontend errors
disable submit button until form is dirty
remove currentIssue from request additional issue modal
DRY out these modals
clean up imports and some formatting
WIP stuck the issue modification requests into redux
add requested additional issues to the pending review section
get benefit type from redux
add test covering modal submission
remove unnecessary expectation
move a line to read better
linting fixes and remove unneeded code
update test
really fix this test
try to fix the add isues page
fix ambiguous click in spec
add storybook for modals
update snapshot
update capitalization in reviews spec
destructure modal props
more destructuring
use full name and css id for requestor
import less lodash
fix some more capitalization
remove old comment
Update client/app/intakeEdit/components/RequestCommonComponents/RequestIssueFormWrapper.jsx

Co-authored-by: Tyler Broyles 109369527+TylerBroyles@users.noreply.github.com

Update client/app/intake/components/IssueModificationRequest.jsx

Co-authored-by: Tyler Broyles 109369527+TylerBroyles@users.noreply.github.com

prevent future dates in issue modification requests
format decision date in current issue section
Prior decision date -> Decision date

Co-authored-by: Prajwal Amatya 122557351+pamatyatake2@users.noreply.github.com
Co-authored-by: Tyler Broyles 109369527+TylerBroyles@users.noreply.github.com

TYLERB/APPEALS-39447: Display of banner on Edit Issues page – issues with pending requests (#21695)
Initial commit. Added the PendingIssueModificationRequestsBanner. Added the connection between the serialized pending issue modification requests to the ui in the front end EditAddIssues page. Refactored the issueModificationRow, IssueModificationList, and IssueModificationRequest components. Changed the request_type enumeration to be lowercased to match the key value and changed the database schema, migration, and factory to match up with the new enumeration value.
Added withdrawal_date to the serializer and redux store for issue modifications. Renamed a constant variable from body to message. Swapped a groupBy function to the lodash version since it was causing capyabara to fail for the feature test. Added a feature test for the banner. Also added a some helper functions and feature test checks for the issue modification requests when pulling data from the actual database objects instead of mocked data.
Updated jest test.
Added a backup description to the request issue in the IssueModificationRequest.jsx file so it will work for request issues being moved to the section via the ui.
Changed an rspec matcher to fix code climate issue.
Removed two junk console output files that were erroneously created.
Made changes to the issue modification ui to match the feature branch changes and renamed the redux key to always use pendingIssueModificationRequests.
Added a new redux store key for the originalPendingRequests in order to move them around. Reworked how the issues were being removed from the issues section when they are associated to an existing or new pending request.
Cleaned up old issue modification request redux code.
Reverted a change to the intake redux store since the objects are added via reference instead of an object clone.
Fixed an issue where having empty pendingIssueModificationRequ
ests was causing a javascript error. Removed some todo comments and commented code.
Removed another todo comment.
Removed the pending requests banner from the cancel edit issues page.
Changed the issue modification seeds file to use the correct values for the request_type attribute based on the enumeration value change to always use lowercase values. Updated a variable name in javascript to be more descriptive.
Updated the RequestIssueFormWrapper component so that withdrawal and removal requests would behave in the same way as modification of existing issue requests. Fixed a bug where the decision date was being set to undefined or null for removal or withdrawal issue modification requests instead of taking the decision date from the original issue.
Removed n+1 bullet warnings from the decision_review serialization process for pending_issue_modification_requests.
APPEALS-45242 (partial) (#21759)
add a doubleArrow option to SearchableDropdown
overriden -> replaced
JHoang/APPEALS-40672 (#21756)
Initial commit. Added the PendingIssueModificationRequestsBanner. Added the connection between the serialized pending issue modification requests to the ui in the front end EditAddIssues page. Refactored the issueModificationRow, IssueModificationList, and IssueModificationRequest components. Changed the request_type enumeration to be lowercased to match the key value and changed the database schema, migration, and factory to match up with the new enumeration value.
Added withdrawal_date to the serializer and redux store for issue modifications. Renamed a constant variable from body to message. Swapped a groupBy function to the lodash version since it was causing capyabara to fail for the feature test. Added a feature test for the banner. Also added a some helper functions and feature test checks for the issue modification requests when pulling data from the actual database objects instead of mocked data.
Updated jest test.
Added a backup description to the request issue in the IssueModificationRequest.jsx file so it will work for request issues being moved to the section via the ui.
Changed an rspec matcher to fix code climate issue.
Removed two junk console output files that were erroneously created.
Made changes to the issue modification ui to match the feature branch changes and renamed the redux key to always use pendingIssueModificationRequests.
Added a new redux store key for the originalPendingRequests in order to move them around. Reworked how the issues were being removed from the issues section when they are associated to an existing or new pending request.
Cleaned up old issue modification request redux code.
Reverted a change to the intake redux store since the objects are added via reference instead of an object clone.
Fixed an issue where having empty pendingIssueModificationRequ
ests was causing a javascript error. Removed some todo comments and commented code.
Removed another todo comment.
Removed the pending requests banner from the cancel edit issues page.
Changed the issue modification seeds file to use the correct values for the request_type attribute based on the enumeration value change to always use lowercase values. Updated a variable name in javascript to be more descriptive.
Added modal to request cancellation of an existing request modification
fix lint and failing jest
conditional rendering in cancelpendingrequestissue modal
fix decision date and withdrawal dates not showing correctly when requesting modification
fix mocked props for CancelPendingRequestIssueModal.test.js
revert date changes, fix issue description display
Updated the RequestIssueFormWrapper component so that withdrawal and removal requests would behave in the same way as modification of existing issue requests. Fixed a bug where the decision date was being set to undefined or null for removal or withdrawal issue modification requests instead of taking the decision date from the original issue.
added space between current issue and pending issue request
refactor cancelpendingrequestissuemodal structure
remove temp dropdown button

Co-authored-by: = tyler.broyles@va.gov
Co-authored-by: Jonathan Hoang trinhjoanthan.hoang@va.gov

Al/appeals 45834 (#21641)
Added non admin issue modification request logic
added finial touches on NON::AdminModificationRequestsUpdater class
Added logic to make sure that the user is an admin or non-admin who belongs to Vha organization
Added some Rspec tests for NonAdmin::IssueModificationRequestsUpdater and cleaned up Class
Added controller spec tests for SupplementalClaimsController#update HigherLevelReviewsController#update
Code clean up
Fixing lining errors
code clean up
Added code to fix some failing rspec tests
fixed linting errors
Ensure backend validation – only one request per issue
If an issue already has a request and another is submitted, an error is thrown
rebased off latest feature branch and downcased request_type and status params
Added request_issue_id param to account for existing request_issues in situations when request_type is other than addition. Adjusted process_modification? method
Added changes based on PR feedback
added a shared example block to dry up code
more feedback
changed name file structure
Needed to re-handle validation errors
Pamatya/appeals 40671- adding Select action dropdown to the Admin section (#21788)
Adding props and searchable dropdown to meet ac
fixing linter, and adding test
added storybook for issue modification row and issue section row
fixing the values in the popup
fixing the Removal and withdrawal modal to behave similar to modification modal
making changes to the code to fix the bug
fixing spec, linter and jest failures
missing schema file
changing the Onclick to take object instead of the index or identifier
removing unused code
code cleanup
J hoang/appeals 40987 (#21889)
move issue modification request actions to new file, created new confirm issue modification change modal
fixed some code climate issues
some changes from review
fix jest
added new action to update pending issue request
maybe fix tests?
revert pending admin review display
change pending admin review display to active pending issues only
fix pending admin display
consistent parameter placement and added an extra check for requested issues display
fix all failing tests
fix movetopendingreview action call breaking rspec
fix cancel buttons on confirm modal modification

Co-authored-by: Jonathan Hoang trinhjoanthan.hoang@va.gov

APPEALS-46705: Addition of SearchableDropdown to IssueList (#21752)
change issue action selector component and appearance
fix padding
fix linting error
fix frontend tests
fix list rendering bug
wip fix one type of failure
fix a couple more kinds of failure
fix tests in ama_queue_workflow_spec
fix a couple tests
another one
fix dropdown helpers to work if something was already selected
fix test in edit_ep_claim_labels_spec
fix issue modification request specs
more tests
update more tests
whac a mole
remove comment
fix padding
remove comment and whitespace
make specs consistent
SeanC/APPEALS-40670 | Update actions and pending request modal on Edit Issues Page – issues with pending requests [Non-Admin] (#21857)
got the options actions working
hooked up the cancel action
added some styling for drop down
changed the wording of the dropdown actions
added new onClick action, added pending obj to state and cleared it
passed the onClick to Row and List
added onClick and useSelector to Request
added new redux action
removed comment
added edit redux action
fixed an issue from merge in addIssues
updated the options to work with non admin actions and readOnly
removed unneed styles
removed comment
changed modal title to change based on pendingIssueModificationRequests
removed redundant code
updated action and reducer to work with other code
updated name of action on parent component
updated form wrapper to work with new action
fixed a failing spec test
Added tests for action options for non and admin users
refactored the props for the test for IssueModificationList
slight change to the test
add new test in issue_modification_request spec
added logic in Request for the text to change slightly
fixed a failing test
fixed an error with the form wrapper
fixed a few issues from the merge
fixed failing test
fixed an issue from the merge
changed I back to i for issueModificationRow
refactored options to a const in Request
removed added comma in constants
renamed const in FormWrapper
removed no longer needed props in IssueModificationListProps
removed setting the index when reviewing a modification request
fixed a date formatting issue
created const for pendingIssueModificationRequest
Fixed issue with incorrectly changing admin modal title
cleaned up some lint
cleaned up more lint
fixed an import issue
removed conditional for the label text
fixed a failing jest test
fixed failing rspec
removed comment in issue_modification_request_spec
APPEALS-47866 (#21916)
UX changes for modals

red buttons -> blue buttons
text wraps around icon
copy updates

rspec updates
update snapshots
add a storybook for modals with icons
refactor storybook
remove class
switch to constants
remove unnecessary props
fix the AddIssues storybook
tinkering
update snapshots again
Pamatya/appeals 40997 v3 (#21926)
move issue modification request actions to new file, created new confirm issue modification change modal
fixed some code climate issues
some changes from review
fix jest
added new action to update pending issue request
maybe fix tests?
revert pending admin review display
change pending admin review display to active pending issues only
fix pending admin display
consistent parameter placement and added an extra check for requested issues display
fix all failing tests
fix movetopendingreview action call breaking rspec
fix cancel buttons on confirm modal modification
initial push
renaming component and making the remove original issue button work
fixing issues related with closing the modal and addissues page getting prerendered
fixing spec failure
fixing spec and linter issues
adding spec test for approval and rejection
new branch withdrawal date
fixing bug and fixing the jest failure
addressing comments
fixing spec and linter failure
code clean and consistency between two modals
adding validation to the spec
fixing the spec failure
fixing spacing and spec
fixing linter

Co-authored-by: Jonathan Hoang trinhjoanthan.hoang@va.gov

Update schema.rb

Fix error in previous merge conflict attempt.

Update seeds.rb

Fix error in conflict resolution

TYLERB/APPEALS-40985: Frontend Submission of Requested Issues/Pending Admin Review Section (#21912)
Initial commit. Altered an existing model validation for issue modification requests and added a new validation. Added a formatter to prepare the issue modification requests for form submission and altered the button text for vha to be save instead of establish if there are pending issue modificaiton requests in the redux store.
Added the redirection code for claim reviews that have active pending issue modification requests. Also added the non admin issue modification success banner and refactored the existing flash banner code for other claim review types to make them easier to modify in the future.
Fixed code climate issue.
Renamed a function parameter in RequestIssueFormWrapper to make it more clear on what it is actually using. Updated logic to use a property insted of the form data.
Refactored how the claim review controller was building flash messaging to make it easier to customize it for vha claim reviews.
Added a new selectors file with a selector to only get openPendingModification requests which are pending modification requests that are assigned. Changed the selector in the PendingIssueModificationRequestBanner to the new selector.
Moved the open pending issue modification requests selector to the intake selector. Imported it and used it in the add issues page.
Fixed an issue where the decision date was not added as the correct string format to the issue modification redux store which was causing it to fail to save later after form submission. Expanded the feature test for non admin to include submitting the form and verifying the success banner and issue modification request data.
Added one more additional check to the feature test.
Added the open issue modification requests selector the save btton text for the edit issues page.
Made changes to the CancelPendingRequests modal to work with a new reducer. Added edited and cancelled pending requests to the formatIssueModificationRequestSubmissionData function.
Added an edited boolean attribute to the form data for modification type modals for pending requests for an easy way to determine if a issue modification request has been edited without changing the status.
Removed max width from non comp description text.
Fixed admin messaging when there are pending issue modification requests remaining on the claim review.
Added all the remaining frontend code and logic to make the issue modification form submission work. Fixed an issue where withdrawal date was not working correctly with the existing withdrawal process.
Refactored the claim review controller logic to work with the non admin and admin updates to issue modification requests. Added methods into issue modification request for admin updates. Updated validations. Refactored the non_admin_updater to work for both admin and non admin workflows. Added some fallback error handling for issue modification updates.
Removed unused import.
Updated the RequestIssueStatus component option value from rejected to denied to matchup with the enum field on the issue_modification_request model.
Fixed two code climate issues. Rewrote the issue modification request factories to fix the seed data.
Removed some lines from RequestIssueFormWrapper that I don't think were neccessary. Removed some todos.
Fixed a couple of failing specs.
Added a new feature test spec file that Praj created.
Added code to make the associations for request issues to issue modification requests through the UI work correctly in the request_issues_update model for additions and modifications since it is creating brand new request issues instead of using existing records in the database.
Renamed non_admin_updater_spec file and fixed tests.
Code climate fix.
Updated the mocked data controller tests.
Renamed the NonAdminUpdater and all related files to Updater.
Fixed a bug where the confirm pending request issue modal was not properly setting up the request issue by using the old request issue id that the modification request was associated to. Fixed a console warning in the RequestIssueStatus component.
Fixed spec failures due to changing banner text for editing vha claims.
Fixed an issue where the openPendingModificationRequests selector was causing a console error for legacy appeals due to different initialization of the redux store. Removed the no decision date banner for legacy appeals since it was never intended although it shouldn't happen.
Fixed jest test for CancelPendingRequestIssueModal where the property name had changed.
Added admin process testing to the updater_spec.rb service class for issue modification requests. Added errors to caseflow error.rb and added a constant to copy.json.
Removed todo statements.
Updated a modal snapshot.
Fixed merge conflicts that didn't get resolved.
Added an addition check for the wording to be correct for the issues update banner in add issues to properly reflect the wording of the save button at the bottom of the page depending on pending issue modification requests. Changed the wording on a success banner from established to edited that was incorrect. Added a different success banner for a vha claim review when it still has pending issue modification requests after an admin has only actioned some of them.
Updated the NonRatingIssueRequestModal decision date logic to prevent a non vha user from adding an issue without a decision date to a claim that was already in progress.
Fixed spec failures related to the banner text changes.
Added a banner and block the save of the page if the user is about to close a claim via a removal or withdrawal while the claim still has a pending addition issue modification request on it. Added feature test for this and uncommented some feature test code that shouldn't have been commented out. Added a way to make the content column span two columns in the add issues page table for styling the banner.
Moved the new banner check into the edit page block to fix tests.
CSS text change for the alert banner.
text change and text title change
Removed the established vha text variable in the claim review controller since it isn't being used anymore. Fixed a linting error.
test fix for alert title change

Co-authored-by: almorbah 149511814+almorbah@users.noreply.github.com
Co-authored-by: Prajwal Amatya pamatya@take2it.com
Co-authored-by: Robert Travis Pierce robert@roberttravispierce.com

Initial commit. Added a transaction wrapper around the update_admin_request updater service method to prevent partial processing of requests if an error occured during any of the processing. Added an if check to the claim review controller to make sure that the request issues update class can be processed before processing any of the approval issue modification requests to avoid processing the requests without modifying the request issues that are currently on the claim.
Added in code climate change and seed data change to match master.
Added a public method for request issues update to check for p
ossible errors before running the perform method. Refactored the controller logic to fix test failures.
Added approval back it got accidently removed. Removed some spacing in addissues.jsx.
Fixed a few flaky tests due to time errors.
Pamatya/appeals 49849 (#22057)
adding banner for both admin and non-admin and test
typo correction
removing commented out codes and adding a space between lines
removing props from the syntax
changing let to const

updated dispatch mailer email address to Decisions instead of Hearings (#22095)

Co-authored-by: Ron Wabukenda 130374706+ronwabVa@users.noreply.github.com

APPEALS-45631 Add and fix address (#21800)
APPEALS-45631 Add and fix address
empty commit
empty commit
fix/add RO id
changed id from SS to GB

Co-authored-by: Ron Wabukenda 130374706+ronwabVa@users.noreply.github.com

Prodtest/appeals-36234-appeals-44031 (#22109)
APPEALS-36339 (#21436)
Updated to remove obsolete levers of ACD Disable Legacy Distributions and ACD Disable Non-priority Distributions
Fixed redundant linting issue
Fixed empty line linting issue
Changed dockerfile to install node through NVM
Update env.sh with node 14.20 path
Removed unused node env
Update Dockerfile Removed unused node env variable
Removed unused node env
mbeard/APPEALS-44379 (#21451)
init commit
new questions about method
method for ready_appeals_from_levers 3rd iteration
switched to conditional
updates test and constants file
adds testing scenarios for edge cases
fixes test
adds constants to top of file

Co-authored-by: Amy Detwiler 133032208+amybids@users.noreply.github.com

APPEALS-44417 Seeds for Docket Lever Demo (#21534)

Co-authored-by: Christopher Detlef <>

APPEALS-36345-updated (#21537)
Refactored exclusion table
Fixed ordering issue and testing
mbeard/APPEALS-44379 (#21530)
init commit
new questions about method
method for ready_appeals_from_levers 3rd iteration
switched to conditional
updates test and constants file
adds testing scenarios for edge cases
fixes test
adds constants to top of file
first new commit with new args
updates methods and test query
updates age_of_oldest methods params
cleans up method removes args and updates tests, fixes linting

Co-authored-by: Amy Detwiler 133032208+amybids@users.noreply.github.com

APPEALS-44346 Demo Docket Goal Lever Test Seed Data (#21524)

Co-authored-by: Christopher Detlef <>

Chrisbdetlef/appeals 40705 (#21535)
Chris backend Work
APPEALS-44441. Added initial changes for individual seed
WIP
APPEALS-44441. Fixed the table css
APPEALS-44441. Added Custom and Scenario Seed components and jest tests
APPEALS-44441. Fix ScenarioSeeds jest test
APPEALS-44441. Fix CustomeSeeds Jest test
init commit
fixes linting issues
capybara test init
APPEALS-44441. Backend Integration API changes
APPEALS-44441_1. Matched the constant keys in the backend
APPEALS-44441_1. Update the param to match the backend and fixed spec
APPEALS-44441. lint fixes
APPEALS-44441. linting fixes
sharsha/APPEALS-44441. fixed the route and tests
Change route
Change variables to match front and back end
CustomSeed Jest test fix
Fix issues
Fix rubocop issues
Use existing method in the controller

Co-authored-by: Christopher Detlef <>
Co-authored-by: SHarshain spoosa@razortalent.com
Co-authored-by: Michael Beard michael.beard@va.gov
Co-authored-by: Amy Detwiler 133032208+amybids@users.noreply.github.com

Sharsha/appeals 45531 (#21566)
Fixed rspec failures on constants
APPEALS-45531. Remove dead code

Co-authored-by: SHarshain spoosa@razortalent.com

Updated lever history to handle null unit values from docket levers (#21567)

Co-authored-by: 631966 amy.detwiler@va.gov

Sharsha/appeals 45531_1 (#21573)
APPEALS-45531. Add the controller which is used in the route
APPEALS-45531. Fix lint issue
Remove access check for this iteration
APPEALS-45531. Fix lint issue in controller

Co-authored-by: SHarshain spoosa@razortalent.com
Co-authored-by: Christopher Detlef <>
Co-authored-by: Amy Detwiler 133032208+amybids@users.noreply.github.com

Sharsha/appeals 45531 1 (#21609)
APPEALS-45531. Add the controller which is used in the route
APPEALS-45531. Fix lint issue
Remove access check for this iteration
APPEALS-45531. Fix lint issue in controller
TEST FOR FIX
MORE TESTING
Fixed rspec issues

Co-authored-by: SHarshain spoosa@razortalent.com
Co-authored-by: Christopher Detlef <>
Co-authored-by: Amy Detwiler 133032208+amybids@users.noreply.github.com

APPEALS-45502. Organize route and fix the controller (#21595)

Co-authored-by: SHarshain spoosa@razortalent.com
Co-authored-by: Amy Detwiler 133032208+amybids@users.noreply.github.com

Ricky/APPEALS-36345.fixes (#21612)
Updated lever history to handle null unit values from docket levers
Updated member view of exclusion table with proper text display and fixed missing css
Updated unit test and test data to test rendering of exclusionTable

Co-authored-by: 631966 amy.detwiler@va.gov

ricky/APPEALS-44053 (#21587)
init commit, adds conditional to check for docket_type ama to method, fixes json constants to snakecase
puts statements testing
updates seeds for evidence_submission, adds method to hearing_request_docket.rb and dist_concern.rb
updated appeals dsit
final fix for PR
updates spec to reflect changes in hearing_request_docket
uncomments seeds
Ricky/appeals 43523 (#21649)
Added Assignment Queue link to Switch Users test page
Updated controller to validate role and redirect
Updated error information
Updated rspec tests

Co-authored-by: 631068 rickybmanus@gmail.com

APPEALS-45898. Updated the lever_group_order values (#21639)
APPEALS-45898. Updated the lever_group_order values
APPEALS-45898. Updated order of the evidence submission priority and non-priority

Co-authored-by: SHarshain spoosa@razortalent.com

mbeard/APPEALS-40646 (#21645)
Init commit
adds methods and useffect first pass
fixes isIdle warning
removes important from scss
refined handleToggleChange method
updates font color for h4
adds keys to the td and fixed proptype for loadAcdExcludeFromAffinity in casedistributionapp
Chrisbdetlef/appeals 43117.cleanup (#21671)
APPEALS-43421: Attorney Selection Sticking on Dropdown after Assignment (#21401)
redo init commit
updated imp. logic
attorney widget fix

Co-authored-by: Calvin Calvin.Costa@va.gov

Add ruby CE API Gem
remove correspondence changes from schema.rb (#21468)
Revert "Add ruby CE API Gem" (#21479)

This reverts commit c78afe3.

Override SCT Bulk Assign Page task limit (#21465)
Override SCT Bulk Assign Queue 15 case limit & Adjust SCT attorney assign task action label
feature/APPEALS-35707-29633-29632 (prodtest) (#21485)
🔀 Squash merge AlecK/APPEALS-35707 - Replace database_cleaner with database_cleaner-active_record
🔀 Squash merge jcroteau/APPEALS-29632-fix-deprecation-action-view-base-instances
🔀 Squash merge jcroteau/APPEALS-29633-fix-deprecation-warning-active_record-result-to_hash
feature/APPEALS-44871 Steps for installing node in the Caseflow demo environment (#21483) (#21484)
Changed dockerfile to install node through NVM
Update env.sh with node 14.20 path
Removed unused node env
Update Dockerfile Removed unused node env variable
Revert "feature/APPEALS-44871 Steps for installing node in the Caseflow demo …" (#21489)

This reverts commit a626200.

Sbashamoni/appeals 44871 node14 demo fixes (#21490) (#21495)
Changed dockerfile to install node through NVM
Update env.sh with node 14.20 path
Removed unused node env
Update Dockerfile Removed unused node env variable
Removed unused node env
add error rules to demo builds (#21496) (#21498)

Co-authored-by: davis-dwayne 47563178+davis-dwayne@users.noreply.github.com

APPEALS-43117 Add QA Users for testing
Fix rspecs
Fix issues with attorneys and judge teams
Fix org count

Co-authored-by: Isaiah Saucedo irsaucedo5@gmail.com
Co-authored-by: Calvin Calvin.Costa@va.gov
Co-authored-by: youfoundmanesh maneshreddy.kommidi@va.gov
Co-authored-by: Craig Reese 109101548+craigrva@users.noreply.github.com
Co-authored-by: Robert Travis Pierce robert@roberttravispierce.com
Co-authored-by: Jeremy Croteau jcroteau@users.noreply.github.com
Co-authored-by: sbashamoni 138054633+sbashamoni@users.noreply.github.com
Co-authored-by: davis-dwayne 47563178+davis-dwayne@users.noreply.github.com
Co-authored-by: Christopher Detlef <>

Minor fixes (#21694)
Minor fixes
Fix rspec tests and properly check for judge css id
Fix lint issue

Co-authored-by: Christopher Detlef <>

Fix Legacy Case issues (#21747)

Co-authored-by: Christopher Detlef <>

APPEALS-46037. Fix padding in the lever history table (#21725)
APPEALS-46037. Fix padding in the lever history table
APPEALS-46037. Fix lint issues

Co-authored-by: SHarshain spoosa@razortalent.com

Fix Lauren Roth issue (#21813)
Users with a VACOLS::Staff entry no longer get created with the default name of Lauren Roth

Co-authored-by: Christopher Detlef <>

ricky/APPEALS-44044 (#21814)
first pass at legacy_docket method and spec
second iteration of legacy_docket and spec
adds method to age_of_oldest methods and updates test scenarios
Updated testing and expanded method missing logic
Updated legacy_docket_spec file and tests
Updated boolean logic, updated rspecs and factories
Updated rspec tests to include factories
updates docket_spec line 317 and factory for disable_ama_non_priority_direct_review

Co-authored-by: Michael Beard michael.beard@va.gov

updates ready_priority_nonpriority_appeals to public_send, updates test (#21844)
APPEALS-36333 first iteration of docket time goal and prior to goal (#21523)
APPEALS-36333 first iteration of docket time goal and prior to goal
APPEALS-36333 address pr comments and moved the logic to docket model
APPEALS-36333 Added specs for docket and hearing request docket models
refactored code and moved it to distribution scopes
APPEALS-36333 address pr comments and refactor code
APPEALS-43996 updated lever name in all the required files to fix spec failures
APPEALS-44000 revert hearing request docket model changes to keept it in sync with feature
APPEALS-44000 updated hearing request docket model specs
APPEALS-44000 fixed jest tests
APPEALS-44000 fixed broken rspecs
APPEALS-43996 fix rubocop warnings
APPEALS-43996 fix push priority job spec failures
APPEALS-43996 Updated case distribution lever and docker model and refactor specs
APPEALS-43996 added rake task to update case distribution lever item in db
APPEALS-43996 update docket model to handle the scenario when the lever being disabled by a user via the UI
APPEALS-43996 update section title
APPEALS-43996 revert rake task
APPEALS-43996 add new factories to case distribution lever and fix spec failures
APPEALS-45191. Added columns to the appeals ready to distribute query and made some tweaks (#21834)
APPEALS-45191. Added columns to the appeals ready to distribute query and made some tweaks
APPEALS-45191. Refactor and fix lint issues

Co-authored-by: SHarshain spoosa@razortalent.com

refactor the logic and fix docket spec failures
changed the call times to 3 times
APPEALS-36333 fixed the docket time goal to check the existence of the item before using the public send to get the value

Co-authored-by: SHarshain 133917878+SHarshain@users.noreply.github.com
Co-authored-by: SHarshain spoosa@razortalent.com
Co-authored-by: 631966 amy.detwiler@va.gov

updated the seeds to align with the work completed
Updated Toggle Switch behavior when clicked while idle (#21874)
Csv research (#21892)
APPEALS-44911. Change the pure react components to functional components
APPEALS-44911. Redux implementation
APPEALS-44911. CSS changes for custom seed preview
APPEALS-44911. tweak css
csv and etc
CSS for buttons
jest tests for the reducer and action types
Jest test

Co-authored-by: SHarshain spoosa@razortalent.com
Co-authored-by: Amy Detwiler 133032208+amybids@users.noreply.github.com

APPEALS-46057. CleanUP (#21914)
more jest tests
Disable scenario seeds
Lint fixes
APPEALS-46057. disable all scenario seeds
APPEALS-46057. Refactor the TestSeed wrapper to be a functional component and fixed jest test
APPEALS-46057. Jest job in GHA complaining on test

Co-authored-by: SHarshain spoosa@razortalent.com

updates line of test to correctly build lever item (#21918)

Co-authored-by: Amy Detwiler 133032208+amybids@users.noreply.github.com

APPEALS-45191. Updated the query to return the date based on the calculation (#21928)
APPEALS-45191. Updated the query to return the date based on the calculation
APPEALS-45191. Lint fix

Co-authored-by: SHarshain spoosa@razortalent.com

Chrisharsha/appeals 43962 (#21929)
Sharsha/appeals-44911_1 (#21784)
APPEALS-44911. Change the pure react components to functional components
APPEALS-44911. Redux implementation
APPEALS-44911. CSS changes for custom seed preview
APPEALS-44911. tweak css

Co-authored-by: SHarshain spoosa@razortalent.com

Chrisbdetlef/appeals 44910 (#21838)
Initial
Add JSON parsing and multiple calls to rake tasks
Pre-caby tets
Add capybara tests and add IDs to buttons

Co-authored-by: Christopher Detlef <>

Co-authored-by: SHarshain spoosa@razortalent.com
Co-authored-by: cdetlefva 133903625+cdetlefva@users.noreply.github.com

APPEALS-43962. Lint fixes (#21932)

Co-authored-by: SHarshain spoosa@razortalent.com

Ricky/APPEALS-47293 (#21925)
First pass implementation of fixing seeding rspecs
Second pass at fixing errors in rspecs
Revert updates to test if rspec passes
Fixed linting issues in test_docket_seeds_controller_spec

Co-authored-by: Amy Detwiler 133032208+amybids@users.noreply.github.com

APPEALS-48292 updated the column to be a string (#21954)
APPEALS-48292 updated the column to be a string
APPEALS-48292 added comment to the control_group field in the migration
APPEALS-48292 added column comment to the schema, changed migration so that it can be rolled back
APPEALS-48598 fix logic when Start Distribution Prior to Docket Time Goal toggle is false (#21948)
APPEALS-48598 fix logic when Start Distribution Prior to Docket Time Goal toggle is false
APPEALS-49004 added spec to check when Start Distribution Prior to Docket Time Goal toggle is on
APPEALS-49004 fixed lint issues in docket.rb
APPEALS-48898. Created Distributable AMA Non-priority Appeals Query (#21949)
APPEALS-48898. Created Distributable AMA Non-priority Appeals Query
APPEALS-48898. Renamed the column and update the method

Co-authored-by: SHarshain spoosa@razortalent.com

APPEALS-49100. getting value from the start_distribution_prior_to_goal (#21968)

Co-authored-by: SHarshain spoosa@razortalent.com

mbeard/APPEALS-46257 (#21976)
updates routes and frontend urls to namespace
removes superfluous tags
Ensure that legacy appeals are being created (#21981)
Ensure that legacy appeals are being created
Remove puts

Co-authored-by: Christopher Detlef <>

APPEALS-49403. Added buttons Docket Lever Seed (#21989)
APPEALS-49403. Added buttons Docket Lever Seed
sharsha/APPEALS-49403. Updated the endpoint URL path
APPEALS-49403. Lint fix

Co-authored-by: SHarshain spoosa@razortalent.com

APPEALS-44000 added check to skip priority appeals in docket model (#21992)
Feature/appeals 36234 masterupgrade (#22003)
sbashamoni/APPEALS-43724 Node 16 version upgrade changes (#21966) (#21975)
Update node verstion to 16 in git workflow
Update node verstion to 16 in nvm and dockerfile for demo
Update node version in yarn.lock and package.json and .nvmrc file
Update node's version path to node16 in docker-bin/env.sh
Update and upgrade to node16 in client
More updates to yarn.lock and package.json
Fix tests by Adam Shaw
Upadate snapshot for ScheduleVeteran.test.js.snap
Doing some code clean up
Doiing some more clean up
Add and remove spaces to match master
One more space to take care of
One more space to take care of again
One more space to take care of again

Co-authored-by: ramon-chavez Ramon.Chavez@va.gov

init master merge branch

Co-authored-by: sbashamoni 138054633+sbashamoni@users.noreply.github.com
Co-authored-by: ramon-chavez Ramon.Chavez@va.gov

Remove AOD trait from non-priority legacy appeal creation (#22013)

Co-authored-by: Christopher Detlef <>

Sharsha/appeals 49461 (#22018)
sharsha/APPEALS-49461. initial commit
sharsha/APPEALS-49461. fix

Co-authored-by: SHarshain spoosa@razortalent.com

mbeard/APPEALS-49421 (#22014)
init commit fixes ama_np_ capybara test to expect user as admin, and first attempt test_docket_seeds test
removes previous chane for TASKS_LOADED
fixes capybara for test seeds controller button ids

Co-authored-by: Amy Detwiler 133032208+amybids@users.noreply.github.com

APPEALS-49403. Updated the buttons label (#22025)

Co-authored-by: SHarshain spoosa@razortalent.com

mbeard/APPEALS-49585 (#22020)
init commit for non member view input
fixes css issue for docket-lever-right
Added a hyphen between value and unit for member only view
replaces hyphen with comma
Init commit replaces th with div for 508 compliance (#22036)
Chrisbdetlef/appeals 47008 1 (#22040)
Allow judges to see legacy cases and attorneys to be assigned cases
Remove testing function
Update spec to reflect new user count in seed file

Co-authored-by: Christopher Detlef <>

got rid of extraneous file
got rid of yarn lock orig
Include bandwidth as part of timeout error metric data (#21946)
Include bandwidth as part of timeout error metric data
add NetworkUtil.js file
fix code climate issues
fix linting issue
remove safari webdriver test
fix CI/CD issue with chrome_driver
add tests for NetworkUtil.js
move bandwidth to metric_attributes
requested changes* fix NetworkUtil-test

Co-authored-by: mikefinneran 110622959+mikefinneran@users.noreply.github.com

APPEALS-50734. Remove Legacy appeals from the query (#22071)

Co-authored-by: SHarshain spoosa@razortalent.com

APPEALS-46087 fix css table width issues for case distribution lever history table (#22024)
Feature/appeals 36234.merge master.20240701 (#22075)
APPEALS-47277 remove Vegas office (#21876)
APPEALS-47277 remove Vagas office
Removed Texas ID from other files and updated tests
Snapshot update

Co-authored-by: Ron Wabukenda 130374706+ronwabVa@users.noreply.github.com
Co-authored-by: Raymond Hughes 131811099+raymond-hughes@users.noreply.github.com

hotfix/APPEALS-22403 (#21942)
add identifier for filenumber or ssn in filenumber search
linting
codeclimate linting
update match call to return boolean

Co-authored-by: Ron Wabukenda 130374706+ronwabVa@users.noreply.github.com
Co-authored-by: Raymond Hughes 131811099+raymond-hughes@users.noreply.github.com

APPEALS-46907: Update to Determination of Gen Pop Legacy Cases (#21986)
Isaiah/merge 46910 (#21983)
removed BFHINES checks and modified tests
removed lingering bfhines test
modified test
most recent updates on tests for passing status
removed refs to cavc updates
Skip flaky test ro_viewhearsched_spec

Co-authored-by: Isaiah Saucedo irsaucedo5@gmail.com

APPEALS-44916: Case Distribution Affinity Calculations (#21899)
APPEALS-44956: Add AppealAffinity model and database table (#21526)
add migration for appeal_affinities
add AppealAffinity model and associations, update migration for new column
update index to be unique
add factory, add tests
add factory traits to appeal and case for appeal affinities
add combination trait to appeal factory
add appeal_affinity to skipped associations in ETL reporting
add a validation, test
Craig/appeals 44958 (#21564)
add new job, update affinity model validation and after save hook
add update from push job
fix job extending distribution scopes
add with appeal affinities to distribution scopes
typo
add error handling, add test file
add distributed case factory, refactor naming in job
fix factories, added tests
fix migration for null affinity start date column
fixes, added tests
more test updates
add return in job if no query results, tests for no query results
add test for after_save hook adding dist task instructions
set start dist job to queue affinity job after running
fix update job and start dist job spec
queue affinity update job from push job
code clarity
fix judge in seed file
remove comment, fix hearing factory, disable some seeds for testing
add more tests
test refactor
update appeals for dist query to add affinity start, add seed file, fix hearing factory, add stat to dist factory
disable new seed on reset
update seed file with vet names, add another seed category
fix distirbuted case factory?
actually fix GHA runs
lint, test fixes
change constants in new job
APPEALS-44959: Modify affinity date checks to use appeal_affinity (#21611)
swap distribution queries from distribution_task to appeal_affinities
update seed files to use appeal affinities instead of distribution task
clean up seed file method names
add missing Timecop.return in ama affinity case seed
fix name of a method in a seed file
remove references to distribution task in distribution scopes
fix push priority job tests
fix naming of args in one of the seed files
fix user seed, fix date format in distribution task instructions
fix tests for date format update
Calvin/APPEALS-44957-rake-affinity (#21577)
grabbed receipt dates from distributed cases
refactored for functionality + added method to grab appeals that match
using receipt date, get all related appeals
added update/creation plus cleaned prior imple.
gets most recent distributed case receipt_date
skips if receipt_date is nil for performance
if appeal affinity is nil, it will now be updated
created spec file
fixed non ready appeals
updated query to match new AC
removing comment
testing for each docket
updated spec file
added new tests to rspec
updated start date to receipt date instead of Time.now
fixed date/time rspec errors
added rails logger to know when rake task has finished
added tag for rails log
removed nonpriority dockets for direct_review and evidence_submission
fixed lint issue
fixed flaky spec test
limits distributed cases query to within the last week
APPEALS-46016: Add Affinity Start Date to the Explain Page (#21660)
add affinity start date to explain page
add feature test to verify dates display
update rake task and spec (#21731)
APPEALS-46325: Add Seeds for AOD Appeals and Update Dates to Match CAVC (#21730)
add aod hearing cases to ama affinity cases seed
fix lever spec
APPEALS-45148: Hook to clear saved affinity date (#21623)
initial imp. idea
AC1: check for affinity_start_date on assignment
AC2/3: update affinity start date w/ instr.
updates to naming, instructions, and hook logic
updates after review
rspec coverage and addtional condition
removed unused identifier
removed reduntant 'self's
added update on actual AA record
updated to save aa record and addtional rspec
added change to assignment on no record test
check for assignment
addd update to 'on_hold' status
public method to handle legacy affinity appeals
added .reload to :with_affinity_appeal
added .reload to :ready_for_distribution
updates to pass explain_spec
switched boolean values
typo
readujsted order on :create for affinity appeal
removed after(:create)
testing rspec by readding after :create
reloading in assertation
addressing lint errors
fix seeds/users_spec
add case dist lever to new tests (#21776)
remove unnecessarily included module from job (#21827)
APPEALS-47211: Improve Performance of Distribution Queries (#21840)
rework ready_for_distribution scope
fix non-hearing docket distribution bug
restart tests
added null checks for appeal affinity in distribution queries, update tests (#21893)
add check for appeal being active to distribution and associated slack message (#21902)
Update users_spec.rb

Co-authored-by: calvincostaBAH 108481161+calvincostaBAH@users.noreply.github.com
Co-authored-by: Isaiah Saucedo irsaucedo5@gmail.com

hotfix/APPEALS-45177: TaskTable Default Sorting Fix (#21772)
Updated the TaskTable component to use the defaultSort property instead of the defaultSortIdx property for queue table since that property is not used anywhere. Added a default sorting hash to the UnassignedCasesPage component and now pass that down to TaskTable. Removed references to defaultSortIdx.
Added the type column default sort to the AssignedCasesPage widget as well.
Added a parenthesis for clarity around a boolean. Moved the defaultSortingHash out into a constants file.

Co-authored-by: Robert Travis Pierce robert@roberttravispierce.com

APPEALS-47106 Caseflow Swagger (#21993)
Add Rswag and convert existing API documentation (#21778)
add rswag
Update Gemfile.lock
Setup yaml UI
remove and reroute old swagger files
update format and servers values
Update route_docs_controller.rb
Update cmp_controller.rb
cmp endpoint yaml
cmp endpoint to return 501
CMP endpoint swagger flies
update swagger files
adjust server order, add auth token
cmp parameter name change
add comments
Update users_controller.rb
unit tests and linting
lint fixes
Update swagger_helper.rb
APPEALS-48048 Swagger Updates (#21909)
update servers to not include a host
remove host for server
remove generated swaggers from definitions
remove internal API endpoints from having generated swagger
IDT servers fixes
disable CMP swagger in prod and prodtest
set authorization correctly
fix what is required for CMP upload
fix linting issues, update lint rake task to autocorrect for rubocop, add rubocop make command
Update decision_reviews.yaml
Update ama_issues.yaml
Update vacols_issues.yaml
Update swagger.yaml
fix check failures
Update docs_controller_spec.rb
fix unit tests
Update fetch_all_active_legacy_appeals_job_spec.rb
Update rswag_ui.rb
Update lint.rake
Update decision_reviews_spec.rb
Update fetch_all_active_legacy_appeals_job_spec.rb
Update veterans_controller_spec.rb
feature/APPEALS-43597 RC1.5.1 (#21996)
APPEALS-36759 Add sms_response_content and sms_response_time notifications table
APPEALS-37003 First pass at job refactor
APPEALS-37003 Add comments and update kwargs for va notify service
APPEALS-37003 Update spec files
APPEALS-37003 Update spec
APPEALS-37003 Ensure user in job and create email_enabled method
APPEALS-37003 Remove question mark
Limit max retry attempts to 5
Add ? to boolen return methods
jcohen/APPEALS-43706 (#21444)
APPEALS-43706 macros added to each model file for the polymorphic relationship to be setup.
APPEALS-43706 migration made and yet to be run.
APPEALS-43706 migrations ran and expected columns and indexes are in table.
Fix some spec failures unrelated to this branch
Limit schema diff
Add a missing tab
Fix more unrelated failures. Also prevent ACD lever seeds from overwriting spec output
Fix last unrelated failure.
APPEALS-43706 linting issues in va_notify_service fixed.

Co-authored-by: Jonathan Cohen cohen_jonathan@bah.com
Co-authored-by: Matthew Thornton ThorntonMatthew@users.noreply.github.com

[APPEALS-43598] Quarterly Notification Job refactoring (#21505)
Quarterly Notification Job refactoring
APPEALS-43598 Fix lint issues for QuarterlyNotificationsJob refactor
APPEALS-43598 Fix db schema.rb file
APPEALS-43598 Fix schema.rb file
APPEALS-43598 Refactoring QuarterlyNotificationsJob for readability
APPEALS-43598 Refactoring QuarterlyNotificationsJob and removing extra methods
[APPEALS-43598] Update method name

Co-authored-by: Matthew Thornton 99351305+ThorntonMatthew@users.noreply.github.com

APPEALS-44007: Eliminate Transmission of Notifications to Deceased Veterans (#21481)
APPEALS-44007: Writing tests to ensure adding the 'failure due to deceased' information is properly set and added to the db
updates to pr
pushing changes for tonight
updating spec file to handle enabling and disabling feature flags
Update format_message_status
Lint roll
fixing conflicts
Updates to send notification spec
Fix one of the legacy test cases
Remove accidental push
Fix remaining test

Co-authored-by: Noah Hansen nhansen@Noahs-MacBook-Pro.local
Co-authored-by: Matthew Thornton ThorntonMatthew@users.noreply.github.com
Co-authored-by: Matthew Thornton 99351305+ThorntonMatthew@users.noreply.github.com

MattT/APPEALS-45235: Remove Temporary PDF Files From tmp Directory After All eFolder Upload Attempts (#21557)
Cleanup files after uploading to VBMS
Only delete file if it exists
Resolve linter issue
Update specs
Trigger CodeClimate

Co-authored-by: Matthew Thornton ThorntonMatthew@users.noreply.github.com

Add appeal alias for notifiable
APPEALS-45346: Populate Polymorphic Association Columns When Creating New Notifications (#21575)
APPEALS-45346: Populate Polymorphic Association Columns When Creating New Notifications
fixing some errors
updating factory
updating tests
updating tests and factory
rubocop

Co-authored-by: Noah Hansen nhansen@Noahs-MacBook-Pro.local
Co-authored-by: Matthew Thornton 99351305+ThorntonMatthew@users.noreply.github.com

APPEALS-43596 Adding JobMessageDeletionMiddleware to delete SQS messages for certain jobs
APPEALS-43596 Adding tests
APPEALS-43596 Fix codeclimate
APPEALS-43714: Refactor VANotify Modules to Not Rely on Class Variables (#21596)
APPEALS-43714: Refactor VANotify Modules to Not Rely on Class Variables
pushing changes
updating…

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deployed/20240712_173602

Commit: `5fbafad`

Commit: `67e62f3`

Commit: `35aa3b0`

deployed/20240712_173602

Commit: 5fbafad

Commit: 67e62f3

Commit: 35aa3b0

Commit: `5fbafad`

Commit: `67e62f3`

Commit: `35aa3b0`