Skip to content

deployed/20240812_211335

Compare
Choose a tag to compare
@va-bot va-bot released this 12 Aug 21:13
e5563b2

Commit: e5563b2

Merge pull request #22387 from department-of-veterans-affairs/release/FY24Q4.2.0

Release R2.2.0 FY24Q4.2.0


Commit: 02ccda9

Revert "Feature/appeals 43179 (#21665)" (#22425)

This reverts commit 7613209.


Commit: 848c62a

Revert "Updates key on line 63 to the correct value. (#22267)" (#22417)

This reverts commit def10f5.


Commit: d26fbc5

consolidate individual RO accessors into a single test for each RO (#22407)


Commit: 05fa7e8

Hotfix/appeals-42846 Fixes incorrect spelling of SupervisorySeniorCounsel across project (#22391)

  • Repushing branch to fix CodeClimate and Rspec issue

  • Attempt to fix failed Rspec.

  • Revert Schema changes


Co-authored-by: Ron Wabukenda 130374706+ronwabVa@users.noreply.github.com


Commit: def10f5

Updates key on line 63 to the correct value. (#22267)

Co-authored-by: Ron Wabukenda 130374706+ronwabVa@users.noreply.github.com


Commit: 3eb4db5

Hotfix/appeals 46639 prodtest (#22389)

  • Initial commit and turning off queue tab variables used for the frontend pagination for the bulk assign tab for the specialty case team.

  • Altered the queue actions to work with the new task selection action and a new redux action to remove tasks from a cached queue state. Also updated queue table to work with the redux caching instead of local state caching.

  • Added in task selection function changes to TaskTable to work
    with the altered task selection redux action. Also added the ability to pass down the redux cache property to queue table. Refactored the UnassignedCasesPage to allow for backend pagination of queue table instead of only working via frontend loaded data from the redux store.

  • Added the queueTableCache reducer slice. Added a :advanced_on_docket trait to the task factory for specialty_case_team_assign_tasks. Added the caching combined reducer to the queue table reducers.

  • Moved columnsFromConfig and createColumnObject functions out of QueueTableBuilder.jsx into a utils file so it can be used in multiple components around the app.

  • Updated the setSelectionOfTaskOfUser to work with the new action and data that it should be expecting.

  • Updated the selectedTasksSelector to work with the new task selection reducer and action.

  • Added a parameter for useReduxCache for TaskTable to send down to queue table instead of always setting it to true. Removed some comments from the queueTableCacheSlice removeTaskIdsFromCache reducer method/action. Passed in the new useReduxCache property to TaskTable in the UnassignedCasesPage component for the sct bulk assign queue.

  • Removed code out of QueueTableBuilder that is now in queueTableUtils.js.

  • Fixed a bug if queueConfig was an empty hash in the UnassignedCasesPage component.

  • Serializer optimizations for contested issues and issue categories. Also included request issues in the includes for the sct queue to take advantage of these optimizations.

  • Fixed a bug where clear filters was not properly updating the get parameters anymore for queue table.

  • Added cavc_type trait to the sct assign task factory.

  • Fix code climate issues.


Co-authored-by: = tyler.broyles@va.gov


Commit: 365948e

APPEALS-46266, APPEALS-46239: ACD Stats and Slack message updates (#22388)

  • APPEALS-42221 Distribution Stats: Break statistics into columns (#21717)

  • rebuild branch

  • Create 20240506140249_add_cols_to_distribution_stats.rb

  • unit tests and linting

  • APPEALS-46244, APPEALS-46245 (#22077)

  • remove unnecessary reporting

  • send slack message to console if on local or demo

  • add excluded judges to slack report

  • reporting method cleanup

  • added affinity date stats to distribution_stats for each docket

  • Update docket.rb

  • Update distribution_scopes.rb

  • unit tests and linting

  • unit tests and linting

  • Slack message update

  • Update push_priority_appeals_to_judges_job.rb

  • Update push_priority_appeals_to_judges_job_spec.rb

  • code climate and code review changes (#22148)

  • code climate and code review changes

  • move code out to its own class

  • lint fixes

  • revert

  • disable reek checks

  • fix method calls


Commit: 7613209

Feature/appeals 43179 (#21665)

  • Calvin/APPEALS-43852-cavc-levers (#21441)

  • enabled cavc affinity levers in UI

  • updated rspec

  • [APPEALS-43849]Update CAVC Affinity Implementation for AMA Dockets to… (#21456)

  • [APPEALS-43849]Update CAVC Affinity Implementation for AMA Dockets to Account for Omit/Infinity

  • Affinity rules applied to non genpop

  • Addressed comments

  • Addressed comments

  • fixed rubocop issues + added clarity to where clause


Co-authored-by: Calvin Calvin.Costa@va.gov

  • APPEALS-44956: Add AppealAffinity model and database table (#21526)

  • add migration for appeal_affinities

  • add AppealAffinity model and associations, update migration for new column

  • update index to be unique

  • add factory, add tests

  • add factory traits to appeal and case for appeal affinities

  • add combination trait to appeal factory

  • add appeal_affinity to skipped associations in ETL reporting

  • add a validation, test

  • Craig/appeals 44958 (#21564)

  • add new job, update affinity model validation and after save hook

  • add update from push job

  • fix job extending distribution scopes

  • add with appeal affinities to distribution scopes

  • typo

  • add error handling, add test file

  • add distributed case factory, refactor naming in job

  • fix factories, added tests

  • fix migration for null affinity start date column

  • fixes, added tests

  • more test updates

  • add return in job if no query results, tests for no query results

  • add test for after_save hook adding dist task instructions

  • set start dist job to queue affinity job after running

  • fix update job and start dist job spec

  • queue affinity update job from push job

  • code clarity

  • fix judge in seed file

  • remove comment, fix hearing factory, disable some seeds for testing

  • add more tests

  • test refactor

  • update appeals for dist query to add affinity start, add seed file, fix hearing factory, add stat to dist factory

  • disable new seed on reset

  • update seed file with vet names, add another seed category

  • fix distirbuted case factory?

  • actually fix GHA runs

  • lint, test fixes

  • change constants in new job

  • [Appeals 43850] Update Legacy Docket Queries to Account for the Previous Decision Judge and Type Action (#21556)

  • test changes for seans ticket

  • test changes

  • added joins to all required methods

  • fixed lint

  • fixed column ambiguity errors

  • cleaned up naming scheme

  • Documentation for JOIN_PREVIOUS_APPEALS constant


Co-authored-by: Calvin Calvin.Costa@va.gov

  • APPEALS-44959: Modify affinity date checks to use appeal_affinity (#21611)

  • swap distribution queries from distribution_task to appeal_affinities

  • update seed files to use appeal affinities instead of distribution task

  • clean up seed file method names

  • add missing Timecop.return in ama affinity case seed

  • fix name of a method in a seed file

  • remove references to distribution task in distribution scopes

  • fix push priority job tests

  • fix naming of args in one of the seed files

  • fix user seed, fix date format in distribution task instructions

  • fix tests for date format update

  • APPEALS-44187: Factory Bot Additions (#21438)

  • AC1: values for bfddec and bfmpro

  • AC2: case issues updated to '3'

  • AC3-4: attorney and judge additions

  • ac 5: bfdpdcn addition

  • AC6: case type action addition

  • ac7: new folder match to original

  • ac8: case issues set to original

  • AC 3/4: added associations to original

  • ac3/4: updated logic to handle no args

  • ac3/4: return sattyid

  • ac7:updating folder assignment

  • ac7: added bfkey to except block

  • ac7/8: update to case issue list and validations dismissed

  • removed byebug

  • ac7: added 'ticknum' to except

  • lint fixes

  • lint fixes

  • lint fixes

  • lint fixes

  • nested trait into form_9 factory

  • new addtions

  • added .save to case issues

  • resolving correspondent and titrnum associations

  • fixed bfdc typo

  • factory additions

  • added ssn to associated corr.

  • removed transient and added .save

  • added after create to corr factory

  • veteran lookup check prior to create

  • committing missed 'end'

  • moved over veteran create to case fact.

  • move corr. association field to case fact.

  • lint issues + corres. save

  • Calvin/APPEALS-44957-rake-affinity (#21577)

  • grabbed receipt dates from distributed cases

  • refactored for functionality + added method to grab appeals that match

  • using receipt date, get all related appeals

  • added update/creation plus cleaned prior imple.

  • gets most recent distributed case receipt_date

  • skips if receipt_date is nil for performance

  • if appeal affinity is nil, it will now be updated

  • created spec file

  • fixed non ready appeals

  • updated query to match new AC

  • removing comment

  • testing for each docket

  • updated spec file

  • added new tests to rspec

  • updated start date to receipt date instead of Time.now

  • fixed date/time rspec errors

  • added rails logger to know when rake task has finished

  • added tag for rails log

  • removed nonpriority dockets for direct_review and evidence_submission

  • fixed lint issue

  • fixed flaky spec test

  • limits distributed cases query to within the last week

  • APPEALS-46016: Add Affinity Start Date to the Explain Page (#21660)

  • add affinity start date to explain page

  • add feature test to verify dates display

  • Sudhir/appeals 43851 (#21613)

  • Implement CAVC + AOD Affinity Lever for AMA Dockets

  • addressed comments

  • addressed comments

  • Addressed comments

  • added cavc_aod_affinity in case distribution lever model

  • addressed comments

  • addressed comments

  • updated specs

  • Updated specs

  • specs changes reverted

  • ama_aod and ama_non_aod queries updated

  • change the assertion in docket spec

  • Craig/appeals 46196 (#21689)

  • fix query, tested locally

  • add basic test to verify csv downloads aren't broken

  • APPEALS-43851: Add test to validate CAVC+AOD behavior on hearing docket appeals affinities (#21678)

  • add test to validate cavc+aod on hearing docket appeals

  • lint, test case_docket_spec fix

  • modify case_docket_spec again

  • more test fix testing

  • attempt to fix test again

  • test removing prev appeals from nonpriority queries

  • more test tests

  • feature toggle change in test

  • reorder new portions of query

  • remove unused portions of queries in case_docket

  • revert unneeded change to query order

  • revert unneeded change to query order

  • update rake task and spec (#21731)

  • APPEALS-46325: Add Seeds for AOD Appeals and Update Dates to Match CAVC (#21730)

  • add aod hearing cases to ama affinity cases seed

  • fix lever spec

  • APPEALS-45148: Hook to clear saved affinity date (#21623)

  • initial imp. idea

  • AC1: check for affinity_start_date on assignment

  • AC2/3: update affinity start date w/ instr.

  • updates to naming, instructions, and hook logic

  • updates after review

  • rspec coverage and addtional condition

  • removed unused identifier

  • removed reduntant 'self's

  • added update on actual AA record

  • updated to save aa record and addtional rspec

  • added change to assignment on no record test

  • check for assignment

  • addd update to 'on_hold' status

  • public method to handle legacy affinity appeals

  • added .reload to :with_affinity_appeal

  • added .reload to :ready_for_distribution

  • updates to pass explain_spec

  • switched boolean values

  • typo

  • readujsted order on :create for affinity appeal

  • removed after(:create)

  • testing rspec by readding after :create

  • reloading in assertation

  • addressing lint errors

  • fix seeds/users_spec

  • add case dist lever to new tests (#21776)

  • fix tests, add lever to factory, fix dist scopes (#21779)

  • fix rubocop warning

  • Acd/appeals 43853 43854 (#21971)

  • Calvin/appeals 43853 (#21723)

  • initial updates

  • removing unnecessary variable

  • focused in on priority

  • removing non priority stuff

  • added general comments

  • added BFAC and AOD to cavc aod lever query

  • adding judge vacols id to query

  • aod affinity_start_date filter initial changes

  • fixed sorting

  • fixed rubocop issues

  • updated filter method

  • error handling

  • added ineligibility to queries for PREV_DECIDING_JUDGE

  • fixed SQL query + added comments

  • added exclude from affinity check into the case docket queries

  • error handling + fixing sql queries

  • rejects appeals without affinity_start_dates and nonmatching judges

  • fixing rubocop offenses

  • fixed inconsistencies between methods

  • fixed conditions for rejecting appeals

  • refactored cavc aod affinity filter to make it much easier to read

  • refactored code to account for AC6

  • error handling for empty exclude from affinity

  • reverted next if block to old logic to ensure it works

  • added PREV_DEC_JUDGE is not null

  • case.rb factory changes

  • added more options to legacy_cavc_appeal creation

  • cleaned up code for simpler reading

  • fix for aod legacy cavc creation

  • added tied to option to legacy cavc appeal factory

  • limits are now handled correctly in query

  • replaced return false to next if, as return false was causing unexpected behavior

  • fix rspecs + one edge case

  • added cavc aod lever creation to rspecs

  • removed bfac and aod from nonpriority query

  • cavc aod appeals w/excluded judges are now properly being filtered

  • refactored excluded judges check

  • added to old query to fix rspec errors

  • modified case factory bot

  • query now handles when prev_deciding_judge is nil

  • removed unnecessary condition

  • fixed case factory to now have tied_to attatched to orig appeal

  • fixed next if block within filter

  • handles omit scenarios + correctly rejects with next

  • working on rspec (still failing)

  • fix for ineligble VLJ when infinite

  • fixed rspec suite for cavc aod filters

  • fixed omit scenario in cavc aod affinity filter

  • consolidation & readability refactor

  • rubocop fixes

  • fixed spec error

  • Implement CAVC Affinity for Legacy Docket (#21706)

  • Implement CAVC Affinity for Legacy Docket

  • addressed comments

  • Added BFAC in the query

  • code changes for affinitty date

  • Added affinity code

  • code refactor and removed non priority code changes

  • fixed syntax change

  • Addressed comments

  • refactor cavc affinity filter

  • refactored code

  • code refactor

  • code refactor

  • Updated existing specs

  • code refactor

  • Added new rspecs

  • code refactor and added test cases

  • code refactor

  • added test cases

  • fixes push_priority_spec

  • fixed rubocop issues

  • rubocop issue fixed

  • refactored code to make it easier to understand

  • refactored + fixed rspec and lint errors


Co-authored-by: Calvin Calvin.Costa@va.gov
Co-authored-by: calvincostaBAH 108481161+calvincostaBAH@users.noreply.github.com

  • basic creation of legacy affinity cases seed data

  • bug fixes, added bfcorlid with veterans, fully runs now

  • added new appeals for affinity_and_tied_to_judge

  • made data have realistic bfcorlids

  • changes document sequence to use less digits

  • added new file numbers for tied_to cases to make them easier to identify


Co-authored-by: samasudhirreddy 108430298+samasudhirreddy@users.noreply.github.com

  • APPEALS-50692: Update Appeals Ready to Distribute CSV to include CAVC remand original judge (#22070)

  • CSV download functional

  • add tests, fix CSV query in CaseDocket

  • fix lint

  • Calvin/appeals 44313 (#22119)

  • initial seed data file

  • added legacy cavc and cavc aod affinity cases

  • update

  • fixed tied to for legacy appeals

  • added AOD versions of appeals

  • small lint fixes

  • ensured AOD cases for legacy hearings with exluded or ineligible judge

  • added vacols staff record creation for users without it

  • APPEALS-47741: Update the UpdateAppealAffinityDatesJob to add appeal_affinity records for Legacy Appeals (#22023)

  • AC1: changes and respective tests

  • adjustements after refactoring

  • identifier mismatch

  • name update

  • name update

  • added appeal affinity filter

  • updated comment

  • remove byebug

  • update rspec to handle hash input

  • added no start date test case

  • updated process method test

  • removed 'todo' comment

  • dried up query string

  • aligned conditions

  • update to hash quotations

  • update to hash quotations

  • added legacy to priority receipt dates from dist.

  • moved append to resulting list

  • added legacy receipt date to push job hash

  • uncomment call to legacy

  • updated dist.id to @dist_id

  • uncomment call to process legacy appeals

  • handling update to legacy docket type

  • current rspec status

  • fixed typo

  • fix rspec

  • legacy spec additions

  • legacy spec additions

  • added legacy dist. case factory

  • removed vacols_judge ref

  • updates for spec

  • final review

  • removed comment

  • rubocop fixes

  • fix rubocop warnings (#22225)

  • Fix rubocop and tests (#22231)

  • Calvin/appeals 52551 (#22293)

  • age_of_n_oldest_priority_appeals_available_to_judge time out changes

  • fixed timeout issue for distribute_priority_appeals

  • fixed lint errors

  • Craig/case docket optimization (#22294)

  • age_of_n_oldest_priority_appeals_available_to_judge time out changes

  • fixed timeout issue for distribute_priority_appeals

  • optimize case docket priority distribution methods

  • fix das deprecation distribution spec


Co-authored-by: Calvin Calvin.Costa@va.gov

  • Update admin_ui_spec.rb for CAVC levers being enabled

Co-authored-by: calvincostaBAH 108481161+calvincostaBAH@users.noreply.github.com
Co-authored-by: samasudhirreddy 108430298+samasudhirreddy@users.noreply.github.com
Co-authored-by: Calvin Calvin.Costa@va.gov
Co-authored-by: seanrpa 155660052+seanrpa@users.noreply.github.com
Co-authored-by: Isaiah Saucedo irsaucedo5@gmail.com


Commit: 3367fbe

APPEALS-53151: Update ECR Workflow to Utilize OIDC Flow (#22348)

  • Reconfigure ECR login workflow to utilize Github's OIDC flow

  • Add permissions

  • Update AWS account number to one for VAEC

  • Update account number for main CI workflow

  • Try using a separate secret in test

  • Try using a separate secret in test

  • Change name of secret


Co-authored-by: Matthew Thornton ThorntonMatthew@users.noreply.github.com