-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add silent_failure_avoided_no_confirmation StatsD for Simple Forms #19035
Draft
Thrillberg
wants to merge
3
commits into
master
Choose a base branch
from
start-tracking-silent_failure_avoided_no_confirmation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add silent_failure_avoided_no_confirmation StatsD for Simple Forms #19035
Thrillberg
wants to merge
3
commits into
master
from
start-tracking-silent_failure_avoided_no_confirmation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
require-backend-approval
test-failure
and removed
require-backend-approval
labels
Oct 23, 2024
freeheeling
reviewed
Oct 23, 2024
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Oct 23, 2024
rhasselle-oddball
approved these changes
Oct 24, 2024
github-actions
bot
added
require-backend-approval
ready-for-backend-review
and removed
require-backend-approval
test-passing
labels
Oct 24, 2024
rmtolmach
reviewed
Oct 24, 2024
}) | ||
simple_forms_enqueue_result_email(:error) | ||
tags = ['service:veteran-facing-forms', "function:#{form_type} form submission to Lighthouse"] | ||
StatsD.increment('silent_failure_avoided_no_confirmation', tags:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there tests you can update based on these additions?
Possibly related: your specs have failed twice after timing out after 20 min :/
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
ready-for-backend-review
labels
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Start tracking
silent_failure_avoided_no_confirmation
for Simple Forms.Related issue(s)
https://github.com/orgs/department-of-veterans-affairs/projects/1443/views/3?sliceBy%5Bvalue%5D=Thrillberg&pane=issue&itemId=83779293&issue=department-of-veterans-affairs%7CVA.gov-team-forms%7C1759