Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add silent_failure_avoided_no_confirmation StatsD for Simple Forms #19035

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add silent_failure_avoided_no_confirmation StatsD for Simple Forms #19035

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da70422
Add silent_failure_avoided_no_confirmation StatsD for Simple Forms
Thrillberg Oct 23, 2024
02cc928
small fix
Thrillberg Oct 23, 2024
efe4899
Merge branch 'master' into start-tracking-silent_failure_avoided_no_c…
Thrillberg Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/models/form_submission_attempt.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,16 @@ class FormSubmissionAttempt < ApplicationRecord
event :fail do
after do
if should_send_simple_forms_email
form_type = form_submission.form_type
Rails.logger.info({
message: 'Preparing to send Form Submission Attempt error email',
form_submission_id:,
benefits_intake_uuid: form_submission.benefits_intake_uuid,
form_type: form_submission.form_type
form_type:
})
simple_forms_enqueue_result_email(:error)
tags = ['service:veteran-facing-forms', "function:#{form_type} form submission to Lighthouse"]
StatsD.increment('silent_failure_avoided_no_confirmation', tags:)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there tests you can update based on these additions?

Possibly related: your specs have failed twice after timing out after 20 min :/

end
end

Expand Down
Loading