Refactor automatic update flow to use custom Sparkle user driver #3274

quanganhdo · 2024-09-13T19:08:20Z

Task/Issue URL: https://app.asana.com/0/1201037661562251/1208183525704010/f
Tech Design URL:
CC:

Description:

Refactors automatic update flow to use a custom Sparkle user driver.

Steps to test this PR:

Refer to https://app.asana.com/0/1201037661562251/1208230039908704/f

Definition of Done:

Does this PR satisfy our Definition of Done?

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

quanganhdo · 2024-09-13T19:08:42Z

Refactor automatic update flow to use custom Sparkle user driver #3274 : 3 dependent PRs (#3275 , #3344 , #3411 ) 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @quanganhdo and the rest of your teammates on Graphite

github-actions · 2024-09-13T19:09:57Z

	Warnings
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

	Messages
📖	You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against bdc7a75

tomasstrba

The code looks really good. 💯 I'm going to test the solution now

DuckDuckGo/Preferences/Model/AboutPreferences.swift

tomasstrba · 2024-09-18T07:36:38Z

DuckDuckGo/Updates/UpdateController.swift

-    func checkForUpdate() {
+    func checkForUpdateIfNeeded() {
+        guard let updater, !updater.sessionInProgress else { return }
+
        Logger.updates.debug("Checking for updates")


There was a mistake when refactoring pixels and all update pixels are just debug pixels. Do you think it would be beneficial to make them available in release builds for potential debugging?

It may be beneficial to have pixels at different states to see if our users make it to the end of the update cycle. Have we defined those, or do they have to be created?

There are couple of pixels and the error pixel in case something goes wrong. Monitoring various states as you suggested may be a good idea too 👍

tomasstrba

@quanganhdo, after installation of the build number 261, it says the app is up to date which is not expected. Am I missing something? I'm currently at the coffee shop with a low connection or maybe the phased rollout is the reason?

Another minor thing is the empty box in the release notes which I suppose is caused by empty release notes in the appcast. Just flagging it in case not.

quanganhdo · 2024-09-18T13:43:41Z

The test appcast pointed to internal-channel so internal user state was needed https://github.com/quanganhdo/playground/blob/main/appcast2.xml

I've removed that channel from the file. Update should show up now (along with the release note).

tomasstrba

LGMT! 👍 Works as expected including edge cases

github-actions · 2024-10-03T00:00:35Z

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

This reverts commit c165e74. # Conflicts: # DuckDuckGo/Updates/BinaryOwnershipChecker.swift # DuckDuckGo/Updates/UpdateController.swift

…ere UI stuck loading when switching between browser update modes

…'s due based on SULastCheckTime

…RL (to be reverted) This reverts commit e1deee3.

Task/Issue URL: https://app.asana.com/0/1201037661562251/1208183525704010/f Tech Design URL: CC: Figma: https://www.figma.com/design/vDBpSFDzW0eN7nwpS95gju/macOS-update-process?node-id=2359-52971&t=KnvIdm2f7PRjNwfK-4 **Description**: **Steps to test this PR**: 1. Change the appcast URL to an invalid URL to test the error state 2. Play with different update options to see if update works  **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)

quanganhdo changed the title ~~Revert "Resolving automatic update edge cases (#3142)"~~ Refactor automatic update flow to use custom Sparkle user driver Sep 13, 2024

quanganhdo marked this pull request as ready for review September 13, 2024 19:10

This was referenced Sep 13, 2024

Use test appcast URL #3275

Closed

Increase build number to 265 #3276

Closed

quanganhdo force-pushed the anh/refactor/sparkle-user-driver branch 2 times, most recently from 1a1d4e6 to ccfe27b Compare September 16, 2024 15:34

quanganhdo requested review from tomasstrba and ayoy September 16, 2024 15:37

tomasstrba reviewed Sep 18, 2024

View reviewed changes

quanganhdo requested a review from tomasstrba September 18, 2024 21:18

tomasstrba approved these changes Sep 19, 2024

View reviewed changes

quanganhdo added the DO NOT MERGE label Sep 20, 2024

quanganhdo force-pushed the anh/refactor/sparkle-user-driver branch from ccfe27b to 3f91338 Compare September 25, 2024 15:11

quanganhdo mentioned this pull request Sep 25, 2024

Design improvements to automatic update flow #3344

Merged

1 task

github-actions bot added the stale label Oct 3, 2024

quanganhdo force-pushed the anh/refactor/sparkle-user-driver branch from 7884731 to 0fcc157 Compare October 7, 2024 14:28

github-actions bot removed the stale label Oct 8, 2024

quanganhdo force-pushed the anh/refactor/sparkle-user-driver branch from 0fcc157 to 7166bc1 Compare October 10, 2024 15:37

quanganhdo force-pushed the anh/refactor/sparkle-user-driver branch from 7166bc1 to 4130eff Compare October 17, 2024 20:02

quanganhdo mentioned this pull request Oct 17, 2024

Connect refactored update flow to the new release notes page #3411

Open

1 task

quanganhdo added 5 commits October 18, 2024 10:55

Revert "Resolving automatic update edge cases (#3142)"

574ab13

This reverts commit c165e74. # Conflicts: # DuckDuckGo/Updates/BinaryOwnershipChecker.swift # DuckDuckGo/Updates/UpdateController.swift

UpdateUserDriver draft

a5ecfce

Refactor UpdateState to show progress

af16a18

Fix wrong deferInstallation param

7bce020

Show update progress

b227375

quanganhdo and others added 29 commits October 18, 2024 10:55

Refactor updateProgress

1adf8b3

Minor refactoring

73c4daf

Reintroduce cached result

21a9710

Refactor new version check for UI

9943227

Fix overaggressive updater reconfiguration

6bd72d6

Fix release note tab state

7b09024

Different checkpoints for different update options

479b28d

Remove unnecessary code

9a4d060

Disable update mode switching if session is in progress

aaa2304

Rename isNewVersionAvailable to hasPendingUpdate and fix edge case wh…

8dd0c50

…ere UI stuck loading when switching between browser update modes

Fix stuck hasPendingStatus

2d49b14

Check for update upon starting the app

2ddb68f

Simplify user driver

f28f4e3

Dot goes away when menu opens

eae15e8

Add setNeedsDisplay

3da45e5

Add shouldShowUpdateNotification logic

adc04d5

Check for update when release note / about page is loaded and when it…

1f3c6ff

…'s due based on SULastCheckTime

Fix stuck state when switching between modes

049d829

Add DEBUG check

9061ba3

Avoid overlapping popup

1a52a17

Code cleanup

81e001d

Update copy

2a15a3c

Fix last checked date showing - when idling

077add9

Revert "Increase build number (to be reverted)" and update appcast2 U…

655b53e

…RL (to be reverted) This reverts commit e1deee3.

Oops, wrong URL

0ba11ed

Revert browserRestart behaviour and undo debug changes

a950d14

Fix swiftlint

67cb390

Add missing SPARKLE checks

78e08d0

quanganhdo force-pushed the anh/refactor/sparkle-user-driver branch from 4130eff to bdc7a75 Compare October 18, 2024 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor automatic update flow to use custom Sparkle user driver #3274

Refactor automatic update flow to use custom Sparkle user driver #3274

quanganhdo commented Sep 13, 2024 •

edited

Loading

quanganhdo commented Sep 13, 2024 •

edited

Loading

github-actions bot commented Sep 13, 2024 •

edited

Loading

tomasstrba left a comment

tomasstrba Sep 18, 2024

quanganhdo Sep 18, 2024

tomasstrba Sep 19, 2024

tomasstrba left a comment

quanganhdo commented Sep 18, 2024 •

edited

Loading

tomasstrba left a comment

github-actions bot commented Oct 3, 2024

Refactor automatic update flow to use custom Sparkle user driver #3274

Are you sure you want to change the base?

Refactor automatic update flow to use custom Sparkle user driver #3274

Conversation

quanganhdo commented Sep 13, 2024 • edited Loading

Internal references:

quanganhdo commented Sep 13, 2024 • edited Loading

github-actions bot commented Sep 13, 2024 • edited Loading

tomasstrba left a comment

Choose a reason for hiding this comment

tomasstrba Sep 18, 2024

Choose a reason for hiding this comment

quanganhdo Sep 18, 2024

Choose a reason for hiding this comment

tomasstrba Sep 19, 2024

Choose a reason for hiding this comment

tomasstrba left a comment

Choose a reason for hiding this comment

quanganhdo commented Sep 18, 2024 • edited Loading

tomasstrba left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 3, 2024

quanganhdo commented Sep 13, 2024 •

edited

Loading

quanganhdo commented Sep 13, 2024 •

edited

Loading

github-actions bot commented Sep 13, 2024 •

edited

Loading

quanganhdo commented Sep 18, 2024 •

edited

Loading