Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor automatic update flow to use custom Sparkle user driver #3274

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Refactor automatic update flow to use custom Sparkle user driver #3274

wants to merge 45 commits into from

Commits on Oct 18, 2024

  1. Revert "Resolving automatic update edge cases (#3142)" 

    This reverts commit c165e74.

# Conflicts:
#	DuckDuckGo/Updates/BinaryOwnershipChecker.swift
#	DuckDuckGo/Updates/UpdateController.swift
    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    574ab13 View commit details
    Browse the repository at this point in the history

  2. UpdateUserDriver draft

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    a5ecfce View commit details
    Browse the repository at this point in the history

  3. Refactor UpdateState to show progress

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    af16a18 View commit details
    Browse the repository at this point in the history

  4. Fix wrong deferInstallation param

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7bce020 View commit details
    Browse the repository at this point in the history

  5. Show update progress

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b227375 View commit details
    Browse the repository at this point in the history

  6. Add manual restart

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7da7531 View commit details
    Browse the repository at this point in the history

  7. Rename delegate methods

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    dfe308b View commit details
    Browse the repository at this point in the history

  8. Remove AppRestarter

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    21c5778 View commit details
    Browse the repository at this point in the history

  9. Fix updateCycleDone state

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c060a2e View commit details
    Browse the repository at this point in the history

  10. Remove shouldShowManualUpdateDialog

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0e46de1 View commit details
    Browse the repository at this point in the history

  11. Simplify the states (double check needed)

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    a778118 View commit details
    Browse the repository at this point in the history

  12. Add more logging, tweak last check date

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    50a2616 View commit details
    Browse the repository at this point in the history

  13. Refactor updateCycleDone state

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4222672 View commit details
    Browse the repository at this point in the history

  14. Move from delegate method to Combine

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6d0ec52 View commit details
    Browse the repository at this point in the history

  15. Put popup on hold till update cycle is done

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    18ea656 View commit details
    Browse the repository at this point in the history

  16. Reconfigure updater whenever setting changes

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8ec4a4b View commit details
    Browse the repository at this point in the history

  17. Refactor updateProgress

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1adf8b3 View commit details
    Browse the repository at this point in the history

  18. Minor refactoring

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    73c4daf View commit details
    Browse the repository at this point in the history

  19. Reintroduce cached result

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    21a9710 View commit details
    Browse the repository at this point in the history

  20. Refactor new version check for UI

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9943227 View commit details
    Browse the repository at this point in the history

  21. Fix overaggressive updater reconfiguration

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6bd72d6 View commit details
    Browse the repository at this point in the history

  22. Fix release note tab state

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7b09024 View commit details
    Browse the repository at this point in the history

  23. Different checkpoints for different update options

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    479b28d View commit details
    Browse the repository at this point in the history

  24. Remove unnecessary code

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9a4d060 View commit details
    Browse the repository at this point in the history

  25. Disable update mode switching if session is in progress

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    aaa2304 View commit details
    Browse the repository at this point in the history

  26. Rename isNewVersionAvailable to hasPendingUpdate and fix edge case wh… 

    …ere UI stuck loading when switching between browser update modes
    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8dd0c50 View commit details
    Browse the repository at this point in the history

  27. Fix stuck hasPendingStatus

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2d49b14 View commit details
    Browse the repository at this point in the history

  28. Check for update upon starting the app

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2ddb68f View commit details
    Browse the repository at this point in the history

  29. Simplify user driver

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f28f4e3 View commit details
    Browse the repository at this point in the history

  30. Dot goes away when menu opens

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    eae15e8 View commit details
    Browse the repository at this point in the history

  31. Add setNeedsDisplay

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3da45e5 View commit details
    Browse the repository at this point in the history

  32. Add shouldShowUpdateNotification logic

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    adc04d5 View commit details
    Browse the repository at this point in the history

  33. Check for update when release note / about page is loaded and when it… 

    …'s due based on SULastCheckTime
    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1f3c6ff View commit details
    Browse the repository at this point in the history

  34. Fix stuck state when switching between modes

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    049d829 View commit details
    Browse the repository at this point in the history

  35. Add DEBUG check

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9061ba3 View commit details
    Browse the repository at this point in the history

  36. Avoid overlapping popup

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1a52a17 View commit details
    Browse the repository at this point in the history

  37. Code cleanup

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    81e001d View commit details
    Browse the repository at this point in the history

  38. Update copy

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2a15a3c View commit details
    Browse the repository at this point in the history

  39. Fix last checked date showing - when idling

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    077add9 View commit details
    Browse the repository at this point in the history

  40. Revert "Increase build number (to be reverted)" and update appcast2 U… 

    …RL (to be reverted)

This reverts commit e1deee3.
    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    655b53e View commit details
    Browse the repository at this point in the history

  41. Oops, wrong URL

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0ba11ed View commit details
    Browse the repository at this point in the history

  42. Revert browserRestart behaviour and undo debug changes

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    a950d14 View commit details
    Browse the repository at this point in the history

  43. Fix swiftlint

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    67cb390 View commit details
    Browse the repository at this point in the history

  44. Add missing SPARKLE checks

    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    78e08d0 View commit details
    Browse the repository at this point in the history

  45. Design improvements to automatic update flow (#3344) 

    Task/Issue URL:
https://app.asana.com/0/1201037661562251/1208183525704010/f
Tech Design URL:
CC:
Figma:
https://www.figma.com/design/vDBpSFDzW0eN7nwpS95gju/macOS-update-process?node-id=2359-52971&t=KnvIdm2f7PRjNwfK-4

**Description**:

**Steps to test this PR**:
1. Change the appcast URL to an invalid URL to test the error state
2. Play with different update options to see if update works

<!--
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be
marked with the `DO NOT MERGE` label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the `Pending Product
Review` label.

If at any point it isn't actively being worked on/ready for
review/otherwise moving forward (besides the above PR/PFR exception)
strongly consider closing it (or not opening it in the first place). If
you decide not to close it, make sure it's labelled to make it clear the
PRs state and comment with more information.
-->

**Definition of Done**:

* [ ] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

---
###### Internal references:
[Pull Request Review
Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f)
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
[Pull Request
Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
    @quanganhdo
    quanganhdo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    bdc7a75 View commit details
    Browse the repository at this point in the history