-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dominik/ntp search bar experiment #3419
Open
ayoy
wants to merge
9
commits into
dominik/ntp-search-bar
Choose a base branch
from
dominik/ntp-search-bar-experiment
base: dominik/ntp-search-bar
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+704
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
force-pushed
the
dominik/ntp-search-bar-experiment
branch
2 times, most recently
from
October 20, 2024 19:46
9f7dcd8
to
126784e
Compare
ayoy
force-pushed
the
dominik/ntp-search-bar-experiment
branch
from
October 20, 2024 19:47
126784e
to
6359e77
Compare
SabrinaTardio
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected!
I left a couple of comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208262570807667/f
Description:
This change adds pixels for tracking NTP Search Box experiment.
Steps to test this PR:
DefaultNewTabPageSearchBoxExperimentCohortDecider.cohort
to return.control
.experiment
cohort.Verifying experiment pixel:
m_mac_initial-search
.m_mac_initial-search-day-1
is sent with acount = 1
andfrom = ntp_search_bar
m_mac_initial-search-day-1
is sent with acount = 2
andfrom = ntp_address_bar
m_mac_initial-search-day-1
is sent with acount = 3
andfrom = address_bar
count = 10
m_mac_initial-search-day-2
is sent with acount = 1
and appropriate from parameter.Verifying autocomplete pixel parameters:
m_mac_autocomplete_*
) with the correctfrom
parameter, and the experiment cohort.Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation