Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dominik/ntp search bar experiment #3419

Merged
merged 11 commits into from
Oct 21, 2024
Merged

Dominik/ntp search bar experiment #3419

merged 11 commits into from
Oct 21, 2024
+703 −15

Commits on Oct 20, 2024

  1. Add NewTabSearchBoxExperiment

    @ayoy
    ayoy committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    e226198 View commit details
    Browse the repository at this point in the history

  2. Fire experiment pixels

    @ayoy
    ayoy committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    d27f7d8 View commit details
    Browse the repository at this point in the history

  3. Prepare NewTabPageSearchBoxExperiment for unit testing

    @ayoy
    ayoy committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    43a77b8 View commit details
    Browse the repository at this point in the history

  4. Make experiment work for existing users too

    @ayoy
    ayoy committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    b638565 View commit details
    Browse the repository at this point in the history

  5. Add unit tests for NewTabPageSearchBoxExperiment

    @ayoy
    ayoy committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    6359e77 View commit details
    Browse the repository at this point in the history

  6. Fix Swiftlint violation

    @ayoy
    ayoy committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    5fd6c49 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Extract experiment setup code into a function

    @ayoy
    ayoy committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    aae7fbd View commit details
    Browse the repository at this point in the history

  2. Improve naming in the experiment code

    @ayoy
    ayoy committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    61b2a6a View commit details
    Browse the repository at this point in the history

  3. Rename test pixel reporter class

    @ayoy
    ayoy committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    ce55e69 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dominik/ntp-search-bar' into dominik/ntp-search-bar-exp… 

    …eriment
    @ayoy
    ayoy committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8a6a51c View commit details
    Browse the repository at this point in the history

  5. Fix Swiftlint violation

    @ayoy
    ayoy committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d42f878 View commit details
    Browse the repository at this point in the history