Fix to load app's ini files after all other extensions are loaded #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leroy0211
commented
Apr 25, 2024
bkosun
suggested changes
Apr 26, 2024
Co-authored-by: Borislav Kosun <kosun.b@yandex.com>
|
@dunglas I there a reason this is not merged yet? |
|
Thanks @leroy0211 for fixing this and @bkosun for the review 😉 |
Trim
added a commit
to Trim/symfony-docker
that referenced
this pull request
Aug 8, 2024
…i file With the fix to load app's ini files after all other extensions are loaded (dunglas#617), the app-dev.ini file has been renamed 20-app.dev.ini and has been moved to a folder named "app.conf.d". Although, the fix forgot to update the development environment file `compose.override.yaml` with the new name and location.
dunglas
pushed a commit
that referenced
this pull request
Aug 8, 2024
…#652) With the fix to load app's ini files after all other extensions are loaded (#617), the app-dev.ini file has been renamed 20-app.dev.ini and has been moved to a folder named "app.conf.d". Although, the fix forgot to update the development environment file `compose.override.yaml` with the new name and location.
VitaliyMinenko
pushed a commit
to VitaliyMinenko/notofication-service
that referenced
this pull request
Sep 16, 2024
…nglas#617) Co-authored-by: Borislav Kosun <kosun.b@yandex.com> Co-authored-by: Leroy Baeyens <leroybaeyens@leroys-mbp.home>
VitaliyMinenko
pushed a commit
to VitaliyMinenko/notofication-service
that referenced
this pull request
Sep 16, 2024
…dunglas#652) With the fix to load app's ini files after all other extensions are loaded (dunglas#617), the app-dev.ini file has been renamed 20-app.dev.ini and has been moved to a folder named "app.conf.d". Although, the fix forgot to update the development environment file `compose.override.yaml` with the new name and location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #538 by specifying a different
conf.ddirectory (app.conf.d) for loading the ini files.Renamed the files to numerical prefixes so they are loaded in the correct order. Default first, then environment specific.
After running a dev build, this is the output of
php --ini