Hotfix: Improved Logging Instrumentation #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also updated method call in exceptions initialiser
Set the Internal Error Instrumentation to an `unless` statement to ensure the application does not report internal errors to the Prometheus metrics when the error is a 404 thereby reducing the noise in the Slack alerts channel
Split the error logging into it's own method as well as adjusted the logged message to be either the response message or the response status
from 1.7.5 ~> 1.7.6
joescottdave
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes in order to reduce the log noise as a result of improved error handling in the application:
unlessstatement toensure the application does not report internal errors to the Prometheus
metrics when the error is a 404 thereby reducing the noise in the Slack alerts
channel
render_errormethod tohandle_errorlogged message to be either the response message or the response status