Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribuciones #9

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Contribuciones #9

merged 5 commits into from
Oct 17, 2024

Conversation

Joskerus
Copy link
Contributor

@Joskerus Joskerus commented Oct 11, 2024

Fix #8

  • Please check if the PR fulfills these requirements
  • I have read the CONTRIBUTING guidelines
  • A new item has been added to NEWS.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Checks have been run locally and pass
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

Copy link

github-actions bot commented Oct 11, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/epiverse-trace/epitkit/compare/md-outputs..md-outputs-PR-9

The following changes were observed in the rendered markdown documents:

 Reporte.md              |    1 +
 fig/R0s_plot.jpeg (new) |  Bin 0 -> 46135 bytes
 fig/ilustracion_imc.png |  Bin 341095 -> 54307 bytes
 md5sum.txt              |    4 +-
 reference.md            | 1276 ++++++++++++++++++++++++++++++++++++++++++++++-
 5 files changed, 1276 insertions(+), 5 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-10-17 12:09:58 +0000

@Joskerus
Copy link
Contributor Author

Cambios a las unidades y glosario

@Joskerus Joskerus marked this pull request as ready for review October 11, 2024 22:44
github-actions bot pushed a commit that referenced this pull request Oct 16, 2024
Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias por la actualizacion! Solo solicito que aceptes los cambios del formato de tablas en markdown, porque se construyen con espacios entre palabras. Una herramienta que funciona bien es https://www.tablesgenerator.com/markdown_tables

learners/reference.md Outdated Show resolved Hide resolved
learners/reference.md Outdated Show resolved Hide resolved
Co-authored-by: Andree Valle Campos <avallecam@gmail.com>
github-actions bot pushed a commit that referenced this pull request Oct 16, 2024
Co-authored-by: Andree Valle Campos <avallecam@gmail.com>
github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
@avallecam
Copy link
Member

listo para el merge 🚀

en una actualizacion aparte podemos convertir el glosario en Rmd para que pueda alojar el codigo de la imagen que compara R0 #11

@avallecam avallecam merged commit 292fcef into main Oct 17, 2024
3 checks passed
@avallecam avallecam deleted the contribuciones branch October 18, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add glosario
2 participants