chore: add read-only audit for stuck in_progress feature_backlog rows - #555
Open
essentialbit wants to merge 6 commits into
Open
chore: add read-only audit for stuck in_progress feature_backlog rows#555essentialbit wants to merge 6 commits into
essentialbit wants to merge 6 commits into
Conversation
reconcile_feature_backlog.py only backfills a row whose own linked GitHub issue closed. It misses the class documented in memory (proposal ids 21/20/18): an in_progress row whose issue is still open with no PR ever actually merged against it. This script surfaces that evidence via the issue timeline, filtered through a closes/fixes/resolves #N regex on each candidate PR's body -- a raw cross-reference check false-positives on any PR/issue that merely mentions the number (confirmed live against issue #103, which pulled in five unrelated merged PRs before the regex filter). Read-only: never writes to feature_backlog, never calls mark_proposal_done.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/audit_stuck_in_progress.py: read-only report overfeature_backlogrows atstatus='in_progress', complementingreconcile_feature_backlog.py(which only catches a row whose own linked issue closed).closes|fixes|resolves #Nregex on the PR body — a raw timeline cross-reference alone is not sufficient evidence (verified live against issue Macro regime detector: FRED API (CPI/PMI/unemployment/yield curve) classifying risk-on/risk-off and inflation/deflation #103: five unrelated merged PRs showed up as cross-referenced purely from sibling proposals' "distinct from Macro regime detector: FRED API (CPI/PMI/unemployment/yield curve) classifying risk-on/risk-off and inflation/deflation #103" boilerplate text; none actually closed it).feature_backlog, never callsmark_proposal_done().This is the self-directed-tooling precedent (no consensus/outcome-recording needed) — the debated feature backlog is currently empty, so this cycle used the implementation slot for a real tooling gap instead of forcing a low-value pick.
Test plan
PYTHONPATH=. python3 scripts/audit_stuck_in_progress.pyagainst the live DB — reports cleanly (0 stuck rows currently, matches known state)_linked_prs()against issue Macro regime detector: FRED API (CPI/PMI/unemployment/yield curve) classifying risk-on/risk-off and inflation/deflation #103 (open, no real closing PR) — correctly returns[]after the regex fix; before the fix it incorrectly returned 6 unrelated merged PRs_linked_prs()against issue 10-Year Breakeven Inflation Rate (FRED T10YIE) -- market-implied inflation expectation macro badge #189 (closed by PR feat: 10Y breakeven inflation rate (T10YIE) macro-strip badge (closes #189) #205, body contains "closes 10-Year Breakeven Inflation Rate (FRED T10YIE) -- market-implied inflation expectation macro badge #189") — correctly returns that one PR asmergedpython3 -c "from main import app"— imports clean