Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Italian language #1247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Italian language #1247

wants to merge 1 commit into from

Conversation

Deltwin
Copy link

@Deltwin Deltwin commented Jul 13, 2024 •
edited
Loading

Just a few improvements for the italian language.

Description

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

@Deltwin
Update Italian language
7454709 
The previous one wasn't too bad, but not the best.
jacopotediosi
jacopotediosi approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@jacopotediosi jacopotediosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a native Italian, these all seem like reasonable changes to me.
I don't see any problems here.

@jacopotediosi
Copy link
Contributor

Just one thing: I see that in the PR description nothing was indicated about the tests performed.
Have these translations been tested on a unit with the screen officially supported by the pwnagotchi project, the Waveshare eInk 2.13”? Do they look good, considering their length and position?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacopotediosi jacopotediosi jacopotediosi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Deltwin @jacopotediosi