Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] improve logs announcing loading of env variables #2643

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Oct 21, 2024

Why

Improve logs announcing loading env vars.

https://exponent-internal.slack.com/archives/C06FK950085/p1729215938823339?thread_ts=1729186741.835629&cid=C06FK950085

How

Improve logs

Test Plan

Test manually.

Copy link
Member Author

szdziedzic commented Oct 21, 2024

@szdziedzic szdziedzic marked this pull request as ready for review October 21, 2024 12:36
Copy link

CodeMention:

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela
packages/eas-cli/src/build/** @szdziedzic, @khamilowicz, @sjchmiela

Copy link

github-actions bot commented Oct 21, 2024

Size Change: +914 B (0%)

Total Size: 53 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53 MB +914 B (0%)

compressed-size-action

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 53.05%. Comparing base (5aad520) to head (38805c6).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...as-cli/src/build/evaluateConfigWithEnvVarsAsync.ts 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2643      +/-   ##
==========================================
- Coverage   53.10%   53.05%   -0.05%     
==========================================
  Files         564      566       +2     
  Lines       21498    21615     +117     
  Branches     4212     4236      +24     
==========================================
+ Hits        11415    11466      +51     
- Misses      10053    10119      +66     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@szdziedzic szdziedzic merged commit 214cff0 into main Oct 22, 2024
6 of 7 checks passed
@szdziedzic szdziedzic deleted the 10-21-_eas-cli_improve_logs_announcing_loading_of_env_variables branch October 22, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants