Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] resolve default environment automatically based on build configuration #2644

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Oct 21, 2024

Why

https://exponent-internal.slack.com/archives/C06FK950085/p1729212611408479?thread_ts=1729186741.835629&cid=C06FK950085

How

Resolve the default (if not set in the build profile) environment to use for a build based on its configuration.

Store build -> production
Dev client -> development
Other (internal) -> preview

Test Plan

Test manually

Copy link
Member Author

szdziedzic commented Oct 21, 2024

Copy link

github-actions bot commented Oct 21, 2024

Size Change: +381 B (0%)

Total Size: 53 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53 MB +381 B (0%)

compressed-size-action

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 53.02%. Comparing base (214cff0) to head (36d7cb2).

Files with missing lines Patch % Lines
...as-cli/src/build/evaluateConfigWithEnvVarsAsync.ts 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2644      +/-   ##
==========================================
- Coverage   53.05%   53.02%   -0.03%     
==========================================
  Files         566      566              
  Lines       21615    21628      +13     
  Branches     4236     4241       +5     
==========================================
  Hits        11466    11466              
- Misses      10119    10132      +13     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic marked this pull request as ready for review October 21, 2024 14:06
Copy link

CodeMention:

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela
packages/eas-cli/src/build/** @szdziedzic, @khamilowicz, @sjchmiela

@szdziedzic szdziedzic force-pushed the 10-21-_eas-cli_resolve_default_environment_automatically_based_on_build_configuration branch from f1393d6 to 0a03d18 Compare October 22, 2024 09:57
@szdziedzic szdziedzic changed the base branch from 10-21-_eas-cli_improve_logs_announcing_loading_of_env_variables to graphite-base/2644 October 22, 2024 09:57
@szdziedzic szdziedzic force-pushed the 10-21-_eas-cli_resolve_default_environment_automatically_based_on_build_configuration branch from 0a03d18 to 40294c6 Compare October 22, 2024 09:58
@szdziedzic szdziedzic changed the base branch from graphite-base/2644 to main October 22, 2024 09:58
@szdziedzic szdziedzic force-pushed the 10-21-_eas-cli_resolve_default_environment_automatically_based_on_build_configuration branch from 40294c6 to 36d7cb2 Compare October 22, 2024 09:58
Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants