Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Xcode 15 CI for Storage #11983

Merged
merged 14 commits into from
Oct 31, 2023
Merged

Add Xcode 15 CI for Storage #11983

merged 14 commits into from
Oct 31, 2023

Conversation

paulb777
Copy link
Member

#no-changelog

@google-oss-bot
Copy link

google-oss-bot commented Oct 24, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseStorage-iOS-FirebaseStorage.framework

    Overall coverage changed from ? (fd95691) to 0.00% (6bb8211) by ?.

    21 individual files with coverage change

    FilenameBase (fd95691)Merge (6bb8211)Diff
    AsyncAwait.swift?0.00%?
    Result.swift?0.00%?
    Storage.swift?0.00%?
    StorageComponent.swift?0.00%?
    StorageDeleteTask.swift?0.00%?
    StorageDownloadTask.swift?0.00%?
    StorageError.swift?0.00%?
    StorageGetDownloadURLTask.swift?0.00%?
    StorageGetMetadataTask.swift?0.00%?
    StorageListResult.swift?0.00%?
    StorageListTask.swift?0.00%?
    StorageMetadata.swift?0.00%?
    StorageObservableTask.swift?0.00%?
    StoragePath.swift?0.00%?
    StorageReference.swift?0.00%?
    StorageTask.swift?0.00%?
    StorageTaskSnapshot.swift?0.00%?
    StorageTokenAuthorizer.swift?0.00%?
    StorageUpdateMetadataTask.swift?0.00%?
    StorageUploadTask.swift?0.00%?
    StorageUtils.swift?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XjvzyT34WP.html

@google-oss-bot
Copy link

google-oss-bot commented Oct 24, 2023 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseStorage

    TypeBase (fd95691)Merge (6bb8211)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8CFEPVdoxn.html

@paulb777
Copy link
Member Author

Going to put this on hold for awhile.

Xcode 15.0 seems to trigger multiple failures that get resolved by 15.0.1, but 15.0.1 is only sporadically available. See the Xcode list in the Xcodes step between pod_lib_lint and spm_cron in https://github.com/firebase/firebase-ios-sdk/actions/runs/6641573445/job/18044420497

@paulb777
Copy link
Member Author

Now that Xcode 15.0.1 is available on GHA, it's much better.

Looks like we need something like firebase/quickstart-ios#1522 for the quickstart tests

@paulb777 paulb777 changed the title Try running matrix for both Xcode 14 and Xcode 15 Add Xcode 15 CI for Storage Oct 31, 2023
andrewheard
andrewheard approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green! Will do the same in https://github.com/google/app-check.

@paulb777 paulb777 merged commit 60ac2d8 into master Oct 31, 2023
81 checks passed
@paulb777 paulb777 deleted the pb-xc15-ci branch October 31, 2023 15:24
@paulb777 paulb777 mentioned this pull request Nov 1, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@ncooke3 ncooke3 Awaiting requested review from ncooke3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @andrewheard