Skip to content
This repository has been archived by the owner on Feb 10, 2019. It is now read-only.

Update webonyx/graphql dependency for PHP 7.3 #404

Closed
wants to merge 9 commits into from
Closed

Update webonyx/graphql dependency for PHP 7.3 #404

wants to merge 9 commits into from

Conversation

mxkxf
Copy link

@mxkxf mxkxf commented Dec 19, 2018

Fixes #403

Also removes PHP 5.5, PHP 5.6 and PHP 7.0 from Travis as they are either:

  • EOL
  • the underlying webonyx/graphql-php package has a higher minimum requirement for PHP

@mfn
Copy link

mfn commented Dec 19, 2018

The PHP 7.2 jobs look promising on Travis.

TBH I'm surprised that no code-adaption change is required ?!

@coveralls
Copy link

coveralls commented Dec 20, 2018

Coverage Status

Coverage remained the same at 70.537% when pulling 1bc5d42 on mikefrancis:update-webonyx/graphql-php into 66e9233 on Folkloreatelier:develop.

@mxkxf
Copy link
Author

mxkxf commented Dec 20, 2018

@mfn Have fixed the tests for PHP 7.1 and 7.2

@mfn
Copy link

mfn commented Dec 21, 2018

Nice! I hope I found time during the holidays to test it with my application!

@@ -20,7 +20,7 @@
"require": {
"php": ">=5.5.9",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this needs to be adjusted, too. webonxy 0.13.0 requires 7.1+

@mfn
Copy link

mfn commented Dec 21, 2018

Nice! I hope I found time during the holidays to test it with my application!

I already have to attest that I have to postpone this indefinitely.

I've upgraded webonyx locally since folklore lib doesn't need any code changes according to this PR.

However I've run into multiple incompatibilities regarding classes and function signatures I can't quickly fix. They are independent of Folklore but webonxy did refactor/adjust many things which can reach your application code nevertheless.

So, sorry, I can't give any feedback for now :|

@mxkxf
Copy link
Author

mxkxf commented Dec 28, 2018

Closing this as I moved over to the rebing/graphql-laravel package which supports PHP 7.3

@mxkxf mxkxf closed this Dec 28, 2018
@mxkxf mxkxf deleted the update-webonyx/graphql-php branch December 28, 2018 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants