Skip to content
This repository has been archived by the owner on Feb 10, 2019. It is now read-only.

Update webonyx/graphql dependency for PHP 7.3 #404

Closed
wants to merge 9 commits into from
Closed

Update webonyx/graphql dependency for PHP 7.3 #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
16b4196
Updated webonyx/graphql-php dependency
mxkxf Dec 19, 2018
ef19d3d
Test against supported versions of PHP
mxkxf Dec 19, 2018
68c1542
Updated webonyx/graphql-php dependency
mxkxf Dec 19, 2018
bb2671b
Test against supported versions of PHP
mxkxf Dec 19, 2018
daa6360
Remove more unsupported versions of PHP
mxkxf Dec 19, 2018
b25c629
Fix tests
mxkxf Dec 20, 2018
ac2d27e
Fixed travis
mxkxf Dec 20, 2018
01d3c1c
Remove composer bin
mxkxf Dec 21, 2018
1bc5d42
Remove noise
mxkxf Dec 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@ cache:
- ${TRAVIS_BUILD_DIR}/travis/extension-cache

php:
- 5.5
- 5.6
- 7.0
- 7.1
- 7.2
- 7.3

env:
- ILLUMINATE_VERSION=5.1.* PHPUNIT_VERSION=~4.0
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"require": {
"php": ">=5.5.9",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this needs to be adjusted, too. webonxy 0.13.0 requires 7.1+

"illuminate/support": "5.1.*|5.2.*|5.3.*|5.4.*|5.5.*|5.6.*|5.7.*",
"webonyx/graphql-php": "~0.10.2"
"webonyx/graphql-php": "~0.13.0"
},
"require-dev": {
"orchestra/testbench": "3.1.*|3.2.*|3.3.*|3.4.*|3.5.*",
Expand Down
16 changes: 5 additions & 11 deletions tests/GraphQLTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,17 +180,11 @@ public function testFormatError()
$error = GraphQL::formatError($result->errors[0]);

$this->assertInternalType('array', $error);
$this->assertArrayHasKey('message', $error);
$this->assertArrayHasKey('locations', $error);
$this->assertEquals($error, [
'message' => 'Cannot query field "examplesQueryNotFound" on type "Query".',
'locations' => [
[
'line' => 3,
'column' => 13
]
]
]);
$this->assertContains('Cannot query field "examplesQueryNotFound" on type "Query".', $error['message']);
$this->assertEquals([
'line' => 3,
'column' => 13
], $error['locations'][0]);
}

public function testFormatValidationError()
Expand Down