Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contact_form): Enable selection of issue type and enable Jira integration #4605

Merged
merged 9 commits into from
Oct 22, 2024

Conversation

elisa-a-v
Copy link
Contributor

@elisa-a-v elisa-a-v commented Oct 21, 2024

Addresses #4585

This update enhances the contact form by allowing users to select the "Issue Type" for their submission, and also optionally pre-select it via URL query parameters, improving UX.

Additionally, the contact form now sends submissions to support@freelawproject.atlassian.net, integrating with Jira for better issue tracking. The email body includes:

  • User Email: Displayed as User Email: <email address> to facilitate easy parsing in Jira.
  • Issue Type: Clearly stated to assist in automatic categorization within Jira.
  • Subject and Message: Retained as before for detailed context.

This change enables automatic ticket creation to relieve some of the overhead of managing requests manually by email.

…parameters

This update enhances the contact form by allowing users to select the "Issue Type" and also pre-select it via URL query parameters, improving UX.

Additionally, the contact form now sends submissions to support@freelawproject.atlassian.net, integrating with Jira for better issue tracking. The email body includes:

    User Email: Displayed as User Email: <email address> to facilitate easy parsing in Jira.
    Issue Type: Clearly stated to assist in automatic categorization within Jira.
    Subject and Message: Retained as before for detailed context.

This change enables automatic ticket creation to relieve some of the overhead of managing requests manually by email.
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ ERosendo
✅ elisa-a-v
❌ elisa-av
You have signed the CLA already but the status is still pending? Let us recheck it.

@elisa-a-v
Copy link
Contributor Author

@mlissner I had issues with the pre-commit when working on this which is why there are so many commits each doing very little, but I got it working now so it won't happen again!

I can revert them and add all the small changes in a single commit, please let me know if I should do it or just leave it as is.

Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me at a glance. Off to Eduardo for more careful review. The commits are fine, we can just squash when we merge.

Thank you and congrats on your first (official) PR!

@mlissner
Copy link
Member

@s-taube, before we merge this, have you had a chance to look at the security vuln I mentioned that this might open up?

cl/simple_pages/forms.py Outdated Show resolved Hide resolved
cl/simple_pages/views.py Outdated Show resolved Hide resolved
@s-taube
Copy link
Contributor

s-taube commented Oct 22, 2024

@s-taube, before we merge this, have you had a chance to look at the security vuln I mentioned that this might open up?

Yes. As far as I can tell, this Zendesk issue should not impact Atlassian products at all.

Copy link
Contributor

@ERosendo ERosendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is looking great! Just a couple of small things to address before we can merge this PR.

@ERosendo
Copy link
Contributor

LGTM :shipit:

@mlissner mlissner merged commit b29def5 into main Oct 22, 2024
12 of 13 checks passed
@mlissner mlissner deleted the 4585-contact-form-update branch October 22, 2024 16:39
@mlissner
Copy link
Member

OK, here we go. Thanks everybody. @s-taube, in about ten minutes, when this finishes, this code will be live and I think we'll be in Jira-land.

@mlissner
Copy link
Member

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

6 participants