Add new training for scATAC-seq batch correction using SnapATAC2 #5061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiltemann
reviewed
Jul 30, 2024
topics/single-cell/tutorials/scatac-batch-correction-snapatac2/tutorial.md
Outdated
Show resolved
Hide resolved
|
Please note I have fixed a spelling mistake in faqs/galaxy/histories_datasets_vs_collections.md. I hope it isn't a problem that I forgot to make a seperate PR for this change. |
timonschlegel
changed the title
|
This training is now ready for review |
shiltemann
reviewed
Sep 19, 2024
There was a problem hiding this comment.
Thanks @timonschlegel! I will leave the content review to the single cell experts, but this looks great from a technical point of view! Just a few minor comments inline :)
topics/single-cell/tutorials/scatac-batch-correction-snapatac2/tutorial.md
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,1675 @@ | |||
| { | |||
There was a problem hiding this comment.
It would be great if you could add a workflow test: https://training.galaxyproject.org/training-material/faqs/gtn/gtn_workflow_testing.html
There was a problem hiding this comment.
thanks for the review! I'll add the test
topics/single-cell/tutorials/scatac-batch-correction-snapatac2/workflows/main_workflow.ga
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-sample batch correction SnapATAC2 tutorial