fixes for liquid tags #1270
Open
fixes for liquid tags #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elimiters. Previous tag expansion logic: 2 regexes, 4 calls to regex functions, plus string concatenations. Simplified tag expansion logic: 1 regex + 1 call to re.sub. Support for customizing tag delimiters comes handy when used with plugins with similar tag syntax. E.g. jinja2content.
…the deprecated add(). <rant> The semantics of add() were inverse to the intuition because they were implicitly exposing the internals of markdown.util.Registry. E.g. a priority of ">htmlblock" did not translate to "have greater priority than htmlblock processor", as one would expect. Instead it means "when the interal processors array is sorted by priority, the new processor should have a bigger *index* number than htmlblock". The tricky point here is that the internal array is sorted in reverse. So ">htmlblock" actually translates to "use a smaller priority than htmlblock". Madness! And instead of fixing the semantics to make sense, it was chosen to deprecate add() and force us to directly supply the priority to register(). This is also bad, because we have to grep outside our codebase to determine the proper priority to achieve the desired effect. Double the madness! </rant>
Tests hadn't been updated after 076086c.
This is useful when the live site is hosted in a subdirectory (e.g. http://www.foo.bar/mysite) to avoid having to repeat /mysite every time.
|
The But I guess we need @mirekdlugosz to chime in here and re-evaluate all these changes. @mirekdlugosz, what should we do with this PR? |
|
Most of these changes are valuable and I would welcome ported PR in https://github.com/pelican-plugins/liquid-tags There are only two exceptions:
@m000 is this something you are still interested in? Could you re-apply your changes on top of https://github.com/pelican-plugins/liquid-tags and submit PR there? |
|
Yes, I plan to migrate the PR. I'll try to find some time for it this week.
…On Mon, 8 Feb 2021 at 12:19, Mirek Długosz ***@***.***> wrote:
Most of these changes are valuable and I would welcome ported PR in
https://github.com/pelican-plugins/liquid-tags
There are only two exceptions:
- namespaced plugins were introduced in Pelican 4.5.0, and this is
also version that dropped support for Python 2.7, so I'm afraid anything
related to Python 2 compatibility should be dropped
- fixes to include_code tag I have applied independently while porting
plugin, so they are no longer needed
@m000 <https://github.com/m000> is this something you are still
interested in? Could you re-apply your changes on top of
https://github.com/pelican-plugins/liquid-tags and submit PR there?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1270 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAUQQMSBTTAPQ6PG7IIJG3S57CDFANCNFSM4N5F6PCA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of fixes for liquid tags:
py27-ipython3andpy37-ipython3. Tests for the notebook tag still fail.Plus a new feature:
{%and%}to mark their blocks (e.g. jinja2content).