Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for liquid tags #1270

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

fixes for liquid tags #1270

wants to merge 15 commits into from

Commits on Jun 13, 2020

  1. liquid_tags: Text files should not be marked executable.

    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    4c73429 View commit details
    Browse the repository at this point in the history

  2. liquid_tags: Added python3.6 and python3.7 to testing.

    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    32ce3a3 View commit details
    Browse the repository at this point in the history

  3. liquid_tags: Only run preprocessor again if liquid_tags.include_code … 

    …is enabled.
    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    5760d1a View commit details
    Browse the repository at this point in the history

  4. liquid_tags: Simplified tag expansion logic. Support for custom tag d… 

    …elimiters.

Previous tag expansion logic: 2 regexes, 4 calls to regex functions,
plus string concatenations.
Simplified tag expansion logic: 1 regex + 1 call to re.sub.

Support for customizing tag delimiters comes handy when used with
plugins with similar tag syntax. E.g. jinja2content.
    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    6c8d236 View commit details
    Browse the repository at this point in the history

  5. liquid_tags: Added test for customized tag delimiters.

    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    9bb8f1f View commit details
    Browse the repository at this point in the history

  6. liquid_tags: Registering md preprocessor with register() rather than … 

    …the deprecated add().

<rant>
The semantics of add() were inverse to the intuition because they were
implicitly exposing the internals of markdown.util.Registry.

E.g. a priority of ">htmlblock" did not translate to "have greater
priority than htmlblock processor", as one would expect. Instead it
means "when the interal processors array is sorted by priority, the
new processor should have a bigger *index* number than htmlblock".
The tricky point here is that the internal array is sorted in reverse.
So ">htmlblock" actually translates to "use a smaller priority than
htmlblock". Madness!

And instead of fixing the semantics to make sense, it was chosen
to deprecate add() and force us to directly supply the priority to
register(). This is also bad, because we have to grep outside our
codebase to determine the proper priority to achieve the desired effect.
Double the madness!
</rant>
    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    dc744e2 View commit details
    Browse the repository at this point in the history

  7. liquid_tags: python2.7 fixes for include_code tag test.

    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    289170e View commit details
    Browse the repository at this point in the history

  8. liquid_tags: python2.7 compatibility fixes for include_code.

    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    430135f View commit details
    Browse the repository at this point in the history

  9. liquid_tags: Updated expected results for include_code tests. 

    Tests hadn't been updated after 076086c.
    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    ff41420 View commit details
    Browse the repository at this point in the history

  10. liquid_tags: Fixed deprecation warning occuring in test_generic.

    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    c067b3d View commit details
    Browse the repository at this point in the history

  11. liquid_tags: Fixed include_code test to properly compare non utf-8 va… 

    …lues.
    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    dd14c7f View commit details
    Browse the repository at this point in the history

  12. liquid_tags: Fixed use of non-existent global variable.

    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    9711b8c View commit details
    Browse the repository at this point in the history

  13. liquid_tags: Consolidated tests for iPython2/iPython3 in test_generat… 

    …ion.
    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    d8ab315 View commit details
    Browse the repository at this point in the history

  14. liquid_tags: Prepend SITEURL to src when it is an absolute path. 

    This is useful when the live site is hosted in a subdirectory
(e.g. http://www.foo.bar/mysite) to avoid having to repeat /mysite
every time.
    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    fa9795e View commit details
    Browse the repository at this point in the history

  15. liquid_tags: Added documentation for custom tag delimiters.

    @m000
    m000 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    06bc3b0 View commit details
    Browse the repository at this point in the history