Refetch shipping on coupon application - #1441
Open
pbennett1-godaddy wants to merge 6 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: b64fff2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pbennett1-godaddy
changed the base branch from
main
to
fix-billing-collection-logic
August 26, 2026 16:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure discount changes correctly reconcile shipping rates and taxes without duplicate requests or stale totals.
Discounts can change shipping eligibility, including enabling or disabling free shipping. The checkout now refetches shipping methods after a successful discount change when a valid shipping
destination is available. It determines whether the returned rates require shipping reconciliation and assigns the final tax calculation to either the discount or shipping workflow, ensuring taxes run
exactly once.
This PR also improves shipping defaults and express checkout discount synchronization.
Key changes
PriceAdjustmentsrequests caused by unrelated draft-order updates.PURCHASEfulfillment state.Changeset
Test Plan
Validation completed:
pnpm --filter @godaddy/react typecheckpnpm --filter @godaddy/react test