Skip to content

Refetch shipping on coupon application #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pbennett1-godaddy wants to merge 6 commits into
base: fix-billing-collection-logic
Choose a base branch
from
Open

Refetch shipping on coupon application #1441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6da79fb
refetch shipping methods and recalc taxes on coupon application
pbennett1-godaddy Aug 26, 2026
b284c92
add tests and changeset
pbennett1-godaddy Aug 26, 2026
12d9f5b
add reconcileAfterDiscount hook
pbennett1-godaddy Aug 26, 2026
a6da3cc
fix duplicate shipping reconciliation when shipping rates fails or re…
pbennett1-godaddy Aug 26, 2026
b64fff2
bail on shipping and methods if API failure
pbennett1-godaddy Aug 26, 2026
58857d0
keeps the previous shipping selection when discount reconciliation fails
pbennett1-godaddy Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-coupons-ship.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@godaddy/react": patch
---

Keep shipping rates, discounts, taxes, and express checkout in sync when coupons change.
6 changes: 3 additions & 3 deletions packages/react/src/components/checkout/__tests__/checkout-digital-fulfillment.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ describe('Digital fulfillment checkout', () => {
).toBeVisible();
});

it('hides express for mixed digital and pickup orders', async () => {
it('shows express for mixed digital and pickup orders when shipping is enabled', async () => {
renderCheckout({
draftOrderOverrides: {
lineItems: [
Expand All @@ -362,8 +362,8 @@ describe('Digital fulfillment checkout', () => {
await waitForCheckoutReady();

expect(
screen.queryByTestId('mock-godaddy-express-button')
).not.toBeInTheDocument();
await screen.findByTestId('mock-godaddy-express-button')
).toBeVisible();
});

it('does not let digital NONE lines trigger shipping fulfillment sync', async () => {
Expand Down
Loading