Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype: Rudimentary stack profiler #529

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/jsonnet/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,9 @@ func main() {
cmd.StartCPUProfile()
defer cmd.StopCPUProfile()

jsonnet.StartStackProfile()
defer jsonnet.StopStackProfile()

vm := jsonnet.MakeVM()
vm.ErrorFormatter.SetColorFormatter(color.New(color.FgRed).Fprintf)

Expand Down
43 changes: 43 additions & 0 deletions interpreter.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,18 @@ limitations under the License.
package jsonnet

import (
"bufio"
"bytes"
"fmt"
"io"
"log"
"math"
"math/rand"
"os"
"reflect"
"sort"
"strconv"
"strings"

"github.com/google/go-jsonnet/ast"
"github.com/google/go-jsonnet/astgen"
Expand Down Expand Up @@ -968,7 +973,45 @@ func jsonToValue(i *interpreter, v interface{}) (value, error) {
}
}

var (
stackProfileOut *bufio.Writer
stackProfileRatio = 0.01
)

func StartStackProfile() {
var err error

if os.Getenv("JSONNET_STACK_PROFILE") != "" {
stackProfileOutFile, err := os.Create(os.Getenv("JSONNET_STACK_PROFILE"))
if err != nil {
log.Fatal("could not create stack profile: ", err)
}
stackProfileOut = bufio.NewWriter(stackProfileOutFile)
}

if os.Getenv("JSONNET_STACK_PROFILE_RATIO") != "" {
stackProfileRatio, err = strconv.ParseFloat(os.Getenv("JSONNET_STACK_PROFILE_RATIO"), 64)
if err != nil {
log.Fatal("could not parse stack profile ratio: ", err)
}
}
}

func StopStackProfile() {
if stackProfileOut != nil {
stackProfileOut.Flush()
}
}

func (i *interpreter) EvalInCleanEnv(env *environment, ast ast.Node, trimmable bool) (value, error) {
if stackProfileOut != nil && rand.Float64() < stackProfileRatio {
stack := []string{}
for _, frame := range i.getCurrentStackTrace() {
stack = append(stack, frame.Loc.String()+":"+frame.Name)
}
fmt.Fprintln(stackProfileOut, strings.Join(stack, ";")+" 1")
}

err := i.newCall(*env, trimmable)
if err != nil {
return nil, err
Expand Down