More improvements to trait resolution #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems unneeded now?
This is still not a complete solution because we're not sure if the nested obligations correspond 1-to-1 to the `predicates_defined_on` list.
This is possibly unsound but not more so than comparing strings
|
Charon breakage is because this fixes some bugs which is great |
W95Psp
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
That PR looks great to me, thank you! 🎉
You did a great job there, thanks :)
Let's merge that, @maximebuyse told me at the moment this is indeed fixing the regression #974!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few more things about trait resolution. In particular, I added a step that removes all regions so we can finally use normal equality between predicates instead of comparing strings. This should hopefully fix most binder issues, including #974.