Add distinction between two unallowed cases in name check "eval_" #489
+10
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
sanity_check_dataset_name()
There was a bug within the
sanity_check_dataset_name()
function. When thecontrol_robot.py
script was executed for evaluation and the repo-id did not start with "eval_" it was raising a wrong ValueError.This caused some confusion because it was unclear that the prefix "eval_" is needed.
How it was tested
How to checkout & try? (for the reviewer)
Examples:
This should raise the right error message:
(Taken from the SO-100 Guide)