Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: instantiate router config in warp generators #4807

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

daniel-savu
Copy link
Contributor

Description

Uncomments generator code to actually instantiate a routerConfig, as recommended in #4799 (comment)

Drive-by changes

Related issues

Backward compatibility

Testing

Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: 86d3ef9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.27%. Comparing base (db5875c) to head (86d3ef9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4807   +/-   ##
=======================================
  Coverage   74.27%   74.27%           
=======================================
  Files         101      101           
  Lines        1481     1481           
  Branches      192      192           
=======================================
  Hits         1100     1100           
  Misses        360      360           
  Partials       21       21           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 77.77% <ø> (ø)
isms 77.77% <ø> (ø)
token 89.01% <ø> (ø)
middlewares 77.58% <ø> (ø)

daniel-savu and others added 2 commits November 4, 2024 12:38
…ig.ts

Co-authored-by: Trevor Porter <tkporter4@gmail.com>
…ig.ts

Co-authored-by: Trevor Porter <tkporter4@gmail.com>
@daniel-savu daniel-savu added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit ffbc13c Nov 4, 2024
34 checks passed
@daniel-savu daniel-savu deleted the dan/eclipse-leftover-nits branch November 4, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants