Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(test-cmd-api-server): jestify plugin-import-with-npm-install-version #3555

Conversation

petermetz
Copy link
Contributor

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (created an issue for the failing check fix)

Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've re-run failing codegen test

@petermetz
Copy link
Contributor Author

LGTM (created an issue for the failing check fix)

@jagpreetsinghsasan Thank you very much! We must be close to eliminating all the edge cases with the commit message checks! :-)

@petermetz
Copy link
Contributor Author

LGTM, I've re-run failing codegen test

@outSH Awesome, thank you for that! Fingers crossed that I'll have some time soon to stabilize the codegen!

…sion

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the test-test-cmd-api-server-npm-install-with-version-jestify branch from 71845e9 to d6a34af Compare September 30, 2024 14:49
@petermetz petermetz merged commit 499f703 into hyperledger-cacti:main Sep 30, 2024
144 of 148 checks passed
@petermetz petermetz deleted the test-test-cmd-api-server-npm-install-with-version-jestify branch September 30, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants