Assorted cleanup of DSA CryptoKey related classes #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value is used relatively frequently for various routing related purposes, keep the computed hash around for future use.
The `keyId` method has no reasonable use, whereas `compareTo` exists without implementing the Comparable interface. Remove both.
bertm
force-pushed
the
cleanup-cryptokey
branch
from
cb127a0
to
643e8be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A grab bag of code cleanup in CryptoKey, its subclasses and their related uses.
Most substantial change and reason for starting this exercise was the dubious (testing?) code in CryptoKey itself, that would allow instantiation of gadget classes if it was actually used (but it is not).
Next there is a lot of copying going on for immutable classes. This is now removed, and actual defensive copying for byte array is added.
This assumes that the wildest methods in these classes are not actually used anywhere outside of Fred.
Note: If we are somewhat confident that these methods are not used in plugins either, then I would also love to remove the SimpleFieldSet related methods.