Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted cleanup of DSA CryptoKey related classes #986

Open
wants to merge 10 commits into
base: next
Choose a base branch
from
Open

Assorted cleanup of DSA CryptoKey related classes #986

wants to merge 10 commits into from

Commits on Oct 5, 2024

  1. CryptoKey: remove commented out code

    @bertm
    bertm committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    8a19463 View commit details
    Browse the repository at this point in the history

  2. CryptoKey: remove testing code

    @bertm
    bertm committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    da47d18 View commit details
    Browse the repository at this point in the history

  3. CryptoKey: stop making defensive copies of immutable data

    @bertm
    bertm committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    d9bab79 View commit details
    Browse the repository at this point in the history

  4. CryptoKey: simplify fingerprint code

    @bertm
    bertm committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    a18feb3 View commit details
    Browse the repository at this point in the history

  5. CryptoKey: remove unnecessary serialization constructors

    @bertm
    bertm committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    61b4acd View commit details
    Browse the repository at this point in the history

  6. CryptoKey: simplify equals and hashCode

    @bertm
    bertm committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    06c8a9a View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. CryptoKey: cache lazily computed key hash in DSAPublicKey 

    This value is used relatively frequently for various routing related
purposes, keep the computed hash around for future use.
    @bertm
    bertm committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    965730e View commit details
    Browse the repository at this point in the history

  2. CryptoKey: ensure same checks for all DSAPublicKey constructors

    @bertm
    bertm committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    92b1f1c View commit details
    Browse the repository at this point in the history

  3. CryptoKey: remove odd unused methods from DSAPublicKey 

    The `keyId` method has no reasonable use, whereas `compareTo` exists
without implementing the Comparable interface. Remove both.
    @bertm
    bertm committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    1fb091a View commit details
    Browse the repository at this point in the history

  4. CryptoKey: assorted cleanup

    @bertm
    bertm committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    643e8be View commit details
    Browse the repository at this point in the history