Add full typing support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove now unused _coqpit_json_default().
- instead of undocumented __args__ and __origin__ attributes. - remove now unused safe_issubclass() - make helpers private
- implement all possible overloads - new values will now be always added, this can't be configured anymore This method doesn't seem to be used in Trainer or TTS, so this change shouldn't have a direct effect.
Previously, class and instance methods were inconsistently mixed.
Mostly NoneType and UnionType are only available from 3.10
Colombine-cyber
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be the first release of our Coqpit fork. It's a relatively large PR because I added full typing support checked with
mypy --strictand enabled almost all ruff linter rules. This required some minor changes in functionality so that everything is consistent, but they shouldn't have an effect on Trainer or TTS. Test coverage for Coqpit is also very high.In any case, releasing this now is fine because TTS and Trainer need to be manually switched to this fork at a later stage, but I already checked that the Trainer and TTS test suites pass in idiap/coqui-ai-Trainer#10 and idiap/coqui-ai-TTS#110