Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full typing support #3

Merged
merged 27 commits into from
Nov 5, 2024
Merged

Add full typing support #3

merged 27 commits into from
Nov 5, 2024

Commits on Oct 18, 2024

  1. build: add typing_extensions

    @eginhard
    eginhard committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1f3d114 View commit details
    Browse the repository at this point in the history

  2. docs: fix typos, improve docstrings

    @eginhard
    eginhard committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f901d57 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. chore: improve types

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    4e3ee4a View commit details
    Browse the repository at this point in the history

  2. refactor: add/improve type aliases

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    fa31c70 View commit details
    Browse the repository at this point in the history

  3. chore: use Self return type hint

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    6524511 View commit details
    Browse the repository at this point in the history

  4. test: correctly handle exceptions in tests

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    2ce69f5 View commit details
    Browse the repository at this point in the history

  5. fix: correctly serialize when dumping to json 

    Remove now unused _coqpit_json_default().
    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    fd01bf9 View commit details
    Browse the repository at this point in the history

  6. feat: add _drop_none_type() to better handle optional fields

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    37299fb View commit details
    Browse the repository at this point in the history

  7. fix: use get_args and get_origin, update helpers 

    - instead of undocumented __args__ and __origin__ attributes.
- remove now unused safe_issubclass()
- make helpers private
    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    5fee09f View commit details
    Browse the repository at this point in the history

  8. chore: do not re-export dataclass

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    c98d2de View commit details
    Browse the repository at this point in the history

  9. test: add more serialization test cases

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    bcb0f05 View commit details
    Browse the repository at this point in the history

  10. fix: do not assign to self

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    0894100 View commit details
    Browse the repository at this point in the history

  11. refactor: simplify recursive getters and setters

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    0136527 View commit details
    Browse the repository at this point in the history

  12. refactor: simplify code and add type hints

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    99de702 View commit details
    Browse the repository at this point in the history

  13. fix: correctly serialize Serializable type

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    2349aff View commit details
    Browse the repository at this point in the history

  14. fix!: make Coqpit.update() consistent with superclass 

    - implement all possible overloads
- new values will now be always added, this can't be configured anymore

This method doesn't seem to be used in Trainer or TTS, so this change shouldn't
have a direct effect.
    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    52b00ac View commit details
    Browse the repository at this point in the history

  15. fix: deserialize needs to be called as instance method

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    578747b View commit details
    Browse the repository at this point in the history

  16. fix: correctly initialize from argparse 

    Previously, class and instance methods were inconsistently mixed.
    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    db183f2 View commit details
    Browse the repository at this point in the history

  17. build: switch from setuptools to hatchling

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    b0090c2 View commit details
    Browse the repository at this point in the history

  18. feat: declare typing support, run mypy in pre-commit

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    2c6929e View commit details
    Browse the repository at this point in the history

  19. fix: adapt type hints to Python 3.9 

    Mostly NoneType and UnionType are only available from 3.10
    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    650926c View commit details
    Browse the repository at this point in the history

  20. fix: replace asserts with exceptions

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    9891289 View commit details
    Browse the repository at this point in the history

  21. refactor: enable (almost) all lint rules

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    0563504 View commit details
    Browse the repository at this point in the history

  22. test: improve coverage

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    44128ec View commit details
    Browse the repository at this point in the history

  23. chore: update pypi package name

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    61066c9 View commit details
    Browse the repository at this point in the history

  24. chore: bump version to 0.1.0

    @eginhard
    eginhard committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    39adee3 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. ci: update uv version, switch to pep 735 standard

    @eginhard
    eginhard committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8fbbc9d View commit details
    Browse the repository at this point in the history