Fixes for dark mode display #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 36.58% 36.22% -0.36%
==========================================
Files 108 108
Lines 11489 11454 -35
==========================================
- Hits 4203 4149 -54
- Misses 7286 7305 +19 ☔ View full report in Codecov by Sentry. |
btbest
approved these changes
Aug 22, 2024
the widgets themselves already enforce the `softlimits` via `onChangedMaxBox` and `onChangedMinBox`. Dtype limits are already enforced via `spinbox.setRange`. That code also removed a line which would set the background color explicitly - without it, it looks fine in both, light and dark mode.
plus some black autoformatting for long lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to ilastik/ilastik#2898
Comes down to remove explicit background color settings, or make them palette-dependent colors.
Also removed unnecessary validation code in
ValueRangeWidget(added some more tests instead ;))