Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for dark mode display #314

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Fixes for dark mode display #314

merged 3 commits into from
Aug 28, 2024

Commits on Aug 28, 2024

  1. Add more valueRangeWidget tests

    @k-dominik
    k-dominik committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e2d879c View commit details
    Browse the repository at this point in the history

  2. removed validation code in ValueRangeWidget, fixed display in dark mode 

    the widgets themselves already enforce the `softlimits` via
`onChangedMaxBox` and `onChangedMinBox`. Dtype limits are already
enforced via `spinbox.setRange`.

That code also removed a line which would set the background color
explicitly - without it, it looks fine in both, light and dark mode.
    @k-dominik
    k-dominik committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    42984bf View commit details
    Browse the repository at this point in the history

  3. Fix dispay of AxisOrderWidget in dark mode 

    plus some black autoformatting for long lines
    @k-dominik
    k-dominik committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    2818aee View commit details
    Browse the repository at this point in the history