Local random object and Skipping malformed denovo variants #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two small issues:
make_prg
. Basically, whenever we need toget_majority_consensus_from_MSA()
, we set the seed of the random object WRT the sequences of the alignment, so that we get the exact same consensus given the same alignment. But we process multiple MSAs at the same time, which could cause issue, e.g. settingrandom.seed()
of one MSA while generating the consensus of another MSA (I was having issues with integration tests not being reproducible). We now use a local random object that prevents this issue;N
in it (closes IgnoreN
s that might have slipped through when updating PRGs #58);Most of the changed files in this PR is updating the zip files in integration tests