Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIRV] Break SPIRVVectorize pass into GenericVectorization and SPIRVVectorLowering passes. #14902

Closed
wants to merge 4 commits into from

Conversation

hanhanW
Copy link
Contributor

@hanhanW hanhanW commented Sep 1, 2023

This removes vectorization patterns from SPIRVVectorize pass and delegate it to GenericVectorization. It renames the old pass to SPIRVVectorLowering because it is mainly lowering vector ops.

@hanhanW hanhanW added benchmarks:android-gpu Run default Android GPU benchmarks benchmarks:vulkan-nvidia Run default Vulkan benchmarks on NVIDIA GPU labels Sep 1, 2023
@powderluv
Copy link
Collaborator

I was wondering how DNS could test if there was a regression :P

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

@hanhanW hanhanW changed the title DNS - Test if it has regression [SPIRV] Break SPIRVVectorize pass into GenericVectorization and SPIRVVectorLowering passes. Sep 1, 2023
@hanhanW hanhanW marked this pull request as ready for review September 1, 2023 20:51
@hanhanW
Copy link
Contributor Author

hanhanW commented Sep 1, 2023

I was wondering how DNS could test if there was a regression :P

haha, should renamed it to WIP. :p

qedawkins pushed a commit that referenced this pull request Sep 21, 2023
…gate it to GenericVectorization.

It renames the old pass to SPIRVVectorLowering because it is mainly lowering vector ops.

This is a duplicate of #14902 to push it through to completion.
qedawkins pushed a commit that referenced this pull request Sep 21, 2023
…gate it to GenericVectorization.

It renames the old pass to SPIRVVectorLowering because it is mainly lowering vector ops.

This is a duplicate of #14902 to push it through to completion.

Additionally cooperative matrix vectorization runs preparation patterns for
vectorization, so splitting apart that pass is left as TODO.
qedawkins added a commit that referenced this pull request Sep 21, 2023
…VectorLowering passes. (#15009)

This removes vectorization patterns from SPIRVVectorize pass and
delegate it to GenericVectorization. It renames the old pass to
SPIRVVectorLowering because it is mainly lowering vector ops.

This is a duplicate of #14902 to
push it through to completion authored by hanchung@google.com

Co-authored-by: Hanhan Wang <hanchung@google.com>
@kuhar
Copy link
Member

kuhar commented Sep 21, 2023

@qedawkins submitted this in #15009, so I'm going to close this one

@kuhar kuhar closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks:android-gpu Run default Android GPU benchmarks benchmarks:vulkan-nvidia Run default Vulkan benchmarks on NVIDIA GPU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants