[SPIRV] Break SPIRVVectorize pass into GenericVectorization and SPIRVVectorLowering passes. #14902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanhanW
added
benchmarks:android-gpu
|
I was wondering how DNS could test if there was a regression :P |
Abbreviated Benchmark Summary@ commit e8a34217debc305442eb4f6ec26055379a9bfd70 (no previous benchmark results to compare) Raw Latencies
[Top 3 out of 190 results showed] No improved or regressed compilation metrics 🏖️ For more information: |
hanhanW
changed the title
hanhanW
requested review from
antiagainst and
MaheshRavishankar
as code owners
haha, should renamed it to WIP. :p |
qedawkins
pushed a commit
that referenced
this pull request
Sep 21, 2023
…gate it to GenericVectorization. It renames the old pass to SPIRVVectorLowering because it is mainly lowering vector ops. This is a duplicate of #14902 to push it through to completion.
qedawkins
pushed a commit
that referenced
this pull request
Sep 21, 2023
…gate it to GenericVectorization. It renames the old pass to SPIRVVectorLowering because it is mainly lowering vector ops. This is a duplicate of #14902 to push it through to completion. Additionally cooperative matrix vectorization runs preparation patterns for vectorization, so splitting apart that pass is left as TODO.
qedawkins
added a commit
that referenced
this pull request
Sep 21, 2023
…VectorLowering passes. (#15009) This removes vectorization patterns from SPIRVVectorize pass and delegate it to GenericVectorization. It renames the old pass to SPIRVVectorLowering because it is mainly lowering vector ops. This is a duplicate of #14902 to push it through to completion authored by hanchung@google.com Co-authored-by: Hanhan Wang <hanchung@google.com>
|
@qedawkins submitted this in #15009, so I'm going to close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes vectorization patterns from SPIRVVectorize pass and delegate it to GenericVectorization. It renames the old pass to SPIRVVectorLowering because it is mainly lowering vector ops.