[SPIRV] Break SPIRVVectorize pass into GenericVectorization and SPIRVVectorLowering passes. #15009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qedawkins
added
benchmarks:android-gpu
…gate it to GenericVectorization. It renames the old pass to SPIRVVectorLowering because it is mainly lowering vector ops. This is a duplicate of #14902 to push it through to completion. Additionally cooperative matrix vectorization runs preparation patterns for vectorization, so splitting apart that pass is left as TODO.
qedawkins
force-pushed
the
spirv-vec-clean-step2
branch
from
3237e4d
to
d6cef01
Compare
qedawkins
requested review from
antiagainst and
MaheshRavishankar
as code owners
|
This pass is fairly load bearing so I'll wait for their eyes. The hope is that it is pretty much NFC though. |
kuhar
approved these changes
Sep 21, 2023
| let summary = "Vectorize Linalg ops with buffer semantics"; | ||
| let constructor = "mlir::iree_compiler::createSPIRVVectorizePass()"; | ||
| let constructor = "mlir::iree_compiler::createSPIRVVectorLoweringPass()"; |
There was a problem hiding this comment.
We should probably remove these constructors in the future and let tablegem autogenerate all of this code. But this is as a side note only, let's keep things as close to NFC as possible in this PR.
There was a problem hiding this comment.
yes we should. I split up the TD file to be per backend to do that (someday). I
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes vectorization patterns from SPIRVVectorize pass and delegate it to GenericVectorization.
It renames the old pass to SPIRVVectorLowering because it is mainly lowering vector ops.
This is a duplicate of #14902 to push it through to completion.